From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0620CC43461 for ; Mon, 14 Sep 2020 00:23:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA08B20759 for ; Mon, 14 Sep 2020 00:23:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="U1ar6Lz4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725963AbgINAXV (ORCPT ); Sun, 13 Sep 2020 20:23:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725950AbgINAXT (ORCPT ); Sun, 13 Sep 2020 20:23:19 -0400 Received: from mail-oi1-x243.google.com (mail-oi1-x243.google.com [IPv6:2607:f8b0:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D7B3C06174A for ; Sun, 13 Sep 2020 17:23:19 -0700 (PDT) Received: by mail-oi1-x243.google.com with SMTP id x19so16022905oix.3 for ; Sun, 13 Sep 2020 17:23:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VeoJfvdwA2FpsLhIg2kbHQF8yQZUevay/v5sgOZqYSk=; b=U1ar6Lz4LGAwm7nCzAvcav4trYv3CWZkG+jipI280ytcgC+vCKwtSESLT5y2JE5gpb x8BVJX6Cp/wbw8lfjZJdFiZ9a5vxDLUTMZF2NQo+te3oIiLU6YFpY+s5RUpEhDMpfn7l maLty8pLPy8Lovrl8ZE8qkmdB+QXtnHJD/s+TxSXPOiPfFIqdyrLmncOHyKDsjFN7s4g TDH9rFZJg1S7k6CzSQnpJLxAILMQbfH3QjPnF0pO0V/wneHG1y1t5Qyohi/dQBwlcloo NxEgo17b/vaQUqwASdwuMDSKA9jcQCV1maw7/B2AJZKEBgHn6QZlqgrFRe/aBK4o9dvN MgzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VeoJfvdwA2FpsLhIg2kbHQF8yQZUevay/v5sgOZqYSk=; b=HOvXUPi229r4Uok5GQxWM5EGo7yVwf8Kd3NE9UBkkH6agQdL6AHJF4+j1aJiOsKBUn 5DIJ+4wfLA9zHKvt6Z0UNfmRrJqDdgyB7wkbnkDhT4veWTmXc6kj//xnw2FZGTEKsN2q p62p9J39dXRtJiC8Ovqj133qjYsQiXZlWnLIxbEFQPGA3qMoA4Ny4ASizzaKYQ0Xzkrq z+8qs0IW7+1/7l0j7cO0+LdNTv3V9wffH18k9fRCjToawE7wFnMP9kkTvrtC298xQXTJ 0ZvsqB1Azz8Y89rZsicL0XAcmCq/pD5BtpQyEYfEMAZX/SiOhiL0zdUAW//QAeI7SnZg 3ULQ== X-Gm-Message-State: AOAM533OZZcQfByXAKTkKQ/XiLVuV89OloGG3IsswT2TVdznkjRVUJTY DSzGzEtCjp1Cb6qs/M5Lk9AnVg== X-Google-Smtp-Source: ABdhPJxPV3Dt3UoF44oem4KmCTZCEOKVRj0m0gypveUeWHdLsXDcQ0+GBOsTfjG1QdN9VJbqBoP3Aw== X-Received: by 2002:aca:4e84:: with SMTP id c126mr2252183oib.94.1600042998498; Sun, 13 Sep 2020 17:23:18 -0700 (PDT) Received: from yoga ([2605:6000:e5cb:c100:8898:14ff:fe6d:34e]) by smtp.gmail.com with ESMTPSA id h24sm2206301otj.33.2020.09.13.17.23.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2020 17:23:17 -0700 (PDT) Date: Sun, 13 Sep 2020 19:23:14 -0500 From: Bjorn Andersson To: Dmitry Baryshkov Cc: Andy Gross , Linus Walleij , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v2] pinctrl: qcom: sm8250: correct sdc2_clk and ngpios Message-ID: <20200914002314.GZ3715@yoga> References: <20200914001229.47290-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200914001229.47290-1-dmitry.baryshkov@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sun 13 Sep 19:12 CDT 2020, Dmitry Baryshkov wrote: > Correct sdc2_clk pin definition (register offset) and ngpios (SM8250 has > 180 GPIO pins). The second half of the message is no longer relevant, and you only need one of your s-o-b below. Regards, Bjorn > > Signed-off-by: Dmitry Baryshkov > Fixes: 4e3ec9e407ad5058003309072b37111f7b8c900a > Signed-off-by: Dmitry Baryshkov > --- > drivers/pinctrl/qcom/pinctrl-sm8250.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-sm8250.c b/drivers/pinctrl/qcom/pinctrl-sm8250.c > index a660f1274b66..826df0d637ea 100644 > --- a/drivers/pinctrl/qcom/pinctrl-sm8250.c > +++ b/drivers/pinctrl/qcom/pinctrl-sm8250.c > @@ -1308,7 +1308,7 @@ static const struct msm_pingroup sm8250_groups[] = { > [178] = PINGROUP(178, WEST, _, _, _, _, _, _, _, _, _), > [179] = PINGROUP(179, WEST, _, _, _, _, _, _, _, _, _), > [180] = UFS_RESET(ufs_reset, 0xb8000), > - [181] = SDC_PINGROUP(sdc2_clk, 0x7000, 14, 6), > + [181] = SDC_PINGROUP(sdc2_clk, 0xb7000, 14, 6), > [182] = SDC_PINGROUP(sdc2_cmd, 0xb7000, 11, 3), > [183] = SDC_PINGROUP(sdc2_data, 0xb7000, 9, 0), > }; > -- > 2.28.0 >