From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: hemantk@codeaurora.org, linux-arm-msm@vger.kernel.org,
bjorn.andersson@linaro.org, clew@codeaurora.org
Subject: Re: [PATCH v2 2/2] bus: mhi: Remove unused nr_irqs_req variable
Date: Mon, 21 Sep 2020 21:10:09 +0530 [thread overview]
Message-ID: <20200921154009.GI3262@Mani-XPS-13-9360> (raw)
In-Reply-To: <1600673819-1698-2-git-send-email-loic.poulain@linaro.org>
On Mon, Sep 21, 2020 at 09:36:59AM +0200, Loic Poulain wrote:
> nr_irqs_req is unused in MHI stack.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Applied to mhi-next!
Thanks,
Mani
> ---
> v2: add this patch to the series
>
> drivers/bus/mhi/core/init.c | 3 ---
> include/linux/mhi.h | 2 --
> 2 files changed, 5 deletions(-)
>
> diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
> index 31961af..8798deb 100644
> --- a/drivers/bus/mhi/core/init.c
> +++ b/drivers/bus/mhi/core/init.c
> @@ -643,9 +643,6 @@ static int parse_ev_cfg(struct mhi_controller *mhi_cntrl,
> mhi_event++;
> }
>
> - /* We need IRQ for each event ring + additional one for BHI */
> - mhi_cntrl->nr_irqs_req = mhi_cntrl->total_ev_rings + 1;
> -
> return 0;
>
> error_ev_cfg:
> diff --git a/include/linux/mhi.h b/include/linux/mhi.h
> index 742dabe..0d277c7 100644
> --- a/include/linux/mhi.h
> +++ b/include/linux/mhi.h
> @@ -309,7 +309,6 @@ struct mhi_controller_config {
> * @total_ev_rings: Total # of event rings allocated
> * @hw_ev_rings: Number of hardware event rings
> * @sw_ev_rings: Number of software event rings
> - * @nr_irqs_req: Number of IRQs required to operate (optional)
> * @nr_irqs: Number of IRQ allocated by bus master (required)
> * @family_number: MHI controller family number
> * @device_number: MHI controller device number
> @@ -389,7 +388,6 @@ struct mhi_controller {
> u32 total_ev_rings;
> u32 hw_ev_rings;
> u32 sw_ev_rings;
> - u32 nr_irqs_req;
> u32 nr_irqs;
> u32 family_number;
> u32 device_number;
> --
> 2.7.4
>
next prev parent reply other threads:[~2020-09-21 15:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 7:36 [PATCH v2 1/2] bus: mhi: core: Allow shared IRQ for event rings Loic Poulain
2020-09-21 7:36 ` [PATCH v2 2/2] bus: mhi: Remove unused nr_irqs_req variable Loic Poulain
2020-09-21 14:22 ` Manivannan Sadhasivam
2020-09-21 15:40 ` Manivannan Sadhasivam [this message]
2020-09-21 14:22 ` [PATCH v2 1/2] bus: mhi: core: Allow shared IRQ for event rings Manivannan Sadhasivam
2020-09-21 15:40 ` Manivannan Sadhasivam
2020-09-21 17:06 ` bbhatt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200921154009.GI3262@Mani-XPS-13-9360 \
--to=manivannan.sadhasivam@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=clew@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=loic.poulain@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox