From: Pavel Machek <pavel@ucw.cz>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Dan Murphy <dmurphy@ti.com>, Rob Herring <robh+dt@kernel.org>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/5] leds: qcom-lpg: add support for pm8150[bl] leds
Date: Thu, 29 Oct 2020 19:16:23 +0100 [thread overview]
Message-ID: <20201029181623.GF26053@duo.ucw.cz> (raw)
In-Reply-To: <20201021225100.162795-3-dmitry.baryshkov@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 989 bytes --]
Hi!
> Add support for the LPG/PWM block found on newer PMICs: PM8150B and
> PM8150A/L.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/leds/leds-qcom-lpg.c | 68 ++++++++++++++++++++++++++++++++----
> 1 file changed, 61 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/leds/leds-qcom-lpg.c b/drivers/leds/leds-qcom-lpg.c
> index 86131a65d2c5..4d24e0c973d6 100644
> --- a/drivers/leds/leds-qcom-lpg.c
> +++ b/drivers/leds/leds-qcom-lpg.c
> @@ -48,6 +48,8 @@ struct lpg_data;
> * @lut_bitmap: allocation bitmap for LUT entries
> * @triled_base: base address of the TRILED block (optional)
> * @triled_src: power-source for the TRILED
> + * @triled_no_atc_ctl: true if there is no TRI_LED_ATC_CTL register
> + * @triled_no_src_sel: true if there is no TRI_LED_SRC_SEL register
Please make logic the other way around. ... triled_has_atc_ctl.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2020-10-29 18:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 22:50 [PATCH 0/5] Qualcomm LPG support for PM8150b/l Dmitry Baryshkov
2020-10-21 22:50 ` [PATCH 1/5] dt-bindings: leds: leds-qcom-lpg: add pm8150[bl] compatible strings Dmitry Baryshkov
2020-10-23 16:28 ` Rob Herring
2020-10-21 22:50 ` [PATCH 2/5] leds: qcom-lpg: add support for pm8150[bl] leds Dmitry Baryshkov
2020-10-29 18:16 ` Pavel Machek [this message]
2020-10-21 22:50 ` [PATCH 3/5] arm64: dts: pm8150b: add Light Pulse Generator device node Dmitry Baryshkov
2020-10-21 22:50 ` [PATCH 4/5] arm64: dts: pm8150l: " Dmitry Baryshkov
2020-10-21 22:51 ` [PATCH 5/5] arm64: dts: qrb5165-rb5: declare tri-led user leds Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029181623.GF26053@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dmurphy@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox