From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Bhaumik Bhatt <bbhatt@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org,
jhugo@codeaurora.org, loic.poulain@linaro.org,
kvalo@codeaurora.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/6] bus: mhi: core: Remove __ prefix for MHI channel unprepare function
Date: Mon, 16 Nov 2020 18:17:06 +0530 [thread overview]
Message-ID: <20201116124706.GL3926@Mani-XPS-13-9360> (raw)
In-Reply-To: <1605122473-12179-6-git-send-email-bbhatt@codeaurora.org>
On Wed, Nov 11, 2020 at 11:21:12AM -0800, Bhaumik Bhatt wrote:
> The __mhi_unprepare_channel() API does not require the __ prefix.
> Get rid of it and make the internal function consistent with the
> other function names.
>
> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> drivers/bus/mhi/core/main.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c
> index e8af85a..19156d4 100644
> --- a/drivers/bus/mhi/core/main.c
> +++ b/drivers/bus/mhi/core/main.c
> @@ -1312,8 +1312,8 @@ static int mhi_update_channel_state(struct mhi_controller *mhi_cntrl,
> return -EINVAL;
> }
>
> -static void __mhi_unprepare_channel(struct mhi_controller *mhi_cntrl,
> - struct mhi_chan *mhi_chan)
> +static void mhi_unprepare_channel(struct mhi_controller *mhi_cntrl,
> + struct mhi_chan *mhi_chan)
> {
> int ret;
> struct device *dev = &mhi_cntrl->mhi_dev->dev;
> @@ -1433,7 +1433,7 @@ int mhi_prepare_channel(struct mhi_controller *mhi_cntrl,
>
> error_pre_alloc:
> mutex_unlock(&mhi_chan->mutex);
> - __mhi_unprepare_channel(mhi_cntrl, mhi_chan);
> + mhi_unprepare_channel(mhi_cntrl, mhi_chan);
>
> return ret;
> }
> @@ -1550,7 +1550,7 @@ int mhi_prepare_for_transfer(struct mhi_device *mhi_dev)
> if (!mhi_chan)
> continue;
>
> - __mhi_unprepare_channel(mhi_cntrl, mhi_chan);
> + mhi_unprepare_channel(mhi_cntrl, mhi_chan);
> }
>
> return ret;
> @@ -1568,7 +1568,7 @@ void mhi_unprepare_from_transfer(struct mhi_device *mhi_dev)
> if (!mhi_chan)
> continue;
>
> - __mhi_unprepare_channel(mhi_cntrl, mhi_chan);
> + mhi_unprepare_channel(mhi_cntrl, mhi_chan);
> }
> }
> EXPORT_SYMBOL_GPL(mhi_unprepare_from_transfer);
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
next prev parent reply other threads:[~2020-11-16 12:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 19:21 [PATCH v2 0/6] Updates to MHI channel handling Bhaumik Bhatt
2020-11-11 19:21 ` [PATCH v2 1/6] bus: mhi: core: Allow receiving a STOP channel command response Bhaumik Bhatt
2020-11-16 7:13 ` Manivannan Sadhasivam
2020-11-16 17:36 ` Bhaumik Bhatt
2020-11-21 17:16 ` Manivannan Sadhasivam
2020-11-24 0:23 ` Bhaumik Bhatt
2020-11-11 19:21 ` [PATCH v2 2/6] bus: mhi: core: Improvements to the channel handling state machine Bhaumik Bhatt
2020-11-16 10:22 ` Manivannan Sadhasivam
2020-11-11 19:21 ` [PATCH v2 3/6] bus: mhi: core: Add support to stop or start channel data transfers Bhaumik Bhatt
2020-11-16 12:43 ` Manivannan Sadhasivam
2020-11-16 20:56 ` Bhaumik Bhatt
2020-11-21 17:05 ` Manivannan Sadhasivam
2020-11-24 0:45 ` Bhaumik Bhatt
2020-11-11 19:21 ` [PATCH v2 4/6] bus: mhi: core: Check execution environment for channel before issuing reset Bhaumik Bhatt
2020-11-11 19:21 ` [PATCH v2 5/6] bus: mhi: core: Remove __ prefix for MHI channel unprepare function Bhaumik Bhatt
2020-11-16 12:47 ` Manivannan Sadhasivam [this message]
2020-11-11 19:21 ` [PATCH v2 6/6] bus: mhi: Improve documentation on channel transfer setup APIs Bhaumik Bhatt
2020-11-16 12:50 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116124706.GL3926@Mani-XPS-13-9360 \
--to=manivannan.sadhasivam@linaro.org \
--cc=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox