From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2308DC63697 for ; Mon, 23 Nov 2020 18:10:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B44412075A for ; Mon, 23 Nov 2020 18:10:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dBR+tZy0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726771AbgKWSKg (ORCPT ); Mon, 23 Nov 2020 13:10:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730167AbgKWSKf (ORCPT ); Mon, 23 Nov 2020 13:10:35 -0500 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5303C0613CF for ; Mon, 23 Nov 2020 10:10:33 -0800 (PST) Received: by mail-pg1-x541.google.com with SMTP id s63so5109336pgc.8 for ; Mon, 23 Nov 2020 10:10:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tRbLdzf7nLLz965yR1ha5WkHs6UoOY/QLZBKsNoJJPw=; b=dBR+tZy0iwKF0n70gHF7fsfCdf7eCjAXKFECem0f7+fzYnRqlcFKu2nna8sZxB5fqO HQmgb5dGJ1nYydgHUNJ+S60UjWo0s71gwQnUHGcVX3k7+EkDeHVXZxYAW0nun2eplQHZ SdU2ZBORtFe5tLv9EqdiEXNxhTLA1a8beMbo70cKjaGCgc+LEFyiwfPLNd6rQwKJCk50 lEaXAsOZYTaBJR8gnETNpLRrpRFoIKvTsdn4Dt4R8z13KzJWKK6c4ZW6HOP3zq0Td/rT 25sYuiDGRLJQC3CVHe5xXbCHebr19ml5FCvbwoZduMmu5UYzfIcrcpAv3wAGos7FbcEe OpRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tRbLdzf7nLLz965yR1ha5WkHs6UoOY/QLZBKsNoJJPw=; b=Ne5FSMA7ny8BH/N2+aqP10fsd65rPEusjCiB4eBUyHrm4shvEwrwtVi2DDCdIl2t2W BsQXdwJkC9krWQ09q7RvCyC52T0exA0KHN6QE+xd52WXqK3uoFF56y5n1CuKDy1+WqBA /buUkGKIytkgiCQtvpWQQYd2AznKyKmiopEKk8TA5dt8OKyT8RxmtpdF/wBYSv0kffGi 70ZDSnp56wTn2wRRF0mB3T7VmDypvO6XMR0cXAlSFYma0GOhkPXhDP7Sz2D46I//+v0Z zEERiBPKltxiEH/Q6yMZueYaCcfNHcOfkOSySvD6VMU9RKPOh1yDYMsTv1YjS6KRimkN CwvA== X-Gm-Message-State: AOAM531Ehmo+1PU7lmR840wCsumF+CKbt/Kg+L2PEhug65vxi6m1fCHp XBiVeu/fUCz8fLfEZgomBTTKzA== X-Google-Smtp-Source: ABdhPJym/gHWmBKhfNnY+QXBIt8h3XPbN2i4XuOzwwQ9PQi36roQV7CkKC0mi5sPARxPwudyuwUxEg== X-Received: by 2002:a62:1686:0:b029:197:5d15:2733 with SMTP id 128-20020a6216860000b02901975d152733mr582322pfw.81.1606155033298; Mon, 23 Nov 2020 10:10:33 -0800 (PST) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id b17sm12688815pfi.61.2020.11.23.10.10.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Nov 2020 10:10:32 -0800 (PST) Date: Mon, 23 Nov 2020 11:10:30 -0700 From: Mathieu Poirier To: Suzuki K Poulose Cc: Sai Prakash Ranjan , Mike Leach , coresight@lists.linaro.org, Stephen Boyd , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mao Jinlong , stable@vger.kernel.org Subject: Re: [PATCH] coresight: tmc-etr: Check if page is valid before dma_map_page() Message-ID: <20201123181030.GC104873@xps15> References: <20201123102133.18979-1-saiprakash.ranjan@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Nov 23, 2020 at 10:46:56AM +0000, Suzuki K Poulose wrote: > On 11/23/20 10:21 AM, Sai Prakash Ranjan wrote: > > From: Mao Jinlong > > > > alloc_pages_node() return should be checked before calling > > dma_map_page() to make sure that valid page is mapped or > > else it can lead to aborts as below: > > > > Unable to handle kernel paging request at virtual address ffffffc008000000 > > Mem abort info: > > ... > > pc : __dma_inv_area+0x40/0x58 > > lr : dma_direct_map_page+0xd8/0x1c8 > > > > Call trace: > > __dma_inv_area > > tmc_pages_alloc > > tmc_alloc_data_pages > > tmc_alloc_sg_table > > tmc_init_etr_sg_table > > tmc_alloc_etr_buf > > tmc_enable_etr_sink_sysfs > > tmc_enable_etr_sink > > coresight_enable_path > > coresight_enable > > enable_source_store > > dev_attr_store > > sysfs_kf_write > > > > Fixes: 99443ea19e8b ("coresight: Add generic TMC sg table framework") > > Cc: stable@vger.kernel.org > > Signed-off-by: Mao Jinlong > > Signed-off-by: Sai Prakash Ranjan > > Reviewed-by: Suzuki K Poulose > Applied - thanks Mathieu > > --- > > drivers/hwtracing/coresight/coresight-tmc-etr.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c > > index 525f0ecc129c..a31a4d7ae25e 100644 > > --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c > > +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c > > @@ -217,6 +217,8 @@ static int tmc_pages_alloc(struct tmc_pages *tmc_pages, > > } else { > > page = alloc_pages_node(node, > > GFP_KERNEL | __GFP_ZERO, 0); > > + if (!page) > > + goto err; > > } > > paddr = dma_map_page(real_dev, page, 0, PAGE_SIZE, dir); > > if (dma_mapping_error(real_dev, paddr)) > > > > base-commit: c04e5d7bbf6f92a346d6b36770705e7f034df42d > > >