From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A0FAC64E75 for ; Tue, 24 Nov 2020 04:51:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9963720BED for ; Tue, 24 Nov 2020 04:51:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UpR50yOk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726371AbgKXEvP (ORCPT ); Mon, 23 Nov 2020 23:51:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725797AbgKXEvP (ORCPT ); Mon, 23 Nov 2020 23:51:15 -0500 Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9475FC0613D6 for ; Mon, 23 Nov 2020 20:51:13 -0800 (PST) Received: by mail-ot1-x342.google.com with SMTP id 11so5656500oty.9 for ; Mon, 23 Nov 2020 20:51:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IaPCaFCHuJQneePrqd68vBnsJF+MzsPrh4FvA+iHfzE=; b=UpR50yOkEvNdKtEe2bzhgb4x84Cye79O1Rm1mO8+oJTdzz2XfFE2isfCJ+YRTV8U8H L8PthdNJl+O1zDL68k06P0DmWk3xIt+5/YMjnL7pUlEIoiUeRLX1eiQK11qxqXbx28/a OdW+4Zuq2hs70u0dgtxBdY6j5CtbDQfms2eyYV1iIP9eMBF3f6iZaZMmnsookYiXAvBa SqJIiokjpkIc/l+gz2XVzK2NjH/iqpawKqHc7eGfv4JQ4MiLHA9m9DAISAgNwaxoOub7 VYyB0nlSfdmwTUcN01brAtYe2HY/Wce3mutxjn3KmYxgOQnzAvFnm2Y+8zZRRUm6TdD0 ZvTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IaPCaFCHuJQneePrqd68vBnsJF+MzsPrh4FvA+iHfzE=; b=k6Bi/S3sV5zrZodIHQMV71QHEzwRLK3dORYLYJaTxgWctG7psCJgmH+8aKmtGWM5WA A9wWfpIbZSeVqdUEBzBtN64044vH2YqSn2PqCUb2c9ggkCDqt2Tw5Z3sAp6WJPzfkXme R8KVczhL8iOwo10KtPezq2Nu9Q3+lcMxTkq2785nCU5hWVEHqPqg3oVqJlXeq7cUQbCG +yd9ghoFNVfFqYKJlyp46UhRQfmkgPhu6wDi8qbmPDMjH4kQeOAaVKRehFuz6i5myyx/ hMVhZk3oqFwbr89NbuZ4bIEXbwu7wokgi16D6ul/X/DfzfIJAslEoIJUMDtwc2eebDq7 IgLg== X-Gm-Message-State: AOAM531o6TSpDZKbiY/2l/2C3fNSVIgQ6o10Z1sJ+gP+vKLYiLGz9RKs hfr3LpABTJocVqDKqpXtGYiWnZ86xIE/ow== X-Google-Smtp-Source: ABdhPJyMRIgFMVWRa72QLRCoypAvMPvF/ocxU/Mr/PZmNprFTp5JuOmTLGZWikWWLAMT7evse/AAcA== X-Received: by 2002:a9d:261:: with SMTP id 88mr2045432otb.202.1606193472833; Mon, 23 Nov 2020 20:51:12 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id w6sm7845466otj.12.2020.11.23.20.51.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Nov 2020 20:51:12 -0800 (PST) Date: Mon, 23 Nov 2020 22:51:10 -0600 From: Bjorn Andersson To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, kernel test robot , linux-pm@vger.kernel.org, Andy Gross , linux-arm-msm@vger.kernel.org, "Rafael J. Wysocki" , Daniel Lezcano , Stephan Gerhold , Lina Iyer , Ulf Hansson Subject: Re: [PATCH] cpuidle: arm: qcom: fix Kconfig problems Message-ID: <20201124045110.GH95182@builder.lan> References: <20201124013053.11502-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201124013053.11502-1-rdunlap@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon 23 Nov 19:30 CST 2020, Randy Dunlap wrote: > The Kconfig symbol ARM_QCOM_SPM_CPUIDLE wildly selects other > Kconfig symbols when it should not. > This causes kconfig warnings and subsequent build errors, > as listed below, so modify this symbol's Kconfig entry to > constrain and tame it. > > WARNING: unmet direct dependencies detected for QCOM_SCM > Depends on [n]: ARM [=y] && HAVE_ARM_SMCCC [=n] || ARM64 > Selected by [y]: > - ARM_QCOM_SPM_CPUIDLE [=y] && CPU_IDLE [=y] && (ARM [=y] || ARM64) && (ARCH_QCOM [=n] || COMPILE_TEST [=y]) && !ARM64 > > WARNING: unmet direct dependencies detected for ARM_CPU_SUSPEND > Depends on [n]: ARCH_SUSPEND_POSSIBLE [=n] > Selected by [y]: > - ARM_QCOM_SPM_CPUIDLE [=y] && CPU_IDLE [=y] && (ARM [=y] || ARM64) && (ARCH_QCOM [=n] || COMPILE_TEST [=y]) && !ARM64 > > and > > arm-linux-gnueabi-ld: arch/arm/kernel/sleep.o: in function `__cpu_suspend': > (.text+0x68): undefined reference to `cpu_sa110_suspend_size' > arm-linux-gnueabi-ld: arch/arm/kernel/suspend.o: in function `__cpu_suspend_save': > suspend.c:(.text+0x138): undefined reference to `cpu_sa110_do_suspend' > arm-linux-gnueabi-ld: suspend.c:(.text+0x170): undefined reference to `cpu_sa110_do_resume' > arm-linux-gnueabi-ld: drivers/firmware/qcom_scm-smc.o: in function `__scm_smc_do_quirk': > qcom_scm-smc.c:(.text+0x54): undefined reference to `__arm_smccc_smc' > arm-linux-gnueabi-ld: drivers/firmware/qcom_scm-legacy.o: in function `scm_legacy_call': > qcom_scm-legacy.c:(.text+0x168): undefined reference to `__arm_smccc_smc' > arm-linux-gnueabi-ld: drivers/firmware/qcom_scm-legacy.o: in function `scm_legacy_call_atomic': > qcom_scm-legacy.c:(.text+0x2e0): undefined reference to `__arm_smccc_smc' > > Fixes: a871be6b8eee ("cpuidle: Convert Qualcomm SPM driver to a generic CPUidle driver") > Signed-off-by: Randy Dunlap > Reported-by: kernel test robot > Cc: linux-pm@vger.kernel.org > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: linux-arm-msm@vger.kernel.org > Cc: "Rafael J. Wysocki" > Cc: Daniel Lezcano > Cc: Stephan Gerhold > Cc: Lina Iyer > Cc: Ulf Hansson > Cc: Bjorn Andersson > --- > drivers/cpuidle/Kconfig.arm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > --- linux-next-20201123.orig/drivers/cpuidle/Kconfig.arm > +++ linux-next-20201123/drivers/cpuidle/Kconfig.arm > @@ -108,10 +108,11 @@ config ARM_TEGRA_CPUIDLE > config ARM_QCOM_SPM_CPUIDLE > bool "CPU Idle Driver for Qualcomm Subsystem Power Manager (SPM)" > depends on (ARCH_QCOM || COMPILE_TEST) && !ARM64 > + depends on PM > select ARM_CPU_SUSPEND > select CPU_IDLE_MULTIPLE_DRIVERS > select DT_IDLE_STATES > - select QCOM_SCM > + select QCOM_SCM if HAVE_ARM_SMCCC I presume the trigger for this error is that 'd0511b5496c0 ("firmware: QCOM_SCM: Allow qcom_scm driver to be loadable as a permenent module")' made QCOM_SCM user selectable and described the dependency on HAVE_ARM_SMCCC.. So given that, and the fact that this driver doesn't do anything without QCOM_SCM, can we instead make it "depends on QCOM_SCM"? I believe it would inherit the dependency of HAVE_ARM_SMCCC in this case? Regards, Bjorn > help > Select this to enable cpuidle for Qualcomm processors. > The Subsystem Power Manager (SPM) controls low power modes for the