From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8B77C63777 for ; Tue, 24 Nov 2020 04:52:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F1B220872 for ; Tue, 24 Nov 2020 04:52:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="n0+dYK2x" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726955AbgKXEwA (ORCPT ); Mon, 23 Nov 2020 23:52:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726932AbgKXEwA (ORCPT ); Mon, 23 Nov 2020 23:52:00 -0500 Received: from mail-oi1-x243.google.com (mail-oi1-x243.google.com [IPv6:2607:f8b0:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1254CC0613CF for ; Mon, 23 Nov 2020 20:52:00 -0800 (PST) Received: by mail-oi1-x243.google.com with SMTP id o25so22435849oie.5 for ; Mon, 23 Nov 2020 20:52:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=21wh1RXrzLauQp1Zzrr3Pjj6ApJ/n51jC9LfHbkaKmY=; b=n0+dYK2xtpTlFNg42XEHZZzZwOGGufij+bDtWnHViKF9yePzEKzPJrA1FFYEgwpPa5 oY1mB2mJngVy8JAvPrGAdkOOGYIWf0IpD+2BuGlz0nHYpDCJw0xT4yI3kVWay0HCieuC Vi9+iI8TdGRY5o38rbNJsazX19zg4M4jH3+T4W4R/W3YRkHzEEEsArM2jb+1+7fKPaGs iJR0NbItXQCxSoNLYm6SpOQWjRdb/T8PF0uJ7rvRD4Oeq9c6fiEQ01XrEOOV6F6jSGPl YZEYxcgFqWpX+ran3veNjljAXBwO8jST/RrbsAHvIxoU+eHd30V5Rohtq2FErIWTq1xV 88EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=21wh1RXrzLauQp1Zzrr3Pjj6ApJ/n51jC9LfHbkaKmY=; b=Tl+wbg6qIJ3BkTmOgMlKGfMSJwPyv8vwasqxmPe6AH0YsMgZKrqTmdHClNHIn8vFD+ ms+atRj5NQPa8Jg7KKsSMV7mQoMkAgQko4Jx9eNPY4kAG2kepvPDl3MJfMQqktSHPX8y JboK0td8f6GutPfVCqE8luzR/TwtMDsv8BJPa90+m4MI8rbI8Tykt9CzJLoKLzynTxkI iMpvC2iayw0w3KXGW1VdR0ASiIRRnl3W/Dqhaqo+PEzKGN3jTx316x5RVjDkywB7sx7z ccfYJpnPx8QSL2eJ1gQhGaJ7r6Anjf7S7bjQhq2W7Agm/VM6FSzmDWxs5FCEyTAIl241 22kA== X-Gm-Message-State: AOAM532ay5z8pLlFhFDfeVM4eb2KBojutYz9g8Fk3At0iDZ4yKfea6Wp q7rrkg9jrEjP2iE5m8d6CwV4cw== X-Google-Smtp-Source: ABdhPJxx8PNpFgul9bJq4f9P39PTOZ4UQOaHXVAQ3uMenmz0FcS/8UhRicJEaacMk+6aPMiKDvqJRg== X-Received: by 2002:aca:f5c8:: with SMTP id t191mr1678894oih.40.1606193519483; Mon, 23 Nov 2020 20:51:59 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id z77sm8670400ooa.37.2020.11.23.20.51.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Nov 2020 20:51:58 -0800 (PST) Date: Mon, 23 Nov 2020 22:51:56 -0600 From: Bjorn Andersson To: John Stultz Cc: lkml , Todd Kjos , Saravana Kannan , Andy Gross , Rajendra Nayak , Maulik Shah , Stephen Boyd , Liam Girdwood , Mark Brown , linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2] regulator: Kconfig: Fix REGULATOR_QCOM_RPMH dependencies to avoid build error Message-ID: <20201124045156.GI95182@builder.lan> References: <20201123222359.103822-1-john.stultz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201123222359.103822-1-john.stultz@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon 23 Nov 16:23 CST 2020, John Stultz wrote: > The kernel test robot reported the following build error: > > All errors (new ones prefixed by >>): > > xtensa-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_vrm_get_voltage_sel': > qcom-rpmh-regulator.c:(.text+0x270): undefined reference to `rpmh_write' > xtensa-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_send_request': > qcom-rpmh-regulator.c:(.text+0x2f2): undefined reference to `rpmh_write' > xtensa-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_vrm_get_voltage_sel': > >> qcom-rpmh-regulator.c:(.text+0x274): undefined reference to `rpmh_write_async' > xtensa-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_send_request': > qcom-rpmh-regulator.c:(.text+0x2fc): undefined reference to `rpmh_write_async' > > Which is due to REGULATOR_QCOM_RPMH depending on > QCOM_RPMH || COMPILE_TEST. The problem is that QOM_RPMH can now > be a module, which in that case requires REGULATOR_QCOM_RPMH=m > to build. > > However, if COMPILE_TEST is enabled, REGULATOR_QCOM_RPMH can be > set to =y while QCOM_RPMH=m which will cause build failures. > > The fix here is to add (QCOM_RPMH=n && COMPILE_TEST) to the > dependency. > > Feedback would be appreciated! Reviewed-by: Bjorn Andersson Regards, Bjorn > > Cc: Todd Kjos > Cc: Saravana Kannan > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: Rajendra Nayak > Cc: Maulik Shah > Cc: Stephen Boyd > Cc: Liam Girdwood > Cc: Mark Brown > Cc: linux-arm-msm@vger.kernel.org > Reported-by: kernel test robot > Signed-off-by: John Stultz > --- > v2: Switch dependency logic as suggested by MarkB > --- > drivers/regulator/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig > index 020a00d6696b..481c7b10133b 100644 > --- a/drivers/regulator/Kconfig > +++ b/drivers/regulator/Kconfig > @@ -843,7 +843,7 @@ config REGULATOR_QCOM_RPM > > config REGULATOR_QCOM_RPMH > tristate "Qualcomm Technologies, Inc. RPMh regulator driver" > - depends on QCOM_RPMH || COMPILE_TEST > + depends on QCOM_RPMH || (QCOM_RPMH=n && COMPILE_TEST) > help > This driver supports control of PMIC regulators via the RPMh hardware > block found on Qualcomm Technologies Inc. SoCs. RPMh regulator > -- > 2.17.1 >