[PATCH 00/40] [Set 10] Rid W=1 warnings from GPU

[PATCH 00/40] [Set 10] Rid W=1 warnings from GPU

[Lee Jones]

This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.

500 out of 5000 left!

Lee Jones (40):
  drm/amd/pm/powerplay/smumgr/tonga_smumgr: Remove set but unused
    variable 'res'
  drm/amd/pm/powerplay/smumgr/polaris10_smumgr: Make function called by
    reference static
  drm/amd/pm/powerplay/smumgr/ci_smumgr: Remove set but unused variable
    'res'
  drm/amd/pm/powerplay/smumgr/iceland_smumgr: Make function called by
    reference static
  drm/amd/pm/powerplay/smumgr/vegam_smumgr: Make function called by
    reference static
  drm/amd/pm/powerplay/smumgr/smu9_smumgr: Include our own header
    containing our prototypes
  drm/amd/pm/powerplay/smumgr/fiji_smumgr: Demote kernel-doc format
    abuse
  drm/amd/pm/powerplay/hwmgr/hardwaremanager: Remove unused
    'phm_set_*()' functions
  drm/amd/pm/powerplay/hwmgr/hwmgr: Move 'smu8_init_function_pointers()'
    prototype to shared header
  drm/amd/pm/inc/pp_thermal: Mark 'SMU7Thermal{WithDelay}Policy' as
    __maybe_unused
  drm/amd/pm/powerplay/hwmgr/ppevvmath: Place variable declaration under
    same clause as its use
  drm/amd/pm/powerplay/hwmgr/ppatomctrl: Remove unused variable
    'fPowerDPMx'
  drm/amd/pm/powerplay/hwmgr/hwmgr: Move
    'smu7_init_function_pointers()'s prototype to header
  drm/amd/pm/powerplay/hwmgr/ppatomfwctrl: Demote kernel-doc formatting
    abuses
  drm/msm/disp/dpu1/dpu_hw_interrupts: Demote kernel-doc formatting
    misuse
  drm/amd/pm/powerplay/smumgr/iceland_smumgr: Remove unused variable
    'res'
  drm/amd/pm/powerplay/hwmgr/hardwaremanager: Fix function header
    related formatting issues
  drm/amd/pm/powerplay/hwmgr/process_pptables_v1_0: Convert to proper
    kernel-doc format
  drm/amd/pm/powerplay/hwmgr/ppatomctrl: Fix a myriad of kernel-doc
    issues
  drm/amd/pm/powerplay/hwmgr/vega10_processpptables: Make function
    invoked by reference static
  drm/amd/pm/powerplay/hwmgr/smu7_hwmgr: Fix a whole bunch of historical
    function doc issues
  drm/amd/pm/powerplay/hwmgr/vega10_hwmgr: Remove set but unused
    variable 'result'
  drm/amd/pm/powerplay/hwmgr/smu7_thermal: Repair formatting in a bunch
    of function docs
  drm/amd/pm/powerplay/hwmgr/vega10_thermal: Fix a bunch of dated
    function doc formatting
  drm/amd/pm/powerplay/hwmgr/pp_psm: Remove unused variable 'result'
  drm/amd/pm/powerplay/hwmgr/hwmgr: Move 'vega12_hwmgr_init()'s
    prototype to shared header
  drm/amd/pm/powerplay/hwmgr/hwmgr: Move 'vega20_hwmgr_init()'s
    prototype to shared header
  drm/amd/pm/powerplay/hwmgr/smu_helper: Demote or fix kernel-doc
    headers
  drm/amd/pm/powerplay/hwmgr/vega20_thermal: Fix some outdated function
    documentation
  drm/amd/pm/powerplay/hwmgr/vega12_thermal: Fix some outdated function
    documentation
  drm/amd/pm/powerplay/kv_dpm: Remove unused variable 'ret'
  drm/amd/display/amdgpu_dm/amdgpu_dm: Mark 'link_bandwidth_kbps' as
    __maybe_unused
  drm/amd/display/dc/inc/hw/dpp: Mark 'dpp_input_csc_matrix' as
    __maybe_unused
  drm/amd/display/amdgpu_dm/amdgpu_dm_helpers: Use 'gnu_printf' format
    notation
  drm/amd/display/amdgpu_dm/amdgpu_dm_color: Demote a misuse and fix
    another kernel-doc header
  drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu: Mark local functions
    invoked by reference as static
  drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu: Remove unused function
    'pp_nv_set_pme_wa_enable()'
  drm/amd/display/dc/basics/conversion: Include header containing our
    prototypes
  drm/amd/display/dc/basics/fixpt31_32: Remove unused variable
    'dc_fixpt_pi'
  drm/amd/display/dc/basics/vector: Make local function
    'dal_vector_presized_costruct' static

 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |   2 +-
 .../amd/display/amdgpu_dm/amdgpu_dm_color.c   |   4 +-
 .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c |   1 +
 .../amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c  |  28 +--
 .../drm/amd/display/dc/basics/conversion.c    |   1 +
 .../drm/amd/display/dc/basics/fixpt31_32.c    |   1 -
 .../gpu/drm/amd/display/dc/basics/vector.c    |   2 +-
 drivers/gpu/drm/amd/display/dc/inc/hw/dpp.h   |   2 +-
 drivers/gpu/drm/amd/pm/inc/hwmgr.h            |   4 +
 drivers/gpu/drm/amd/pm/inc/pp_thermal.h       |   4 +-
 .../amd/pm/powerplay/hwmgr/hardwaremanager.c  |  56 ++----
 .../gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c    |   4 -
 .../gpu/drm/amd/pm/powerplay/hwmgr/pp_psm.c   |   3 +-
 .../drm/amd/pm/powerplay/hwmgr/ppatomctrl.c   |  84 +++++----
 .../drm/amd/pm/powerplay/hwmgr/ppatomfwctrl.c |  24 +--
 .../drm/amd/pm/powerplay/hwmgr/ppevvmath.h    |   6 +-
 .../powerplay/hwmgr/process_pptables_v1_0.c   |  81 ++++-----
 .../drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c   | 166 +++++++++---------
 .../drm/amd/pm/powerplay/hwmgr/smu7_thermal.c | 103 ++++++-----
 .../drm/amd/pm/powerplay/hwmgr/smu_helper.c   |   8 +-
 .../drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c |   3 +-
 .../powerplay/hwmgr/vega10_processpptables.c  |   2 +-
 .../amd/pm/powerplay/hwmgr/vega10_thermal.c   | 131 +++++++-------
 .../amd/pm/powerplay/hwmgr/vega12_thermal.c   |  82 ++++-----
 .../amd/pm/powerplay/hwmgr/vega20_thermal.c   |  54 +++---
 drivers/gpu/drm/amd/pm/powerplay/kv_dpm.c     |  18 +-
 .../drm/amd/pm/powerplay/smumgr/ci_smumgr.c   |   3 +-
 .../drm/amd/pm/powerplay/smumgr/fiji_smumgr.c |   2 +-
 .../amd/pm/powerplay/smumgr/iceland_smumgr.c  |   5 +-
 .../pm/powerplay/smumgr/polaris10_smumgr.c    |   2 +-
 .../drm/amd/pm/powerplay/smumgr/smu9_smumgr.c |   1 +
 .../amd/pm/powerplay/smumgr/tonga_smumgr.c    |   9 +-
 .../amd/pm/powerplay/smumgr/vegam_smumgr.c    |   2 +-
 .../gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c |   4 +-
 34 files changed, 409 insertions(+), 493 deletions(-)

Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
Cc: Evan Quan <evan.quan@amd.com>
Cc: freedreno@lists.freedesktop.org
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Huang Rui <ray.huang@amd.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Leo Li <sunpeng.li@amd.com>
Cc: linux-arm-msm@vger.kernel.org
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: Shubhashree Dhar <dhar@codeaurora.org>
-- 
2.25.1

[PATCH 15/40] drm/msm/disp/dpu1/dpu_hw_interrupts: Demote kernel-doc formatting misuse

[Lee Jones]

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:246: error: Cannot parse struct or union!
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:756: error: Cannot parse struct or union!

Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Shubhashree Dhar <dhar@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
index 38482b1047745..5c521de715670 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
@@ -189,7 +189,7 @@ struct dpu_irq_type {
 	u32 reg_idx;
 };
 
-/**
+/*
  * struct dpu_intr_reg -  List of DPU interrupt registers
  */
 static const struct dpu_intr_reg dpu_intr_set[] = {
@@ -245,7 +245,7 @@ static const struct dpu_intr_reg dpu_intr_set[] = {
 	}
 };
 
-/**
+/*
  * struct dpu_irq_type - IRQ mapping table use for lookup an irq_idx in this
  *			 table that have a matching interface type and
  *			 instance index.
-- 
2.25.1

Re: [PATCH 15/40] drm/msm/disp/dpu1/dpu_hw_interrupts: Demote kernel-doc formatting misuse

[abhinavk]

On 2020-11-26 05:42, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:246: error: Cannot
> parse struct or union!
>  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:756: error: Cannot
> parse struct or union!
> 
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Shubhashree Dhar <dhar@codeaurora.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedreno@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> index 38482b1047745..5c521de715670 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> @@ -189,7 +189,7 @@ struct dpu_irq_type {
>  	u32 reg_idx;
>  };
> 
> -/**
> +/*
>   * struct dpu_intr_reg -  List of DPU interrupt registers
>   */
>  static const struct dpu_intr_reg dpu_intr_set[] = {
> @@ -245,7 +245,7 @@ static const struct dpu_intr_reg dpu_intr_set[] = {
>  	}
>  };
> 
> -/**
> +/*
>   * struct dpu_irq_type - IRQ mapping table use for lookup an irq_idx 
> in this
>   *			 table that have a matching interface type and
>   *			 instance index.