Re: [PATCH 6/9] ARM: dts: qcom-pma8084: Drop incorrect use of io-channel-ranges

Re: [PATCH 6/9] ARM: dts: qcom-pma8084: Drop incorrect use of io-channel-ranges

[Jonathan Cameron]

On Sun, 15 Nov 2020 19:29:48 +0000
Jonathan Cameron <jic23@kernel.org> wrote:

> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> This property is used by io-channel consumers, not providers so should
> not present here.  Note dt_schema will now detect this error as there
> is a dependency between this property and io-channels.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Andy Gross <andy.gross@linaro.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
+CC Andy on an up to date email. Also added linux-arm-msm
which I should have cc'd in the first place.

I've taken the yaml fix related to this so just a question of
cleaning up this loose end in the dtsi

Thanks,

Jonathan

> ---
>  arch/arm/boot/dts/qcom-pma8084.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-pma8084.dtsi b/arch/arm/boot/dts/qcom-pma8084.dtsi
> index ea1ca166165c..e921c5e93a5d 100644
> --- a/arch/arm/boot/dts/qcom-pma8084.dtsi
> +++ b/arch/arm/boot/dts/qcom-pma8084.dtsi
> @@ -68,7 +68,6 @@ pma8084_vadc: vadc@3100 {
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  			#io-channel-cells = <1>;
> -			io-channel-ranges;
>  
>  			die_temp {
>  				reg = <VADC_DIE_TEMP>;

Re: [PATCH 6/9] ARM: dts: qcom-pma8084: Drop incorrect use of io-channel-ranges

[Bjorn Andersson]

On Sat 28 Nov 09:37 CST 2020, Jonathan Cameron wrote:

> On Sun, 15 Nov 2020 19:29:48 +0000
> Jonathan Cameron <jic23@kernel.org> wrote:
> 
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > This property is used by io-channel consumers, not providers so should
> > not present here.  Note dt_schema will now detect this error as there
> > is a dependency between this property and io-channels.
> > 
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Andy Gross <andy.gross@linaro.org>
> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> +CC Andy on an up to date email. Also added linux-arm-msm
> which I should have cc'd in the first place.
> 
> I've taken the yaml fix related to this so just a question of
> cleaning up this loose end in the dtsi
> 

Thanks Jonathan, I missed your patches earlier. The yaml change looks
correct and I've merged this for 5.11.

Regards,
Bjorn

> Thanks,
> 
> Jonathan
> 
> > ---
> >  arch/arm/boot/dts/qcom-pma8084.dtsi | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/qcom-pma8084.dtsi b/arch/arm/boot/dts/qcom-pma8084.dtsi
> > index ea1ca166165c..e921c5e93a5d 100644
> > --- a/arch/arm/boot/dts/qcom-pma8084.dtsi
> > +++ b/arch/arm/boot/dts/qcom-pma8084.dtsi
> > @@ -68,7 +68,6 @@ pma8084_vadc: vadc@3100 {
> >  			#address-cells = <1>;
> >  			#size-cells = <0>;
> >  			#io-channel-cells = <1>;
> > -			io-channel-ranges;
> >  
> >  			die_temp {
> >  				reg = <VADC_DIE_TEMP>;
> 

Re: [PATCH 6/9] ARM: dts: qcom-pma8084: Drop incorrect use of io-channel-ranges

[Jonathan Cameron]

On Sat, 28 Nov 2020 12:30:10 -0600
Bjorn Andersson <bjorn.andersson@linaro.org> wrote:

> On Sat 28 Nov 09:37 CST 2020, Jonathan Cameron wrote:
> 
> > On Sun, 15 Nov 2020 19:29:48 +0000
> > Jonathan Cameron <jic23@kernel.org> wrote:
> >   
> > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > > 
> > > This property is used by io-channel consumers, not providers so should
> > > not present here.  Note dt_schema will now detect this error as there
> > > is a dependency between this property and io-channels.
> > > 
> > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > > Cc: Andy Gross <andy.gross@linaro.org>
> > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org>  
> > +CC Andy on an up to date email. Also added linux-arm-msm
> > which I should have cc'd in the first place.
> > 
> > I've taken the yaml fix related to this so just a question of
> > cleaning up this loose end in the dtsi
> >   
> 
> Thanks Jonathan, I missed your patches earlier. The yaml change looks
> correct and I've merged this for 5.11.

No problem. I've added your tag to the yaml change.

Thanks,

Jonathan


> 
> Regards,
> Bjorn
> 
> > Thanks,
> > 
> > Jonathan
> >   
> > > ---
> > >  arch/arm/boot/dts/qcom-pma8084.dtsi | 1 -
> > >  1 file changed, 1 deletion(-)
> > > 
> > > diff --git a/arch/arm/boot/dts/qcom-pma8084.dtsi b/arch/arm/boot/dts/qcom-pma8084.dtsi
> > > index ea1ca166165c..e921c5e93a5d 100644
> > > --- a/arch/arm/boot/dts/qcom-pma8084.dtsi
> > > +++ b/arch/arm/boot/dts/qcom-pma8084.dtsi
> > > @@ -68,7 +68,6 @@ pma8084_vadc: vadc@3100 {
> > >  			#address-cells = <1>;
> > >  			#size-cells = <0>;
> > >  			#io-channel-cells = <1>;
> > > -			io-channel-ranges;
> > >  
> > >  			die_temp {
> > >  				reg = <VADC_DIE_TEMP>;  
> >