* [PATCH v5 1/2] dt-bindings: pci: qcom: Document ddrss_sf_tbu clock for sm8250
@ 2021-01-17 1:30 Dmitry Baryshkov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Baryshkov @ 2021-01-17 1:30 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Lorenzo Pieralisi
Cc: linux-arm-msm, Manivannan Sadhasivam, linux-pci
On SM8250 additional clock is required for PCIe devices to access NOC.
Document this requirement in devicetree bindings.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Fixes: 458168247ccc ("dt-bindings: pci: qcom: Document PCIe bindings for SM8250 SoC")
---
.../devicetree/bindings/pci/qcom,pcie.txt | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.txt b/Documentation/devicetree/bindings/pci/qcom,pcie.txt
index 3b55310390a0..0da458a051b6 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie.txt
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie.txt
@@ -132,8 +132,20 @@
- "master_bus" AXI Master clock
- "slave_bus" AXI Slave clock
--clock-names:
- Usage: required for sdm845 and sm8250
+- clock-names:
+ Usage: required for sdm845
+ Value type: <stringlist>
+ Definition: Should contain the following entries
+ - "aux" Auxiliary clock
+ - "cfg" Configuration clock
+ - "bus_master" Master AXI clock
+ - "bus_slave" Slave AXI clock
+ - "slave_q2a" Slave Q2A clock
+ - "tbu" PCIe TBU clock
+ - "pipe" PIPE clock
+
+- clock-names:
+ Usage: required for sm8250
Value type: <stringlist>
Definition: Should contain the following entries
- "aux" Auxiliary clock
@@ -142,6 +154,7 @@
- "bus_slave" Slave AXI clock
- "slave_q2a" Slave Q2A clock
- "tbu" PCIe TBU clock
+ - "ddrss_sf_tbu" PCIe SF TBU clock
- "pipe" PIPE clock
- resets:
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH v5 0/2] PCI: qcom: fix PCIe support on sm8250
@ 2021-01-17 1:31 Dmitry Baryshkov
2021-01-17 1:31 ` [PATCH v5 1/2] dt-bindings: pci: qcom: Document ddrss_sf_tbu clock for sm8250 Dmitry Baryshkov
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Baryshkov @ 2021-01-17 1:31 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Lorenzo Pieralisi
Cc: linux-arm-msm, Manivannan Sadhasivam, linux-pci
SM8250 platform requires additional clock to be enabled for PCIe to
function. In case it is disabled, PCIe access will result in IOMMU
timeouts. Add device tree binding and driver support for this clock.
Canges since v4:
- Remove QCOM_PCIE_2_7_0_MAX_CLOCKS define and has_sf_tbu variable.
Changes since v3:
- Merge clock handling back into qcom_pcie_get_resources_2_7_0().
Define res->num_clks to the amount of clocks used for this particular
platform.
Changes since v2:
- Split this clock handling from qcom_pcie_get_resources_2_7_0()
- Change comment to point that the clock is required rather than
optional
Changes since v1:
- Added Fixes: tags, as respective patches have hit the upstream Linux
tree.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH v5 1/2] dt-bindings: pci: qcom: Document ddrss_sf_tbu clock for sm8250
2021-01-17 1:31 [PATCH v5 0/2] PCI: qcom: fix PCIe support on sm8250 Dmitry Baryshkov
@ 2021-01-17 1:31 ` Dmitry Baryshkov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Baryshkov @ 2021-01-17 1:31 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Lorenzo Pieralisi
Cc: linux-arm-msm, Manivannan Sadhasivam, linux-pci
On SM8250 additional clock is required for PCIe devices to access NOC.
Document this requirement in devicetree bindings.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Fixes: 458168247ccc ("dt-bindings: pci: qcom: Document PCIe bindings for SM8250 SoC")
---
.../devicetree/bindings/pci/qcom,pcie.txt | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.txt b/Documentation/devicetree/bindings/pci/qcom,pcie.txt
index 3b55310390a0..0da458a051b6 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie.txt
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie.txt
@@ -132,8 +132,20 @@
- "master_bus" AXI Master clock
- "slave_bus" AXI Slave clock
--clock-names:
- Usage: required for sdm845 and sm8250
+- clock-names:
+ Usage: required for sdm845
+ Value type: <stringlist>
+ Definition: Should contain the following entries
+ - "aux" Auxiliary clock
+ - "cfg" Configuration clock
+ - "bus_master" Master AXI clock
+ - "bus_slave" Slave AXI clock
+ - "slave_q2a" Slave Q2A clock
+ - "tbu" PCIe TBU clock
+ - "pipe" PIPE clock
+
+- clock-names:
+ Usage: required for sm8250
Value type: <stringlist>
Definition: Should contain the following entries
- "aux" Auxiliary clock
@@ -142,6 +154,7 @@
- "bus_slave" Slave AXI clock
- "slave_q2a" Slave Q2A clock
- "tbu" PCIe TBU clock
+ - "ddrss_sf_tbu" PCIe SF TBU clock
- "pipe" PIPE clock
- resets:
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-17 1:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-17 1:30 [PATCH v5 1/2] dt-bindings: pci: qcom: Document ddrss_sf_tbu clock for sm8250 Dmitry Baryshkov
-- strict thread matches above, loose matches on Subject: below --
2021-01-17 1:31 [PATCH v5 0/2] PCI: qcom: fix PCIe support on sm8250 Dmitry Baryshkov
2021-01-17 1:31 ` [PATCH v5 1/2] dt-bindings: pci: qcom: Document ddrss_sf_tbu clock for sm8250 Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).