linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Bhaumik Bhatt <bbhatt@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org,
	jhugo@codeaurora.org, linux-kernel@vger.kernel.org,
	loic.poulain@linaro.org
Subject: Re: [PATCH v5 1/9] bus: mhi: core: Allow sending the STOP channel command
Date: Thu, 21 Jan 2021 16:55:15 +0530	[thread overview]
Message-ID: <20210121112515.GE30041@thinkpad> (raw)
In-Reply-To: <1610139297-36435-2-git-send-email-bbhatt@codeaurora.org>

On Fri, Jan 08, 2021 at 12:54:49PM -0800, Bhaumik Bhatt wrote:
> Add support to allow sending the STOP channel command. If a
> client driver would like to STOP a channel and have the device
> retain the channel context instead of issuing a RESET to it and
> clearing the context, this would provide support for it after
> the ability to send this command is exposed to clients.
> 
> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
> Reviewed-by: Hemant Kumar <hemantk@codeaurora.org>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks,
Mani

> ---
>  drivers/bus/mhi/core/main.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c
> index 8576b0f..c22d7df 100644
> --- a/drivers/bus/mhi/core/main.c
> +++ b/drivers/bus/mhi/core/main.c
> @@ -1224,6 +1224,11 @@ int mhi_send_cmd(struct mhi_controller *mhi_cntrl,
>  		cmd_tre->dword[0] = MHI_TRE_CMD_RESET_DWORD0;
>  		cmd_tre->dword[1] = MHI_TRE_CMD_RESET_DWORD1(chan);
>  		break;
> +	case MHI_CMD_STOP_CHAN:
> +		cmd_tre->ptr = MHI_TRE_CMD_STOP_PTR;
> +		cmd_tre->dword[0] = MHI_TRE_CMD_STOP_DWORD0;
> +		cmd_tre->dword[1] = MHI_TRE_CMD_STOP_DWORD1(chan);
> +		break;
>  	case MHI_CMD_START_CHAN:
>  		cmd_tre->ptr = MHI_TRE_CMD_START_PTR;
>  		cmd_tre->dword[0] = MHI_TRE_CMD_START_DWORD0;
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
> 

  reply	other threads:[~2021-01-21 11:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08 20:54 [PATCH v5 0/9] Updates to MHI channel handling Bhaumik Bhatt
2021-01-08 20:54 ` [PATCH v5 1/9] bus: mhi: core: Allow sending the STOP channel command Bhaumik Bhatt
2021-01-21 11:25   ` Manivannan Sadhasivam [this message]
2021-01-08 20:54 ` [PATCH v5 2/9] bus: mhi: core: Allow channel to be disabled from stopped state Bhaumik Bhatt
2021-01-21 11:35   ` Manivannan Sadhasivam
2021-01-08 20:54 ` [PATCH v5 3/9] bus: mhi: core: Improvements to the channel handling state machine Bhaumik Bhatt
2021-01-21 14:43   ` Manivannan Sadhasivam
2021-01-08 20:54 ` [PATCH v5 4/9] bus: mhi: core: Clear configuration from channel context during reset Bhaumik Bhatt
2021-01-21 14:47   ` Manivannan Sadhasivam
2021-01-08 20:54 ` [PATCH v5 5/9] bus: mhi: core: Add support to stop or start channel data transfers Bhaumik Bhatt
2021-01-21 14:50   ` Manivannan Sadhasivam
2021-02-04 20:25     ` Bhaumik Bhatt
2021-01-08 20:54 ` [PATCH v5 6/9] bus: mhi: core: Check channel execution environment before issuing reset Bhaumik Bhatt
2021-01-21 15:12   ` Manivannan Sadhasivam
2021-02-04 20:23     ` Bhaumik Bhatt
2021-01-08 20:54 ` [PATCH v5 7/9] bus: mhi: core: Remove __ prefix for MHI channel unprepare function Bhaumik Bhatt
2021-01-08 20:54 ` [PATCH v5 8/9] bus: mhi: Improve documentation on channel transfer setup APIs Bhaumik Bhatt
2021-01-08 20:54 ` [PATCH v5 9/9] bus: mhi: core: Do not clear channel context more than once Bhaumik Bhatt
2021-01-09  4:39   ` Hemant Kumar
2021-01-21 15:15   ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210121112515.GE30041@thinkpad \
    --to=manivannan.sadhasivam@linaro.org \
    --cc=bbhatt@codeaurora.org \
    --cc=hemantk@codeaurora.org \
    --cc=jhugo@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).