From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 443CEC433E0 for ; Tue, 26 Jan 2021 14:09:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 19A7E22B3B for ; Tue, 26 Jan 2021 14:09:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392686AbhAZOJv (ORCPT ); Tue, 26 Jan 2021 09:09:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405724AbhAZOH6 (ORCPT ); Tue, 26 Jan 2021 09:07:58 -0500 Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01518C061D73 for ; Tue, 26 Jan 2021 06:07:18 -0800 (PST) Received: by mail-ot1-x333.google.com with SMTP id h14so16249424otr.4 for ; Tue, 26 Jan 2021 06:07:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IQ1mHRGGkeAWSLltIAOirHSUgPq2D+lfO6NPdhx+kbk=; b=nSntSCMT12ixFL7rKiXDb9a3nofYWhAoNV9NbbrNNorP2Il6xg18+E1tcWTCFF57lu /usVi7gupanU3YRCGUUt0pcPFhrNj8wEyiStsNvbNzdR9rsr5s4BNsZTFO9dDilrjCjy /zupnJ0BN2W9ChCIvlDFwQLXMMFF4OzqJp5xVQr2CLj1UiD8l6Wr+JDPeKq+hwaop+it s55taU82Xy0f2keH7UcovRUXaBVkLPe0cuvmwEqse01tIbO+oOzyDMzM5/QXq/NsUvzz bkeopHtSBtqexnk875g3BhNPddL1FYKjKYg52C8dL4kZjzYVgcBNKdjl0+2Qq/yrRP+/ Yr4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IQ1mHRGGkeAWSLltIAOirHSUgPq2D+lfO6NPdhx+kbk=; b=UxE72yswfXYC2XpLkr5YSM1D9iJ+As9epcXeNtjl1bipOshtYMGDhsHXVDcmYKXWcP QDd/5jULEfS10cnoLUePwrsCe22n11ywxguyVUzjzYaNU3JqdnlbxEZoqxxPffvn1JNb yhZ2I5PhksgpabuZnMX25MoatDK1PICEDqnga051yjl/kF4ElVz5Nhar5JO+6fSPaBKR 5aXNWk+JIDiosahJuqA1DfE8lcnyFHYBZ+ygWl9IzJx8935sxig5H/m7XVfR+YhGFkLI J5egukAq1t/djBpfWGDr+Dj8bq6twR/jZ8UEz8uPG+4hxdmrPcQO4qIdPB6xUb6ocYq/ mMYA== X-Gm-Message-State: AOAM530gzryVlElsXZuYjAuf6Q5bQBeolwmKsQGXPcYWAZ29mPkc9NBC cx8AQkwce3b/VddGusdJacN9AQ== X-Google-Smtp-Source: ABdhPJy7AYp4AcoJFrfFGte6lqF9tUTZ+0VN9mh8hPlQxw314jX/VkvHT6IrGZ7qHf/E8GVyGkqE2w== X-Received: by 2002:a9d:66d1:: with SMTP id t17mr3986317otm.163.1611670037403; Tue, 26 Jan 2021 06:07:17 -0800 (PST) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id o16sm4103118ote.79.2021.01.26.06.07.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 06:07:16 -0800 (PST) Date: Tue, 26 Jan 2021 08:07:14 -0600 From: Bjorn Andersson To: Jiapeng Zhong Cc: agross@kernel.org, p.zabel@pengutronix.de, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: firmware: qcom_scm: Simplify the calculation of variables Message-ID: <20210126140714.GG1241218@yoga> References: <1611651144-42491-1-git-send-email-abaci-bugfix@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1611651144-42491-1-git-send-email-abaci-bugfix@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue 26 Jan 02:52 CST 2021, Jiapeng Zhong wrote: > Fix the following coccicheck warnings: > > ./drivers/firmware/qcom_scm.c:324:20-22: WARNING !A || A && B is > equivalent to !A || B. > Reviewed-by: Bjorn Andersson > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Zhong > --- > drivers/firmware/qcom_scm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c > index 7be48c1..c530072 100644 > --- a/drivers/firmware/qcom_scm.c > +++ b/drivers/firmware/qcom_scm.c > @@ -321,7 +321,7 @@ int qcom_scm_set_cold_boot_addr(void *entry, const cpumask_t *cpus) > .owner = ARM_SMCCC_OWNER_SIP, > }; > > - if (!cpus || (cpus && cpumask_empty(cpus))) > + if (!cpus || cpumask_empty(cpus)) > return -EINVAL; > > for_each_cpu(cpu, cpus) { > -- > 1.8.3.1 >