From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AFB3C433DB for ; Thu, 4 Feb 2021 18:07:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 264D564F4D for ; Thu, 4 Feb 2021 18:07:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238486AbhBDSHO (ORCPT ); Thu, 4 Feb 2021 13:07:14 -0500 Received: from mail29.static.mailgun.info ([104.130.122.29]:63097 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238808AbhBDSHG (ORCPT ); Thu, 4 Feb 2021 13:07:06 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1612462003; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=+xP3/Hu6OtoW8HeeJ5puPkj0xWqTw8qLglu5mHOXUz4=; b=iQ4XPjaQJjdWPO0Edr+NTNsIipcnSM2UbpyKgq6HZx2epDFKPoCpdRnsW6F36JjAQZ8Bi3GH tC8FBPUAJR6RW69WrgFP036pPgvJWBqFmW2Yh/RlSg9TKkjLFAD5KMdmGd6imKupSqbdRyQa KgbG6Mwof++1AraKWok2/dlNY9s= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 601c378771c267229308651c (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 04 Feb 2021 18:05:59 GMT Sender: jackp=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 92FF2C43465; Thu, 4 Feb 2021 18:05:57 +0000 (UTC) Received: from jackp-linux.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jackp) by smtp.codeaurora.org (Postfix) with ESMTPSA id B4CE7C43463; Thu, 4 Feb 2021 18:05:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B4CE7C43463 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=jackp@codeaurora.org Date: Thu, 4 Feb 2021 10:05:52 -0800 From: Jack Pham To: Vinod Koul Cc: Bjorn Andersson , linux-arm-msm@vger.kernel.org, Andy Gross , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] arm64: dts: qcom: sm8350: add USB and PHY device nodes Message-ID: <20210204180552.GA25531@jackp-linux.qualcomm.com> References: <20210204170907.63545-1-vkoul@kernel.org> <20210204170907.63545-3-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210204170907.63545-3-vkoul@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Vinod, On Thu, Feb 04, 2021 at 10:39:03PM +0530, Vinod Koul wrote: > From: Jack Pham > > Add device nodes for the two instances each of USB3 controllers, > QMP SS PHYs and SNPS HS PHYs. > > Signed-off-by: Jack Pham > Message-Id: <20210116013802.1609-2-jackp@codeaurora.org> > Signed-off-by: Vinod Koul > --- > arch/arm64/boot/dts/qcom/sm8350.dtsi | 179 +++++++++++++++++++++++++++ > 1 file changed, 179 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi > index e3597e2a22ab..e51d9ca0210c 100644 > --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi > @@ -592,6 +592,185 @@ rpmhcc: clock-controller { > }; > > }; > + > + usb_1_hsphy: phy@88e3000 { > + compatible = "qcom,sm8350-usb-hs-phy", > + "qcom,usb-snps-hs-7nm-phy"; > + reg = <0 0x088e3000 0 0x400>; > + status = "disabled"; > + #phy-cells = <0>; > + > + clocks = <&rpmhcc RPMH_CXO_CLK>; > + clock-names = "ref"; > + > + resets = <&gcc 20>; Shouldn't this (and all the other gcc phandles below) use the dt-bindings macros from here? https://patchwork.kernel.org/project/linux-arm-msm/patch/20210118044321.2571775-5-vkoul@kernel.org/ Jack -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project