From: Vinod Koul <vkoul@kernel.org>
To: Georgi Djakov <georgi.djakov@linaro.org>
Cc: linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Odelu Kukatla <okukatla@codeaurora.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: interconnect: Add Qualcomm SM8350 DT bindings
Date: Wed, 10 Feb 2021 17:37:25 +0530 [thread overview]
Message-ID: <20210210120725.GE2774@vkoul-mobl.Dlink> (raw)
In-Reply-To: <30719cbd-6702-4b1e-2117-e5b8f11fd68d@linaro.org>
Hi Gerogi,
On 10-02-21, 13:30, Georgi Djakov wrote:
> > +#define SM8350_MASTER_LLCC_DISP 1000
> > +#define SM8350_MASTER_MNOC_HF_MEM_NOC_DISP 1001
> > +#define SM8350_MASTER_MNOC_SF_MEM_NOC_DISP 1002
> > +#define SM8350_MASTER_MDP0_DISP 1003
> > +#define SM8350_MASTER_MDP1_DISP 1004
> > +#define SM8350_MASTER_ROTATOR_DISP 1005
> > +#define SM8350_SLAVE_EBI1_DISP 1512
> > +#define SM8350_SLAVE_LLCC_DISP 1513
> > +#define SM8350_SLAVE_MNOC_HF_MEM_NOC_DISP 1514
> > +#define SM8350_SLAVE_MNOC_SF_MEM_NOC_DISP 1515
>
> Why are you using these big numbers? They are used as array indexes
> and we will be wasting a lot of memory for unnecessary large arrays.
Thanks for the explanation, yes that would be the case. I will split it
up and send v2
--
~Vinod
prev parent reply other threads:[~2021-02-10 12:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 10:47 [PATCH 1/2] dt-bindings: interconnect: Add Qualcomm SM8350 DT bindings Vinod Koul
2021-02-10 10:47 ` [PATCH 2/2] interconnect: qcom: Add SM8350 interconnect provider driver Vinod Koul
2021-02-10 11:40 ` Georgi Djakov
2021-02-10 12:10 ` Vinod Koul
2021-02-10 11:30 ` [PATCH 1/2] dt-bindings: interconnect: Add Qualcomm SM8350 DT bindings Georgi Djakov
2021-02-10 12:07 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210120725.GE2774@vkoul-mobl.Dlink \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=okukatla@codeaurora.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox