Re: [PATCH v10 0/8] Add support for ipq8064 tsens

Thara Gopinath
2021-03-10T13:33:32Z

On 3/10/21 7:19 AM, Daniel Lezcano wrote:
>
> Hi Ansuel,
>
> On 17/02/2021 20:40, Ansuel Smith wrote:
>> This patchset convert msm8960 to reg_filed, use int_common instead
>> of a custom function and fix wrong tsens get_temp function for msm8960.
>> Ipq8064 SoCs tsens driver is based on 8960 tsens driver. Ipq8064 needs
>> to be registered as a gcc child as the tsens regs on this platform are
>> shared with the controller.
>> This is based on work and code here
>> https://git.linaro.org/people/amit.kucheria/kernel.git/log/?h=wrk3/tsens-8960-breakage
>
> I don't have major concerns with the series except there is no comment
> from the maintainer / reviewer of the sensor.
>
> Given it is based on Amit's work, I can assume they are correct.
>
> I added Thara in Cc hoping she has time to review the changes. If nobody
> complains with the series, I'll merge them in the next days

Hi Ansuel/Daniel,

Just wanted to let you know that I have started looking into this and
review this within next week or two.

>
> Thanks
>
> -- Daniel
>
>

--
Warm Regards
Thara