Re: [PATCH v10 2/8] drivers: thermal: tsens: Don't hardcode sensor slope

Thara Gopinath
2021-03-18T21:16:12Z

On 2/17/21 2:40 PM, Ansuel Smith wrote:
> Function compute_intercept_slope hardcode the sensor slope to
> SLOPE_DEFAULT. Change this and use the default value only if a slope is
> not defined. This is needed for tsens VER_0 that has a hardcoded slope
> table.
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>

Reviewed-by: Thara Gopinath <thara.gopinath@linaro.org>

Warm Regards
Thara

> ---
> drivers/thermal/qcom/tsens.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
> index f9126909892b..842f518fdf84 100644
> --- a/drivers/thermal/qcom/tsens.c
> +++ b/drivers/thermal/qcom/tsens.c
> @@ -86,7 +86,8 @@ void compute_intercept_slope(struct tsens_priv *priv, u32 *p1,
> "%s: sensor%d - data_point1:%#x data_point2:%#x\n",
> __func__, i, p1[i], p2[i]);
>
> - priv->sensor[i].slope = SLOPE_DEFAULT;
> + if (!priv->sensor[i].slope)
> + priv->sensor[i].slope = SLOPE_DEFAULT;
> if (mode == TWO_PT_CALIB) {
> /*
> * slope (m) = adc_code2 - adc_code1 (y2 - y1)/
>

--
Warm Regards
Thara