From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <agross@kernel.org>, Ohad Ben-Cohen <ohad@wizery.com>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remoteproc: qcom_q6v5_mss: Provide errors for firmware-name parsing
Date: Mon, 15 Mar 2021 10:22:24 -0600 [thread overview]
Message-ID: <20210315162224.GB1339147@xps15> (raw)
In-Reply-To: <20210312002605.3273255-1-bjorn.andersson@linaro.org>
On Thu, Mar 11, 2021 at 04:26:05PM -0800, Bjorn Andersson wrote:
> Failing to read the "firmware-name" DT property without informing the
> developer is annoying, add some helpful debug prints.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/remoteproc/qcom_q6v5_mss.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
> index 66106ba25ba3..15abfbba78d2 100644
> --- a/drivers/remoteproc/qcom_q6v5_mss.c
> +++ b/drivers/remoteproc/qcom_q6v5_mss.c
> @@ -1661,8 +1661,10 @@ static int q6v5_probe(struct platform_device *pdev)
> mba_image = desc->hexagon_mba_image;
> ret = of_property_read_string_index(pdev->dev.of_node, "firmware-name",
> 0, &mba_image);
> - if (ret < 0 && ret != -EINVAL)
> + if (ret < 0 && ret != -EINVAL) {
> + dev_err(&pdev->dev, "unable to read mba firmware-name\n");
> return ret;
> + }
>
> rproc = rproc_alloc(&pdev->dev, pdev->name, &q6v5_ops,
> mba_image, sizeof(*qproc));
> @@ -1680,8 +1682,10 @@ static int q6v5_probe(struct platform_device *pdev)
> qproc->hexagon_mdt_image = "modem.mdt";
> ret = of_property_read_string_index(pdev->dev.of_node, "firmware-name",
> 1, &qproc->hexagon_mdt_image);
> - if (ret < 0 && ret != -EINVAL)
> + if (ret < 0 && ret != -EINVAL) {
> + dev_err(&pdev->dev, "unable to read mpss firmware-name\n");
> goto free_rproc;
> + }
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
>
> platform_set_drvdata(pdev, qproc);
>
> --
> 2.29.2
>
next prev parent reply other threads:[~2021-03-15 16:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 0:26 [PATCH] remoteproc: qcom_q6v5_mss: Provide errors for firmware-name parsing Bjorn Andersson
2021-03-15 16:22 ` Mathieu Poirier [this message]
2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315162224.GB1339147@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox