From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: linux-arm-msm@vger.kernel.org,
Ralf Ramsauer <ralf.ramsauer@oth-regensburg.de>,
linux-doc@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org,
Lukas Bulwahn <lukas.bulwahn@gmail.com>
Subject: [PATCH 0/2] kernel-doc and MAINTAINERS clean-up
Date: Sat, 27 Mar 2021 07:56:40 +0100 [thread overview]
Message-ID: <20210327065642.11969-1-lukas.bulwahn@gmail.com> (raw)
Roughly 900 warnings of about 21.000 kernel-doc warnings in the kernel tree
warn with 'cannot understand function prototype:', i.e., the kernel-doc parser
cannot parse the function's signature. The majority, about 600 cases of those,
are just struct definitions following the kernel-doc description. Further,
spot-check investigations suggest that the authors of the specific kernel-doc
descriptions simply were not aware that the general format for a kernel-doc
description for a structure requires to prefix the struct name with the keyword
'struct', as in 'struct struct_name - Brief description.'. Details on
kernel-doc are at the Link below.
Without the struct keyword, kernel-doc does not check if the kernel-doc
description fits to the actual struct definition in the source code.
Fortunately, in roughly a quarter of these cases, the kernel-doc description is
actually complete wrt. its corresponding struct definition. So, the trivial
change adding the struct keyword will allow us to keep the kernel-doc
descriptions more consistent for future changes, by checking for new kernel-doc
warnings.
Also, some of the files in ./include/ are not assigned to a specific
MAINTAINERS section and hence have no dedicated maintainer. So, if needed, the
files in ./include/ are also assigned to the fitting MAINTAINERS section, as I
need to identify whom to send the clean-up patch anyway.
Here is the change from this kernel-doc janitorial work in the ./include/
directory for ARM/QUALCOMM SUPPORT.
Andy, Bjorn, please pick this clean-up patch series for your tree.
Link: https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html
Lukas Bulwahn (2):
MAINTAINERS: add another entry for ARM/QUALCOMM SUPPORT
soc: qcom: address kernel-doc warnings
MAINTAINERS | 1 +
include/linux/soc/qcom/apr.h | 2 +-
include/linux/soc/qcom/irq.h | 2 +-
include/linux/soc/qcom/llcc-qcom.h | 6 +++---
include/linux/soc/qcom/qmi.h | 4 ++--
5 files changed, 8 insertions(+), 7 deletions(-)
--
2.17.1
next reply other threads:[~2021-03-27 6:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 6:56 Lukas Bulwahn [this message]
2021-03-27 6:56 ` [PATCH 1/2] MAINTAINERS: add another entry for ARM/QUALCOMM SUPPORT Lukas Bulwahn
2021-03-27 6:56 ` [PATCH 2/2] soc: qcom: address kernel-doc warnings Lukas Bulwahn
2021-04-04 18:10 ` [PATCH 0/2] kernel-doc and MAINTAINERS clean-up patchwork-bot+linux-arm-msm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210327065642.11969-1-lukas.bulwahn@gmail.com \
--to=lukas.bulwahn@gmail.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf.ramsauer@oth-regensburg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox