From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD70FC433B4 for ; Wed, 31 Mar 2021 16:26:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98F446100B for ; Wed, 31 Mar 2021 16:26:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233831AbhCaQ0Y (ORCPT ); Wed, 31 Mar 2021 12:26:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233816AbhCaQ0X (ORCPT ); Wed, 31 Mar 2021 12:26:23 -0400 Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 497B0C06174A for ; Wed, 31 Mar 2021 09:26:23 -0700 (PDT) Received: by mail-ot1-x32e.google.com with SMTP id w31-20020a9d36220000b02901f2cbfc9743so19460782otb.7 for ; Wed, 31 Mar 2021 09:26:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FbposqgapdTdAS+TUQHgC3JJ2yt1So9MQA6oTHq2HyM=; b=ZZd/A3VhaWLf87FVg8P1ETQbMeM4bycDbJ6/1pg/jHN5ZUmh2n5Da+wqk6B7ZfXQq5 TjZba8TFJ4YiC2U86OvgIh0n6PTxMPmEapCOoACsT7Umo4ooYYa06ngCiyuMeYt7bCj4 QA5SmAajb8S2AAna5rS6c9UA13qFcyelWqdHL4aDt2vdAXTaRByz4GKuB6GzL+6YpEXx gdeXnFsuE+P+/9hyu+uqqUPTAk9NJZAvlcBlHgRFNGndjEn2CxWjjLRPIL9xbTn6D2tL 7Ac0d0yNm0Q/a7e0J8Q9oYA7OACz9cTKwo0eAj36rkCPMS19Of5iHuAVBd0kwxyLe9YV GRqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FbposqgapdTdAS+TUQHgC3JJ2yt1So9MQA6oTHq2HyM=; b=c2Ltztp+7UsMFwH2Ucys1WsOdPL0Q/UY3fP8Q8yvHbfg+JpexDnsu8IzwjInVd5XCZ SePKHGWbX7Gb1nd6BHdOJ7VmV7hmrkORIyPeF21L9IIrWcS2Vo6RYpWepu9hmUwMLL2b Jamoq0AA4wgMyvityim8O7H1LDUMaZKItp84yZsOrQxjT/IBN6CXYHZEnUFeB8bqbfdb RgLtRBh7zLg0PurucIr7X3YVacHKYhZadNP6vTk3TVUqSbXCy6ecIYCQz9dp/LurzQQh 81Xw/ln+6OTtqcbi26OOPyQhddfVKjoFKOEeQauDWTPzKyoqUWKeOeAcBO46fEs5r2X+ +48Q== X-Gm-Message-State: AOAM530tKgz4fQW8+rD+KyHee76rwQUmTeGzomMGHFAzYupwe6CleTC1 TDrHjAsRGICP5WThgY4qH7UM0w== X-Google-Smtp-Source: ABdhPJwpuw4Dcj+wqGcEfRmuYfn1e+Gs7VXG66D29ALgKuCxRO8vT4VsmB0HRn/ZbEem/ltTw2GQoQ== X-Received: by 2002:a05:6830:1282:: with SMTP id z2mr3401766otp.30.1617207982514; Wed, 31 Mar 2021 09:26:22 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id f29sm571110ots.22.2021.03.31.09.26.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Mar 2021 09:26:22 -0700 (PDT) Date: Wed, 31 Mar 2021 11:26:19 -0500 From: Bjorn Andersson To: Vinod Koul Cc: Srinivas Kandagatla , Bard Liao , Pierre-Louis Bossart , Sanyog Kale , linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH V2] soundwire: qcom: use signed variable for error return Message-ID: <20210331162619.GK904837@yoga> References: <20210331155520.2987823-1-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210331155520.2987823-1-vkoul@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed 31 Mar 10:55 CDT 2021, Vinod Koul wrote: > We get warning of using a unsigned variable being compared to less than > zero. The comparison is correct as it checks for errors from previous > call to qcom_swrm_get_alert_slave_dev_num(), so we should use a signed > variable here. > > While at it, drop the superfluous initialization as well > > drivers/soundwire/qcom.c: qcom_swrm_irq_handler() warn: impossible > condition '(devnum < 0) => (0-255 < 0)' > > Reported-by: kernel test robot > Signed-off-by: Vinod Koul Reviewed-by: Bjorn Andersson > --- > drivers/soundwire/qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c > index b08ecb9b418c..ec86c4e53fdb 100644 > --- a/drivers/soundwire/qcom.c > +++ b/drivers/soundwire/qcom.c > @@ -428,7 +428,7 @@ static irqreturn_t qcom_swrm_irq_handler(int irq, void *dev_id) > struct qcom_swrm_ctrl *swrm = dev_id; > u32 value, intr_sts, intr_sts_masked, slave_status; > u32 i; > - u8 devnum = 0; > + int devnum; > int ret = IRQ_HANDLED; > > swrm->reg_read(swrm, SWRM_INTERRUPT_STATUS, &intr_sts); > -- > 2.26.3 >