From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4FCAC433B4 for ; Wed, 31 Mar 2021 18:33:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7240460FF0 for ; Wed, 31 Mar 2021 18:33:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234922AbhCaSch (ORCPT ); Wed, 31 Mar 2021 14:32:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234743AbhCaScU (ORCPT ); Wed, 31 Mar 2021 14:32:20 -0400 Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CE43C06175F for ; Wed, 31 Mar 2021 11:32:19 -0700 (PDT) Received: by mail-oi1-x229.google.com with SMTP id n8so20903526oie.10 for ; Wed, 31 Mar 2021 11:32:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qpDJgLSf+XhBZgWjOA4HUIRo8TMIOMt4qQN8xcUT7Yc=; b=RtkjC0li+ibQ4Jqa4lRUa7G264zhtqFQ0ippTOexSIit4u0rgqCjWmvEi59FLRlMJw C5hGgoCAT+8X5Kekza3SlgPOZrermppqx8iclo+ZGv4pOiGm8ijyOryQEWcdaDvg3HHM 7HNknHiNiQ8NGjA6BRXHp3flO7hmlITbC7q+UWXljyawBsgHl+vIId6wnt4wSzuMNrxi XA9Hkdm9GBzSRo0BqVo0CMtXFewl6RpbRQAY6N4lZF5d1/eaz5rXGKzogaFHVggYOmbT yv95yUjZ+5Qj3sNovTijK8saN4Mm3GpY7Jm93T88BLJToE9P3dMchHidaBzTdz8l7MKT PtKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qpDJgLSf+XhBZgWjOA4HUIRo8TMIOMt4qQN8xcUT7Yc=; b=cx8nT2kt4QqguB9Ac4Q5T5ccKjNgA+PLpIRThJeS0/ycA9eK6/cApUQacDtgDvSoJB eCTQ3BPoyuBT6pHomFAjQTxurIeC7s0ipf7EsyCDFbMGwe1r1xRnmEdwdIwGylent12R TzTBl2d3/RqevobXWt0c14L/w/5nllYyc87Q6YlFz2fZ4De1Gs0bx8MPQga/Mpnm4ceO cPmSghiaH/AbEDnL6uhaEoSd92JY+5HS5aH76jIlSrqqpt1ZjGcAKLjZ6vqXFCSQMZXt 12cN90rAcEaHUzZkp8n6SjV2TzEwe3spz96k6djET0pRCsjeShaPxtNk2ey40DMQhRwX mYbQ== X-Gm-Message-State: AOAM533ESTkq6yIe7Am+7K5lRPIDHOcfGmMQLpafo92ezpW2ySlxVVoJ AqoxxC7aqAmT5JapeexAVfKF5A== X-Google-Smtp-Source: ABdhPJw9aZIIFK4bl49eSq1vxFZv/ytgNjkVTf40RbmdsFrI/AGg7PHyskOnmBX5Uo3IKDlviOZN8g== X-Received: by 2002:aca:d442:: with SMTP id l63mr3114260oig.49.1617215538553; Wed, 31 Mar 2021 11:32:18 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id d1sm577516oop.0.2021.03.31.11.32.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Mar 2021 11:32:18 -0700 (PDT) Date: Wed, 31 Mar 2021 13:32:16 -0500 From: Bjorn Andersson To: Colin King Cc: Andy Gross , Vinod Koul , Bard Liao , Sanyog Kale , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] soundwire: qcom: Fix a u8 comparison with less than zero Message-ID: <20210331183216.GM904837@yoga> References: <20210331140944.1421940-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210331140944.1421940-1-colin.king@canonical.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed 31 Mar 09:09 CDT 2021, Colin King wrote: > From: Colin Ian King > > Variable devnum is being checked for a less than zero error return > however the comparison will always be false because devnum is an 8 bit > unsigned integer. Fix this by making devnum an int. Also there is no > need to iniitialize devnum with zero as this value is no read, so > remove the redundant assignment. > > Addresses-Coverity: ("Unsigned compared against 0") > Fixes: c7d49c76d1d5 ("soundwire: qcom: add support to new interrupts") > Signed-off-by: Colin Ian King Reviewed-by: Bjorn Andersson > --- > drivers/soundwire/qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c > index b08ecb9b418c..ec86c4e53fdb 100644 > --- a/drivers/soundwire/qcom.c > +++ b/drivers/soundwire/qcom.c > @@ -428,7 +428,7 @@ static irqreturn_t qcom_swrm_irq_handler(int irq, void *dev_id) > struct qcom_swrm_ctrl *swrm = dev_id; > u32 value, intr_sts, intr_sts_masked, slave_status; > u32 i; > - u8 devnum = 0; > + int devnum; > int ret = IRQ_HANDLED; > > swrm->reg_read(swrm, SWRM_INTERRUPT_STATUS, &intr_sts); > -- > 2.30.2 >