From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2989EC433ED for ; Sun, 4 Apr 2021 14:46:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E0F8C61210 for ; Sun, 4 Apr 2021 14:46:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230446AbhDDOqN (ORCPT ); Sun, 4 Apr 2021 10:46:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229633AbhDDOqL (ORCPT ); Sun, 4 Apr 2021 10:46:11 -0400 Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94A07C061756 for ; Sun, 4 Apr 2021 07:46:05 -0700 (PDT) Received: by mail-ot1-x32f.google.com with SMTP id 68-20020a9d0f4a0000b02901b663e6258dso9186730ott.13 for ; Sun, 04 Apr 2021 07:46:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/LaNflTLlNyLNnfybNeALEmO1QkTG5j1xdulmReRjoc=; b=CZM2rMQSwB2owpt42AvT2FwrK2kKavTNZW2qXqPm40A9XNcHC0qd3HPkMx8GmkhDg0 I2HWKqyPeMPUr528I9raDod/WGbwejghrYK7Pxr1dc95XxjEy2uOFKB/WtqoOWrKotQW LnEgRS7NBlf+QZOz6cj/ImQzlXWTyjOHzVpEdk8T+2laECuM0dKXDvjREmNt1q+Nb7La KgTAxtDCCCelkVqOC9oag1gQWPuJ0SYnUy9fjIsyggISYFESRLeH8+NH+F0l/FzOdpEg aAHEU2J823upnfeAmfOfinMWhedQR8q3oAwKbJ3c4H3VSFUjM5h4JXaG32sLI+3a+zEO y8yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/LaNflTLlNyLNnfybNeALEmO1QkTG5j1xdulmReRjoc=; b=uYBrMpQV/zmR90tJFGwr55O8S+qQnFuyJv+iwUgH/eKG753pFrWHkyoeaLVD55kTp6 AEz/2A96JfjLNJQ0+7S9WHI9FFRmixvq7b8Dq6AdUayVZIbfUgpnvJxScG42g8G8F8xE Med6oV6WoSC5NHyGS5ngDqs2FcQXvwvqx5h+2CvJmBnqCVk4SGOdKX35GvBYWjf+s5Ws 30/6t72ziuiCKVrufm/sf85qumCn4/3dm9fz1kb4ckL08Ty0rVVT2jBRBm3wqxGl0e0J 550DdIhHF0Dtrs3ektnZZ8tUVT+tOW907rs0uXkcwtPeXW1jbh6T+esJCGvICL4T5Ep+ YUMw== X-Gm-Message-State: AOAM5334omOvB8RjxzT8jGenJ4c/Q2g/oC+8W/MWQMsuRJNx9bJzZbJH b2g/s4MdkWFup+0YoYkUJ1ASBA== X-Google-Smtp-Source: ABdhPJyp7sIs73IWuqvjliAsiqBoC6b7KWxE8kmcQ6qGxXGJJkEpwC7cBxVPha62YNwSjCkVGUFyMw== X-Received: by 2002:a9d:39ca:: with SMTP id y68mr19355517otb.84.1617547564520; Sun, 04 Apr 2021 07:46:04 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id w2sm2963328oov.23.2021.04.04.07.46.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Apr 2021 07:46:04 -0700 (PDT) Date: Sun, 4 Apr 2021 09:46:02 -0500 From: Bjorn Andersson To: zhuguangqing83@gmail.com Cc: Amit Kucheria , Andy Gross , Zhang Rui , Daniel Lezcano , linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] thermal/drivers/tsens: fix missing put_device error Message-ID: <20210404144602.GV904837@yoga> References: <20210404125431.12208-1-zhuguangqing83@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210404125431.12208-1-zhuguangqing83@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sun 04 Apr 07:54 CDT 2021, zhuguangqing83@gmail.com wrote: > From: Guangqing Zhu > > Fixes coccicheck error: > > drivers/thermal/qcom/tsens.c:759:4-10: ERROR: missing put_device; call > of_find_device_by_node on line 715, but without a corresponding object > release within this function. > > Fixes: a7ff82976122 ("drivers: thermal: tsens: Merge tsens-common.c into > tsens.c") > > Signed-off-by: Guangqing Zhu Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > v2: > - Fix a error(missing a bracket) in v1. > > --- > drivers/thermal/qcom/tsens.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c > index d8ce3a687b80..3c4c0516e58a 100644 > --- a/drivers/thermal/qcom/tsens.c > +++ b/drivers/thermal/qcom/tsens.c > @@ -755,8 +755,10 @@ int __init init_common(struct tsens_priv *priv) > for (i = VER_MAJOR; i <= VER_STEP; i++) { > priv->rf[i] = devm_regmap_field_alloc(dev, priv->srot_map, > priv->fields[i]); > - if (IS_ERR(priv->rf[i])) > - return PTR_ERR(priv->rf[i]); > + if (IS_ERR(priv->rf[i])) { > + ret = PTR_ERR(priv->rf[i]); > + goto err_put_device; > + } > } > ret = regmap_field_read(priv->rf[VER_MINOR], &ver_minor); > if (ret) > -- > 2.17.1 >