From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Chen Hui <clare.chenhui@huawei.com>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
mturquette@baylibre.com, sboyd@kernel.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] clk: qcom: Add missing MODULE_DEVICE_TABLE
Date: Fri, 9 Apr 2021 11:53:08 +0530 [thread overview]
Message-ID: <20210409062308.GB4376@work> (raw)
In-Reply-To: <20210408135509.208921-1-clare.chenhui@huawei.com>
On Thu, Apr 08, 2021 at 09:55:09PM +0800, Chen Hui wrote:
> Add missing MODULE_DEVICE_TABLE entries to support module autoloading,
> as these drivers can be compiled as external modules.
>
> Signed-off-by: Chen Hui <clare.chenhui@huawei.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> drivers/clk/qcom/a53-pll.c | 1 +
> drivers/clk/qcom/a7-pll.c | 1 +
> drivers/clk/qcom/apss-ipq-pll.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/drivers/clk/qcom/a53-pll.c b/drivers/clk/qcom/a53-pll.c
> index 45cfc57bff92..af6ac17c7dae 100644
> --- a/drivers/clk/qcom/a53-pll.c
> +++ b/drivers/clk/qcom/a53-pll.c
> @@ -93,6 +93,7 @@ static const struct of_device_id qcom_a53pll_match_table[] = {
> { .compatible = "qcom,msm8916-a53pll" },
> { }
> };
> +MODULE_DEVICE_TABLE(of, qcom_a53pll_match_table);
>
> static struct platform_driver qcom_a53pll_driver = {
> .probe = qcom_a53pll_probe,
> diff --git a/drivers/clk/qcom/a7-pll.c b/drivers/clk/qcom/a7-pll.c
> index e171d3caf2cf..c4a53e5db229 100644
> --- a/drivers/clk/qcom/a7-pll.c
> +++ b/drivers/clk/qcom/a7-pll.c
> @@ -86,6 +86,7 @@ static const struct of_device_id qcom_a7pll_match_table[] = {
> { .compatible = "qcom,sdx55-a7pll" },
> { }
> };
> +MODULE_DEVICE_TABLE(of, qcom_a7pll_match_table);
>
> static struct platform_driver qcom_a7pll_driver = {
> .probe = qcom_a7pll_probe,
> diff --git a/drivers/clk/qcom/apss-ipq-pll.c b/drivers/clk/qcom/apss-ipq-pll.c
> index 30be87fb222a..bef7899ad0d6 100644
> --- a/drivers/clk/qcom/apss-ipq-pll.c
> +++ b/drivers/clk/qcom/apss-ipq-pll.c
> @@ -81,6 +81,7 @@ static const struct of_device_id apss_ipq_pll_match_table[] = {
> { .compatible = "qcom,ipq6018-a53pll" },
> { }
> };
> +MODULE_DEVICE_TABLE(of, apss_ipq_pll_match_table);
>
> static struct platform_driver apss_ipq_pll_driver = {
> .probe = apss_ipq_pll_probe,
> --
> 2.17.1
>
prev parent reply other threads:[~2021-04-09 6:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 13:55 [PATCH -next] clk: qcom: Add missing MODULE_DEVICE_TABLE Chen Hui
2021-04-08 20:30 ` Stephen Boyd
2021-04-09 1:48 ` Chenhui (clare)
2021-04-09 6:23 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210409062308.GB4376@work \
--to=manivannan.sadhasivam@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=clare.chenhui@huawei.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).