Re: [PATCH v2] drm/msm/dp: add logs across DP driver for ease of debugging

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3692 bytes --]

Hi maitreye,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.13 next-20210709]
[cannot apply to drm/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/maitreye/drm-msm-dp-add-logs-across-DP-driver-for-ease-of-debugging/20210709-031606
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: arm-randconfig-r005-20210709 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 8d69635ed9ecf36fd0ca85906bfde17949671cbe)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/0day-ci/linux/commit/4600296e3781e89ddd188cadf6f62b587a8f4eb9
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review maitreye/drm-msm-dp-add-logs-across-DP-driver-for-ease-of-debugging/20210709-031606
        git checkout 4600296e3781e89ddd188cadf6f62b587a8f4eb9
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/msm/dp/dp_display.c:499:36: warning: variable 'sink_request' is uninitialized when used here [-Wuninitialized]
           DRM_DEBUG_DP("sink_request:%d\n", sink_request);
                                             ^~~~~~~~~~~~
   include/drm/drm_print.h:525:31: note: expanded from macro 'DRM_DEBUG_DP'
           __drm_dbg(DRM_UT_DP, fmt, ## __VA_ARGS__)
                                        ^~~~~~~~~~~
   drivers/gpu/drm/msm/dp/dp_display.c:492:18: note: initialize the variable 'sink_request' to silence this warning
           u32 sink_request;
                           ^
                            = 0
   drivers/gpu/drm/msm/dp/dp_display.c:1030:21: warning: variable 'drm' set but not used [-Wunused-but-set-variable]
           struct drm_device *drm;
                              ^
   2 warnings generated.


vim +/sink_request +499 drivers/gpu/drm/msm/dp/dp_display.c

   488	
   489	static int dp_display_usbpd_attention_cb(struct device *dev)
   490	{
   491		int rc = 0;
   492		u32 sink_request;
   493		struct dp_display_private *dp;
   494	
   495		if (!dev) {
   496			DRM_ERROR("invalid dev\n");
   497			return -EINVAL;
   498		}
 > 499		DRM_DEBUG_DP("sink_request:%d\n", sink_request);
   500	
   501		dp = container_of(g_dp_display,
   502				struct dp_display_private, dp_display);
   503	
   504		/* check for any test request issued by sink */
   505		rc = dp_link_process_request(dp->link);
   506		if (!rc) {
   507			sink_request = dp->link->sink_request;
   508			DRM_DEBUG_DP("hpd_state=%d sink_count=%d\n", dp->hpd_state, sink_request);
   509			if (sink_request & DS_PORT_STATUS_CHANGED)
   510				rc = dp_display_handle_port_ststus_changed(dp);
   511			else
   512				rc = dp_display_handle_irq_hpd(dp);
   513		}
   514	
   515		return rc;
   516	}
   517	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38051 bytes --]