From: Manivannan Sadhasivam <mani@kernel.org>
To: Paul Davey <paul.davey@alliedtelesis.co.nz>
Cc: Hemant Kumar <hemantk@codeaurora.org>,
Bhaumik Bhatt <bbhatt@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] bus: mhi: Fix MHI on big endian architectures
Date: Fri, 16 Jul 2021 11:13:42 +0530 [thread overview]
Message-ID: <20210716054342.GD3323@workstation> (raw)
In-Reply-To: <20210629035357.11091-1-paul.davey@alliedtelesis.co.nz>
On Tue, Jun 29, 2021 at 03:53:55PM +1200, Paul Davey wrote:
> I encountered some problems getting the MHI driver to work on an Octeon
> 3 platform these seem to all be related to endianness issues. The modem
> interface appears to require the DMA structures to be in little endian,
> however the MHI core driver was assembling them in native endianness.
>
> Using little endian explicitly allows the interface to function as
> expected.
>
Please add fixes tag and Cc stable for all the patches.
Thanks,
Mani
> Changes in v3:
> - removed change of doorbell helper functions db_val type from
> dma_addr_t to __le64 favouring doing conversion only when writing to
> context wp fields.
> Changes in v2:
> - use __fls instead of find_last_bit in pm_state conversion patch as
> requested by Hemant Kumar <hemantk@codeaurora.org>
>
> Paul Davey (2):
> bus: mhi: Fix pm_state conversion to string
> bus: mhi: Fix MHI DMA structure endianness
>
> drivers/bus/mhi/core/debugfs.c | 26 +++----
> drivers/bus/mhi/core/init.c | 43 ++++++------
> drivers/bus/mhi/core/internal.h | 119 ++++++++++++++++----------------
> drivers/bus/mhi/core/main.c | 22 +++---
> drivers/bus/mhi/core/pm.c | 4 +-
> 5 files changed, 109 insertions(+), 105 deletions(-)
>
> --
> 2.32.0
>
prev parent reply other threads:[~2021-07-16 5:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 3:53 [PATCH v3 0/2] bus: mhi: Fix MHI on big endian architectures Paul Davey
2021-06-29 3:53 ` [PATCH v3 1/2] bus: mhi: Fix pm_state conversion to string Paul Davey
2021-07-01 1:50 ` Hemant Kumar
2021-07-16 5:35 ` Manivannan Sadhasivam
2021-06-29 3:53 ` [PATCH v3 2/2] bus: mhi: Fix MHI DMA structure endianness Paul Davey
2021-07-01 1:52 ` Hemant Kumar
2021-07-16 0:35 ` Bhaumik Bhatt
2021-07-16 5:43 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210716054342.GD3323@workstation \
--to=mani@kernel.org \
--cc=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.davey@alliedtelesis.co.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).