From: Shawn Guo <shawn.guo@linaro.org>
To: Marijn Suijten <marijn.suijten@somainline.org>
Cc: Shawn Guo <shawnguo@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-msm@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@somainline.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Martin Botka <martin.botka@somainline.org>,
Pavel Dubrova <pashadubrova@gmail.com>,
Siddharth Gupta <sidgup@codeaurora.org>
Subject: Re: [PATCH] soc: qcom: mdt_loader: Drop PT_LOAD check on hash segment
Date: Fri, 27 Aug 2021 22:12:01 +0800 [thread overview]
Message-ID: <20210827141200.GA4274@dragon> (raw)
In-Reply-To: <9166e1a9-5afa-7ae8-91e5-21704bc7a40f@somainline.org>
On Fri, Aug 27, 2021 at 12:46:47PM +0200, Marijn Suijten wrote:
> Hi Shawn,
>
> On 8/27/21 11:57 AM, Shawn Guo wrote:
> > > [..]
> > > PT_LOAD specifies that the segment is to be loaded externally. The fact
> > > that our .mdt file is a tight pack of b00 + b01 is mere convenience, but is
> > > it also a given for the future? Can we rely on this assumption to never
> > > change?
> >
> > My patch is trying to fix an existing issue, not anything for the
> > future.
>
>
> We both agree that the PT_LOAD assertion here is too strict, but removing it
> altogether makes the function too lenient and allows for possible bugs. To
> solve your issue in the simple case I have already suggested to add an extra
> bounds check.
So you proposed to reject PT_LOAD in the else clause, which right now
handles .mbn case, are you sure hash segment in .mbn is not going to be
PT_LOAD?
Shawn
next prev parent reply other threads:[~2021-08-27 14:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 9:41 [PATCH] soc: qcom: mdt_loader: Drop PT_LOAD check on hash segment Shawn Guo
2021-08-24 15:18 ` Marijn Suijten
2021-08-24 15:34 ` Marijn Suijten
2021-08-26 14:18 ` Shawn Guo
2021-08-26 20:52 ` Marijn Suijten
2021-08-27 6:24 ` Shawn Guo
2021-08-27 8:29 ` Marijn Suijten
2021-08-27 9:57 ` Shawn Guo
2021-08-27 10:46 ` Marijn Suijten
2021-08-27 14:12 ` Shawn Guo [this message]
2021-08-27 15:13 ` Marijn Suijten
2021-08-28 6:03 ` Shawn Guo
2021-08-28 8:58 ` Marijn Suijten
2021-08-27 16:07 ` Bjorn Andersson
2021-08-27 17:40 ` Marijn Suijten
2021-08-27 21:25 ` Bjorn Andersson
2021-08-27 23:42 ` Marijn Suijten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210827141200.GA4274@dragon \
--to=shawn.guo@linaro.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bjorn.andersson@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=pashadubrova@gmail.com \
--cc=shawnguo@kernel.org \
--cc=sidgup@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox