From: Bixuan Cui <cuibixuan@huawei.com>
To: <linux-kernel@vger.kernel.org>,
<linux-remoteproc@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>
Cc: <agross@kernel.org>, <bjorn.andersson@linaro.org>,
<ohad@wizery.com>, <mathieu.poirier@linaro.org>
Subject: [PATCH -next] remoteproc: qcom_wcnss: Add missing of_node_put() in qcom_iris_probe()
Date: Sat, 11 Sep 2021 16:13:47 +0800 [thread overview]
Message-ID: <20210911081347.33929-1-cuibixuan@huawei.com> (raw)
Add missing of_node_put() in qcom_iris_probe() before return.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
---
drivers/remoteproc/qcom_wcnss_iris.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/remoteproc/qcom_wcnss_iris.c b/drivers/remoteproc/qcom_wcnss_iris.c
index 09720ddddc85..f77ab49a9cae 100644
--- a/drivers/remoteproc/qcom_wcnss_iris.c
+++ b/drivers/remoteproc/qcom_wcnss_iris.c
@@ -140,6 +140,7 @@ struct qcom_iris *qcom_iris_probe(struct device *parent, bool *use_48mhz_xo)
ret = device_add(&iris->dev);
if (ret) {
put_device(&iris->dev);
+ of_node_put(of_node);
return ERR_PTR(ret);
}
@@ -192,10 +193,12 @@ struct qcom_iris *qcom_iris_probe(struct device *parent, bool *use_48mhz_xo)
*use_48mhz_xo = data->use_48mhz_xo;
+ of_node_put(of_node);
return iris;
err_device_del:
device_del(&iris->dev);
+ of_node_put(of_node);
return ERR_PTR(ret);
}
--
2.17.1
next reply other threads:[~2021-09-11 8:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-11 8:13 Bixuan Cui [this message]
2021-10-09 3:17 ` [PATCH -next] remoteproc: qcom_wcnss: Add missing of_node_put() in qcom_iris_probe() Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210911081347.33929-1-cuibixuan@huawei.com \
--to=cuibixuan@huawei.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox