From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FC2CC433EF for ; Wed, 29 Sep 2021 16:52:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FBAE610A2 for ; Wed, 29 Sep 2021 16:52:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245753AbhI2Qxo (ORCPT ); Wed, 29 Sep 2021 12:53:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:48762 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245180AbhI2Qxn (ORCPT ); Wed, 29 Sep 2021 12:53:43 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 37C1361411; Wed, 29 Sep 2021 16:51:57 +0000 (UTC) Date: Wed, 29 Sep 2021 17:55:51 +0100 From: Jonathan Cameron To: Cai Huoqing Cc: Linus Walleij , Lars-Peter Clausen , Shawn Guo , Sascha Hauer , "Pengutronix Kernel Team" , Fabio Estevam , "NXP Linux Team" , Vladimir Zapolskiy , "Neil Armstrong" , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Andy Gross , "Bjorn Andersson" , Heiko Stuebner , , , , , , Subject: Re: [PATCH v3 8/9] iio: adc: rockchip_saradc: Make use of the helper function dev_err_probe() Message-ID: <20210929175551.7517b018@jic23-huawei> In-Reply-To: <20210928141956.2148-8-caihuoqing@baidu.com> References: <20210928141956.2148-1-caihuoqing@baidu.com> <20210928141956.2148-8-caihuoqing@baidu.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, 28 Sep 2021 22:19:54 +0800 Cai Huoqing wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > Using dev_err_probe() can reduce code size, and the error value > gets printed. > > Signed-off-by: Cai Huoqing In this driver, there is also a call to devm_reset_control_get_exclusive() which I think can return -EPROBE_DEFER There isn't a message printed on that particular patch, but it would be good to add something generic. Same for platform_get_irq() There are some devm_clk_get() calls as well which likewise probably want handling in a similar fashion as you have done in other patches. Thanks, Jonathan > --- > v1->v2: Remove the separate line of PTR_ERR(). > > drivers/iio/adc/rockchip_saradc.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c > index a56a0d7337ca..57419ccb3c70 100644 > --- a/drivers/iio/adc/rockchip_saradc.c > +++ b/drivers/iio/adc/rockchip_saradc.c > @@ -392,11 +392,9 @@ static int rockchip_saradc_probe(struct platform_device *pdev) > } > > info->vref = devm_regulator_get(&pdev->dev, "vref"); > - if (IS_ERR(info->vref)) { > - dev_err(&pdev->dev, "failed to get regulator, %ld\n", > - PTR_ERR(info->vref)); > - return PTR_ERR(info->vref); > - } > + if (IS_ERR(info->vref)) > + return dev_err_probe(&pdev->dev, PTR_ERR(info->vref), > + "failed to get regulator\n"); > > if (info->reset) > rockchip_saradc_reset_controller(info->reset);