* Re: mmotm 2021-10-05-19-53 uploaded (drivers/gpu/drm/msm/hdmi/hdmi_phy.o) [not found] <20211006025350.a5PczFZP4%akpm@linux-foundation.org> @ 2021-10-06 5:48 ` Randy Dunlap 2021-10-06 7:20 ` Stephen Rothwell 0 siblings, 1 reply; 7+ messages in thread From: Randy Dunlap @ 2021-10-06 5:48 UTC (permalink / raw) To: akpm, broonie, linux-fsdevel, linux-kernel, linux-mm, linux-next, mhocko, mm-commits, sfr Cc: dri-devel, Rob Clark, Sean Paul, linux-arm-msm, freedreno [-- Attachment #1: Type: text/plain, Size: 1498 bytes --] On 10/5/21 7:53 PM, akpm@linux-foundation.org wrote: > The mm-of-the-moment snapshot 2021-10-05-19-53 has been uploaded to > > https://www.ozlabs.org/~akpm/mmotm/ > > mmotm-readme.txt says > > README for mm-of-the-moment: > > https://www.ozlabs.org/~akpm/mmotm/ > > This is a snapshot of my -mm patch queue. Uploaded at random hopefully > more than once a week. > > You will need quilt to apply these patches to the latest Linus release (5.x > or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in > https://ozlabs.org/~akpm/mmotm/series > > The file broken-out.tar.gz contains two datestamp files: .DATE and > .DATE-yyyy-mm-dd-hh-mm-ss. Both contain the string yyyy-mm-dd-hh-mm-ss, > followed by the base kernel version against which this patch series is to > be applied. > > This tree is partially included in linux-next. To see which patches are > included in linux-next, consult the `series' file. Only the patches > within the #NEXT_PATCHES_START/#NEXT_PATCHES_END markers are included in > linux-next. > > > A full copy of the full kernel tree with the linux-next and mmotm patches > already applied is available through git within an hour of the mmotm > release. Individual mmotm releases are tagged. The master branch always > points to the latest release, so it's constantly rebasing. on i386: ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3f0): undefined reference to `msm_hdmi_phy_8996_cfg' Full randconfig fle is attached. -- ~Randy [-- Attachment #2: config-msm-hdmi.gz --] [-- Type: application/gzip, Size: 39321 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: mmotm 2021-10-05-19-53 uploaded (drivers/gpu/drm/msm/hdmi/hdmi_phy.o) 2021-10-06 5:48 ` mmotm 2021-10-05-19-53 uploaded (drivers/gpu/drm/msm/hdmi/hdmi_phy.o) Randy Dunlap @ 2021-10-06 7:20 ` Stephen Rothwell 2021-10-06 7:24 ` Christian König 0 siblings, 1 reply; 7+ messages in thread From: Stephen Rothwell @ 2021-10-06 7:20 UTC (permalink / raw) To: Randy Dunlap Cc: akpm, broonie, linux-fsdevel, linux-kernel, linux-mm, linux-next, mhocko, mm-commits, Rob Clark, Sean Paul, linux-arm-msm, freedreno, Christian König, Daniel Vetter, Intel Graphics, DRI [-- Attachment #1: Type: text/plain, Size: 491 bytes --] Hi Randy, On Tue, 5 Oct 2021 22:48:03 -0700 Randy Dunlap <rdunlap@infradead.org> wrote: > > on i386: > > ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3f0): undefined reference to `msm_hdmi_phy_8996_cfg' > > > Full randconfig fle is attached. This would be because CONFIG_DRM_MSM is set but CONFIG_COMMON_CLOCK is not and has been exposed by commit b3ed524f84f5 ("drm/msm: allow compile_test on !ARM") from the drm-misc tree. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: mmotm 2021-10-05-19-53 uploaded (drivers/gpu/drm/msm/hdmi/hdmi_phy.o) 2021-10-06 7:20 ` Stephen Rothwell @ 2021-10-06 7:24 ` Christian König 2021-10-06 18:05 ` Randy Dunlap 2021-10-07 9:28 ` Geert Uytterhoeven 0 siblings, 2 replies; 7+ messages in thread From: Christian König @ 2021-10-06 7:24 UTC (permalink / raw) To: Stephen Rothwell, Randy Dunlap Cc: akpm, broonie, linux-fsdevel, linux-kernel, linux-mm, linux-next, mhocko, mm-commits, Rob Clark, Sean Paul, linux-arm-msm, freedreno, Daniel Vetter, Intel Graphics, DRI Am 06.10.21 um 09:20 schrieb Stephen Rothwell: > Hi Randy, > > On Tue, 5 Oct 2021 22:48:03 -0700 Randy Dunlap <rdunlap@infradead.org> wrote: >> on i386: >> >> ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3f0): undefined reference to `msm_hdmi_phy_8996_cfg' >> >> >> Full randconfig fle is attached. > This would be because CONFIG_DRM_MSM is set but CONFIG_COMMON_CLOCK is > not and has been exposed by commit > > b3ed524f84f5 ("drm/msm: allow compile_test on !ARM") > > from the drm-misc tree. Good point, how about this change: diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig index 5879f67bc88c..d9879b011fb0 100644 --- a/drivers/gpu/drm/msm/Kconfig +++ b/drivers/gpu/drm/msm/Kconfig @@ -5,7 +5,7 @@ config DRM_MSM depends on DRM depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST depends on IOMMU_SUPPORT - depends on (OF && COMMON_CLK) || COMPILE_TEST + depends on (OF || COMPILE_TEST) && COMMON_CLK depends on QCOM_OCMEM || QCOM_OCMEM=n depends on QCOM_LLCC || QCOM_LLCC=n depends on QCOM_COMMAND_DB || QCOM_COMMAND_DB=n Regards, Christian. ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: mmotm 2021-10-05-19-53 uploaded (drivers/gpu/drm/msm/hdmi/hdmi_phy.o) 2021-10-06 7:24 ` Christian König @ 2021-10-06 18:05 ` Randy Dunlap 2021-10-07 9:28 ` Geert Uytterhoeven 1 sibling, 0 replies; 7+ messages in thread From: Randy Dunlap @ 2021-10-06 18:05 UTC (permalink / raw) To: Christian König, Stephen Rothwell Cc: akpm, broonie, linux-fsdevel, linux-kernel, linux-mm, linux-next, mhocko, mm-commits, Rob Clark, Sean Paul, linux-arm-msm, freedreno, Daniel Vetter, Intel Graphics, DRI On 10/6/21 12:24 AM, Christian König wrote: > > > Am 06.10.21 um 09:20 schrieb Stephen Rothwell: >> Hi Randy, >> >> On Tue, 5 Oct 2021 22:48:03 -0700 Randy Dunlap <rdunlap@infradead.org> wrote: >>> on i386: >>> >>> ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3f0): undefined reference to `msm_hdmi_phy_8996_cfg' >>> >>> >>> Full randconfig fle is attached. >> This would be because CONFIG_DRM_MSM is set but CONFIG_COMMON_CLOCK is >> not and has been exposed by commit >> >> b3ed524f84f5 ("drm/msm: allow compile_test on !ARM") >> >> from the drm-misc tree. > > Good point, how about this change: > > diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig > index 5879f67bc88c..d9879b011fb0 100644 > --- a/drivers/gpu/drm/msm/Kconfig > +++ b/drivers/gpu/drm/msm/Kconfig > @@ -5,7 +5,7 @@ config DRM_MSM > depends on DRM > depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST > depends on IOMMU_SUPPORT > - depends on (OF && COMMON_CLK) || COMPILE_TEST > + depends on (OF || COMPILE_TEST) && COMMON_CLK > depends on QCOM_OCMEM || QCOM_OCMEM=n > depends on QCOM_LLCC || QCOM_LLCC=n > depends on QCOM_COMMAND_DB || QCOM_COMMAND_DB=n WorksForMe. Thanks. (other than the whitespace damage) -- ~Randy ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: mmotm 2021-10-05-19-53 uploaded (drivers/gpu/drm/msm/hdmi/hdmi_phy.o) 2021-10-06 7:24 ` Christian König 2021-10-06 18:05 ` Randy Dunlap @ 2021-10-07 9:28 ` Geert Uytterhoeven 2021-10-13 10:54 ` Arnd Bergmann 1 sibling, 1 reply; 7+ messages in thread From: Geert Uytterhoeven @ 2021-10-07 9:28 UTC (permalink / raw) To: Christian König Cc: Stephen Rothwell, Randy Dunlap, Andrew Morton, Mark Brown, Linux FS Devel, Linux Kernel Mailing List, Linux MM, Linux-Next, Michal Hocko, mm-commits, Rob Clark, Sean Paul, linux-arm-msm, freedreno, Daniel Vetter, Intel Graphics, DRI Hi Christian, On Wed, Oct 6, 2021 at 9:28 AM Christian König <christian.koenig@amd.com> wrote: > Am 06.10.21 um 09:20 schrieb Stephen Rothwell: > > On Tue, 5 Oct 2021 22:48:03 -0700 Randy Dunlap <rdunlap@infradead.org> wrote: > >> on i386: > >> > >> ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3f0): undefined reference to `msm_hdmi_phy_8996_cfg' > >> > >> > >> Full randconfig fle is attached. > > This would be because CONFIG_DRM_MSM is set but CONFIG_COMMON_CLOCK is > > not and has been exposed by commit > > > > b3ed524f84f5 ("drm/msm: allow compile_test on !ARM") > > > > from the drm-misc tree. > > Good point, how about this change: > > diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig > index 5879f67bc88c..d9879b011fb0 100644 > --- a/drivers/gpu/drm/msm/Kconfig > +++ b/drivers/gpu/drm/msm/Kconfig > @@ -5,7 +5,7 @@ config DRM_MSM > depends on DRM > depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST > depends on IOMMU_SUPPORT > - depends on (OF && COMMON_CLK) || COMPILE_TEST > + depends on (OF || COMPILE_TEST) && COMMON_CLK I'd make that: - depends on DRM + depends on COMMON_CLK && DRM && IOMMU_SUPPORT depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST - depends on IOMMU_SUPPORT - depends on (OF && COMMON_CLK) || COMPILE_TEST + depends on OF || COMPILE_TEST to keep a better separation between hard and soft dependencies. Note that the "depends on OF || COMPILE_TEST" can even be deleted, as the dependency on ARCH_QCOM || SOC_IMX5 implies OF. > depends on QCOM_OCMEM || QCOM_OCMEM=n > depends on QCOM_LLCC || QCOM_LLCC=n > depends on QCOM_COMMAND_DB || QCOM_COMMAND_DB=n > Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: mmotm 2021-10-05-19-53 uploaded (drivers/gpu/drm/msm/hdmi/hdmi_phy.o) 2021-10-07 9:28 ` Geert Uytterhoeven @ 2021-10-13 10:54 ` Arnd Bergmann 2021-10-13 11:48 ` Arnd Bergmann 0 siblings, 1 reply; 7+ messages in thread From: Arnd Bergmann @ 2021-10-13 10:54 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Christian König, Stephen Rothwell, Randy Dunlap, Andrew Morton, Mark Brown, Linux FS Devel, Linux Kernel Mailing List, Linux MM, Linux-Next, Michal Hocko, mm-commits, Rob Clark, Sean Paul, linux-arm-msm, freedreno, Daniel Vetter, Intel Graphics, DRI On Thu, Oct 7, 2021 at 11:51 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Wed, Oct 6, 2021 at 9:28 AM Christian König <christian.koenig@amd.com> wrote: > > Am 06.10.21 um 09:20 schrieb Stephen Rothwell: > > > On Tue, 5 Oct 2021 22:48:03 -0700 Randy Dunlap <rdunlap@infradead.org> wrote: > > >> on i386: > > >> > > >> ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3f0): undefined reference to `msm_hdmi_phy_8996_cfg' I ran into the same thing now as well. E_TEST) && COMMON_CLK > > I'd make that: > > - depends on DRM > + depends on COMMON_CLK && DRM && IOMMU_SUPPORT > depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST > - depends on IOMMU_SUPPORT > - depends on (OF && COMMON_CLK) || COMPILE_TEST > + depends on OF || COMPILE_TEST > > to keep a better separation between hard and soft dependencies. > > Note that the "depends on OF || COMPILE_TEST" can even be > deleted, as the dependency on ARCH_QCOM || SOC_IMX5 implies OF. Looks good to me, I would also drop that last line in this case, and maybe add this change as building without COMMON_CLK is no longer possible: diff --git a/drivers/gpu/drm/msm/Makefile b/drivers/gpu/drm/msm/Makefile index 904535eda0c4..a5d87e03812f 100644 --- a/drivers/gpu/drm/msm/Makefile +++ b/drivers/gpu/drm/msm/Makefile @@ -116,10 +116,10 @@ msm-$(CONFIG_DRM_MSM_DP)+= dp/dp_aux.o \ dp/dp_power.o \ dp/dp_audio.o -msm-$(CONFIG_DRM_FBDEV_EMULATION) += msm_fbdev.o -msm-$(CONFIG_COMMON_CLK) += disp/mdp4/mdp4_lvds_pll.o -msm-$(CONFIG_COMMON_CLK) += hdmi/hdmi_pll_8960.o -msm-$(CONFIG_COMMON_CLK) += hdmi/hdmi_phy_8996.o +msm-$(CONFIG_DRM_FBDEV_EMULATION) += msm_fbdev.o \ + disp/mdp4/mdp4_lvds_pll.o \ + hdmi/hdmi_pll_8960.o \ + hdmi/hdmi_phy_8996.o msm-$(CONFIG_DRM_MSM_HDMI_HDCP) += hdmi/hdmi_hdcp.o Has anyone submitted a patch already, or should I send the version that I am using locally now? Arnd ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: mmotm 2021-10-05-19-53 uploaded (drivers/gpu/drm/msm/hdmi/hdmi_phy.o) 2021-10-13 10:54 ` Arnd Bergmann @ 2021-10-13 11:48 ` Arnd Bergmann 0 siblings, 0 replies; 7+ messages in thread From: Arnd Bergmann @ 2021-10-13 11:48 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Christian König, Stephen Rothwell, Randy Dunlap, Andrew Morton, Mark Brown, Linux FS Devel, Linux Kernel Mailing List, Linux MM, Linux-Next, Michal Hocko, mm-commits, Rob Clark, Sean Paul, linux-arm-msm, freedreno, Daniel Vetter, Intel Graphics, DRI On Wed, Oct 13, 2021 at 12:54 PM Arnd Bergmann <arnd@kernel.org> wrote: > On Thu, Oct 7, 2021 at 11:51 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > -msm-$(CONFIG_DRM_FBDEV_EMULATION) += msm_fbdev.o > -msm-$(CONFIG_COMMON_CLK) += disp/mdp4/mdp4_lvds_pll.o > -msm-$(CONFIG_COMMON_CLK) += hdmi/hdmi_pll_8960.o > -msm-$(CONFIG_COMMON_CLK) += hdmi/hdmi_phy_8996.o > +msm-$(CONFIG_DRM_FBDEV_EMULATION) += msm_fbdev.o \ > + disp/mdp4/mdp4_lvds_pll.o \ > + hdmi/hdmi_pll_8960.o \ > + hdmi/hdmi_phy_8996.o > > msm-$(CONFIG_DRM_MSM_HDMI_HDCP) += hdmi/hdmi_hdcp.o I fixed my local copy now after noticing that these should not go after CONFIG_DRM_FBDEV_EMULATION but the top-level option: @@ -23,8 +23,10 @@ msm-y := \ hdmi/hdmi_i2c.o \ hdmi/hdmi_phy.o \ hdmi/hdmi_phy_8960.o \ + hdmi/hdmi_phy_8996.o hdmi/hdmi_phy_8x60.o \ hdmi/hdmi_phy_8x74.o \ + hdmi/hdmi_pll_8960.o \ edp/edp.o \ edp/edp_aux.o \ edp/edp_bridge.o \ @@ -37,6 +39,7 @@ msm-y := \ disp/mdp4/mdp4_dtv_encoder.o \ disp/mdp4/mdp4_lcdc_encoder.o \ disp/mdp4/mdp4_lvds_connector.o \ + disp/mdp4/mdp4_lvds_pll.o \ disp/mdp4/mdp4_irq.o \ disp/mdp4/mdp4_kms.o \ disp/mdp4/mdp4_plane.o \ Arnd ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-10-13 11:49 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20211006025350.a5PczFZP4%akpm@linux-foundation.org>
2021-10-06 5:48 ` mmotm 2021-10-05-19-53 uploaded (drivers/gpu/drm/msm/hdmi/hdmi_phy.o) Randy Dunlap
2021-10-06 7:20 ` Stephen Rothwell
2021-10-06 7:24 ` Christian König
2021-10-06 18:05 ` Randy Dunlap
2021-10-07 9:28 ` Geert Uytterhoeven
2021-10-13 10:54 ` Arnd Bergmann
2021-10-13 11:48 ` Arnd Bergmann
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).