From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFF1EC433EF for ; Wed, 6 Oct 2021 18:24:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9346761151 for ; Wed, 6 Oct 2021 18:24:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233080AbhJFS0R (ORCPT ); Wed, 6 Oct 2021 14:26:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231624AbhJFS0R (ORCPT ); Wed, 6 Oct 2021 14:26:17 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E98E8C061755 for ; Wed, 6 Oct 2021 11:24:24 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id nn3-20020a17090b38c300b001a03bb6c4ebso600874pjb.1 for ; Wed, 06 Oct 2021 11:24:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7H/DPJoWMp11tmUoPKSZMQxmcZJGqCLHjQqOxlkRT3I=; b=JG/yky1tdDSKqvCvLBDptJd6qpCbJk/pCGNJdvJqZCaNkuwtgO8Qcc53jj4oEh+bVI Y3SkLqQq4cKC7q0QZpPuNzG+M8X2j8l/IFom9760x7KzzcvF2WYleCx8dF9vUIRUKYPD Pr00IFbquO++J1KP3uf96wTDf/XVEBiQqfLMunzqSkZ4oTOG3WTf+hv7vjGVVS6lfUTJ 9N3531JVgATjf1E0x/bax8PmJliIbHkS5ieVenjBOxeQ73K4lyErXAf3uYE55NIf0Iag rs6Zs3Q2CD4weHPYYUkfnRVShQk8XkXeoGF0+ItEnTyWNzxm7G4mtp+l81P69cjNXMPB 4WeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7H/DPJoWMp11tmUoPKSZMQxmcZJGqCLHjQqOxlkRT3I=; b=vTGuswx1evMjS5imzdewpCnZ8Sl/uTzG/tdIUcEg+8g4A/+nsDvew+noLAiMYuL2ao fBCIIfW4vW6UpEXpa9Nd6MuqKFNwK6VBFBg/sx8vBiDRz8IhLdevkJvYFKrvPfaX9Fv4 mxp3akUQ80Q5W9HFvG41EnRh47GGegljPfMSFyqvZQIHPeUSm4yL9CQLMAUxemhSs/NC iMlDFTNUZDvjhNdaHdkl5e151ehGX4YCraz5IkhajsE4OmlKkZWAsf7Rl1Id9zmQCrGf mP/hKyTGlAOgX7HZjMOCfqEglvF/lhL+cbwlIIk7SVIBytOAEpBUm2i4o/M/vCxl/Bm3 4/Tg== X-Gm-Message-State: AOAM53181uLKfAJoIixp13ktj+/o0ls0zMoeFD0MzEaR1wW0Nnnz1tKr cQrvRVLTEt3Ao3dZXpvtWK57l5q9Xd+t X-Google-Smtp-Source: ABdhPJysFUYu3grPoRZB/ukVEQ0LvQQELodUHWFXUGYINOwkWLYtdIvPWLtAW0ZjczNSHWD6nINBDA== X-Received: by 2002:a17:90b:946:: with SMTP id dw6mr248431pjb.49.1633544664308; Wed, 06 Oct 2021 11:24:24 -0700 (PDT) Received: from thinkpad ([117.202.189.72]) by smtp.gmail.com with ESMTPSA id u74sm12366435pfc.87.2021.10.06.11.24.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Oct 2021 11:24:23 -0700 (PDT) Date: Wed, 6 Oct 2021 23:54:19 +0530 From: Manivannan Sadhasivam To: Bjorn Andersson Cc: Robert Marko , Kathiravan T , agross@kernel.org, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, open list Subject: Re: [PATCH] arm64: dts: qcom: ipq8074: add SMEM support Message-ID: <20211006182419.GC33862@thinkpad> References: <20210902214708.1776690-1-robimarko@gmail.com> <632a7d28c23a8497d35ea009bfe89883@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Sep 22, 2021 at 05:18:16PM -0500, Bjorn Andersson wrote: > On Wed 22 Sep 15:23 CDT 2021, Robert Marko wrote: > > > On Tue, 21 Sept 2021 at 08:24, Kathiravan T wrote: > > > > > > On 2021-09-20 14:55, Robert Marko wrote: > > > > On Mon, 20 Sept 2021 at 04:52, Bjorn Andersson > > > > wrote: > > > >> > > > >> On Thu 02 Sep 16:47 CDT 2021, Robert Marko wrote: > > > >> > > > >> > IPQ8074 uses SMEM like other modern QCA SoC-s, so since its already > > > >> > supported by the kernel add the required DT nodes. > > > >> > > > > >> > Signed-off-by: Robert Marko > > > >> > > > >> Thanks for your patch Robert. > > > >> > > > >> > --- > > > >> > arch/arm64/boot/dts/qcom/ipq8074.dtsi | 28 +++++++++++++++++++++++++++ > > > >> > 1 file changed, 28 insertions(+) > > > >> > > > > >> > diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi > > > >> > index a620ac0d0b19..83e9243046aa 100644 > > > >> > --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi > > > >> > +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi > > > >> > @@ -82,6 +82,29 @@ scm { > > > >> > }; > > > >> > }; > > > >> > > > > >> > + reserved-memory { > > > >> > + #address-cells = <2>; > > > >> > + #size-cells = <2>; > > > >> > + ranges; > > > >> > + > > > >> > + smem_region: memory@4ab00000 { > > > >> > + no-map; > > > >> > + reg = <0x0 0x4ab00000 0x0 0x00100000>; > > > >> > + }; > > > >> > + }; > > > >> > + > > > >> > + tcsr_mutex: hwlock { > > > >> > + compatible = "qcom,tcsr-mutex"; > > > >> > + syscon = <&tcsr_mutex_regs 0 0x80>; > > > >> > > > >> Since it's not okay to have a lone "syscon" and I didn't think it was > > > >> worth coming up with a binding for the TCSR mutex "syscon" I rewrote > > > >> the > > > >> binding a while back. As such qcom,tcsr-mutex should now live in /soc > > > >> directly. > > > >> > > > >> So can you please respin accordingly? > > > > > > > > Sure, can you just confirm that the: > > > > reg = <0x01905000 0x8000>; > > > > > > > > Is the whole TCSR range as I don't have docs? > > > > > > Robert, > > > > > > TCSR_MUTEX block starts from 0x01905000 and has size 0x20000 (128KB) > > > > Thanks, Kathiravan, > > TSCR mutex with MMIO reg under it works, but there is some weird probe > > ordering issue. > > > > For whatever reason, SMEM will get probed only after MTD does and this > > will cause issues > > if SMEM parser is used as it will return -EPROBE_DEFER but the MTD > > core does not really > > handle it correctly and causes the device to reboot after failed parsing. > > > > Now, I have no idea why does this variant which uses MMIO regmap probe > > so much later? > > > > Mani, do you have any input related to the probe deferral of the SMEM > partition parser, because SMEM not yet probed? > Sorry, missed this earlier. I did face the probe deferral issue before and submitted a small series for fixing that: https://lore.kernel.org/linux-mtd/20210302132757.225395-1-manivannan.sadhasivam@linaro.org/ These 2 patches are in mainline now. Robert, can you make sure that you have these 2 patches in your tree? Thanks, Mani > Thanks, > Bjorn