Re: [PATCH] drm/msm/dp: Use the connector passed to dp_debug_get()

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3260 bytes --]

Hi Bjorn,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.15-rc5 next-20211013]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Bjorn-Andersson/drm-msm-dp-Use-the-connector-passed-to-dp_debug_get/20211010-110400
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 7fd2bf83d59a2d32e0d596c5d3e623b9a0e7e2d5
config: arm-qcom_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/e591869849ae9c71d7db25e6b0df588a31ca76cf
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Bjorn-Andersson/drm-msm-dp-Use-the-connector-passed-to-dp_debug_get/20211010-110400
        git checkout e591869849ae9c71d7db25e6b0df588a31ca76cf
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/msm/dp/dp_display.c: In function 'msm_dp_debugfs_init':
>> drivers/gpu/drm/msm/dp/dp_display.c:1432:65: error: passing argument 5 of 'dp_debug_get' from incompatible pointer type [-Werror=incompatible-pointer-types]
    1432 |                                         dp->link, dp->dp_display.connector,
         |                                                   ~~~~~~~~~~~~~~^~~~~~~~~~
         |                                                                 |
         |                                                                 struct drm_connector *
   In file included from drivers/gpu/drm/msm/dp/dp_display.c:28:
   drivers/gpu/drm/msm/dp/dp_debug.h:63:40: note: expected 'struct drm_connector **' but argument is of type 'struct drm_connector *'
      63 |                 struct drm_connector **connector, struct drm_minor *minor)
         |                 ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
   cc1: some warnings being treated as errors


vim +/dp_debug_get +1432 drivers/gpu/drm/msm/dp/dp_display.c

  1421	
  1422	void msm_dp_debugfs_init(struct msm_dp *dp_display, struct drm_minor *minor)
  1423	{
  1424		struct dp_display_private *dp;
  1425		struct device *dev;
  1426		int rc;
  1427	
  1428		dp = container_of(dp_display, struct dp_display_private, dp_display);
  1429		dev = &dp->pdev->dev;
  1430	
  1431		dp->debug = dp_debug_get(dev, dp->panel, dp->usbpd,
> 1432						dp->link, dp->dp_display.connector,
  1433						minor);
  1434		if (IS_ERR(dp->debug)) {
  1435			rc = PTR_ERR(dp->debug);
  1436			DRM_ERROR("failed to initialize debug, rc = %d\n", rc);
  1437			dp->debug = NULL;
  1438		}
  1439	}
  1440	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 39904 bytes --]