From: Maxime Ripard <maxime@cerno.tech>
To: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Maxime Ripard <maxime@cerno.tech>,
Sam Ravnborg <sam@ravnborg.org>,
Daniel Vetter <daniel.vetter@intel.com>,
David Airlie <airlied@linux.ie>,
Thierry Reding <thierry.reding@gmail.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Robert Foss <robert.foss@linaro.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>,
Xinliang Liu <xinliang.liu@linaro.org>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Tian Tao <tiantao6@hisilicon.com>,
freedreno@lists.freedesktop.org,
Chen Feng <puck.chen@hisilicon.com>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
John Stultz <john.stultz@linaro.org>,
Rob Clark <robdclark@gmail.com>,
linux-arm-msm@vger.kernel.org, Sean Paul <sean@poorly.run>,
Inki Dae <inki.dae@samsung.com>,
Xinwei Kong <kong.kongxinwei@hisilicon.com>,
dri-devel@lists.freedesktop.org, Marek Vasut <marex@denx.de>
Subject: [PATCH v5 13/21] drm/bridge: sn65dsi83: Fix bridge removal
Date: Thu, 21 Oct 2021 09:39:39 +0200 [thread overview]
Message-ID: <20211021073947.499373-14-maxime@cerno.tech> (raw)
In-Reply-To: <20211021073947.499373-1-maxime@cerno.tech>
Commit 24417d5b0c00 ("drm/bridge: ti-sn65dsi83: Implement .detach
callback") moved the unregistration of the bridge DSI device and bridge
itself to the detach callback.
While this is correct for the DSI device detach and unregistration, the
bridge is added in the driver probe, and should thus be removed as part
of its remove callback.
Cc: Marek Vasut <marex@denx.de>
Fixes: 24417d5b0c00 ("drm/bridge: ti-sn65dsi83: Implement .detach callback")
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
index 52030a82f3e1..3bfd07caf8d7 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
@@ -297,7 +297,6 @@ static void sn65dsi83_detach(struct drm_bridge *bridge)
mipi_dsi_detach(ctx->dsi);
mipi_dsi_device_unregister(ctx->dsi);
- drm_bridge_remove(&ctx->bridge);
ctx->dsi = NULL;
}
@@ -693,6 +692,7 @@ static int sn65dsi83_remove(struct i2c_client *client)
{
struct sn65dsi83 *ctx = i2c_get_clientdata(client);
+ drm_bridge_remove(&ctx->bridge);
of_node_put(ctx->host_node);
return 0;
--
2.31.1
next prev parent reply other threads:[~2021-10-21 7:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 7:39 [PATCH v5 00/21] drm/bridge: Make panel and bridge probe order consistent Maxime Ripard
2021-10-21 7:39 ` [PATCH v5 01/21] drm/bridge: adv7533: Switch to devm MIPI-DSI helpers Maxime Ripard
2021-10-21 7:39 ` [PATCH v5 02/21] drm/bridge: adv7511: Register and attach our DSI device at probe Maxime Ripard
2021-10-21 7:39 ` [PATCH v5 03/21] drm/bridge: anx7625: Switch to devm MIPI-DSI helpers Maxime Ripard
2021-10-21 7:39 ` [PATCH v5 04/21] drm/bridge: anx7625: Register and attach our DSI device at probe Maxime Ripard
2021-10-21 7:39 ` [PATCH v5 05/21] drm/bridge: lt8912b: Switch to devm MIPI-DSI helpers Maxime Ripard
2021-10-21 7:39 ` [PATCH v5 06/21] drm/bridge: lt8912b: Register and attach our DSI device at probe Maxime Ripard
2021-10-21 7:39 ` [PATCH v5 07/21] drm/bridge: lt9611: Switch to devm MIPI-DSI helpers Maxime Ripard
2021-10-21 7:39 ` [PATCH v5 08/21] drm/bridge: lt9611: Register and attach our DSI device at probe Maxime Ripard
2021-10-21 7:39 ` [PATCH v5 09/21] drm/bridge: lt9611uxc: Switch to devm MIPI-DSI helpers Maxime Ripard
2021-10-21 7:39 ` [PATCH v5 10/21] drm/bridge: lt9611uxc: Register and attach our DSI device at probe Maxime Ripard
2021-10-21 7:39 ` [PATCH v5 11/21] drm/bridge: ps8640: Switch to devm MIPI-DSI helpers Maxime Ripard
2021-10-21 7:39 ` [PATCH v5 12/21] drm/bridge: ps8640: Register and attach our DSI device at probe Maxime Ripard
2021-10-21 7:39 ` Maxime Ripard [this message]
2021-10-22 20:02 ` [PATCH v5 13/21] drm/bridge: sn65dsi83: Fix bridge removal Marek Vasut
2021-10-21 7:39 ` [PATCH v5 14/21] drm/bridge: sn65dsi83: Switch to devm MIPI-DSI helpers Maxime Ripard
2021-10-21 7:39 ` [PATCH v5 15/21] drm/bridge: sn65dsi83: Register and attach our DSI device at probe Maxime Ripard
2021-10-21 7:39 ` [PATCH v5 16/21] drm/bridge: sn65dsi86: Switch to devm MIPI-DSI helpers Maxime Ripard
2021-10-21 7:39 ` [PATCH v5 17/21] drm/bridge: sn65dsi86: Register and attach our DSI device at probe Maxime Ripard
2021-10-21 7:39 ` [PATCH v5 18/21] drm/bridge: tc358775: Switch to devm MIPI-DSI helpers Maxime Ripard
2021-10-21 7:39 ` [PATCH v5 19/21] drm/bridge: tc358775: Register and attach our DSI device at probe Maxime Ripard
2021-10-21 7:39 ` [PATCH v5 20/21] drm/kirin: dsi: Adjust probe order Maxime Ripard
2021-10-21 7:39 ` [PATCH v5 21/21] drm/msm/dsi: " Maxime Ripard
2021-10-21 16:30 ` Rob Clark
[not found] ` <YXGFz4o5fWrfGnGk@ravnborg.org>
2021-10-25 15:16 ` [PATCH v5 00/21] drm/bridge: Make panel and bridge probe order consistent Maxime Ripard
[not found] ` <YXbhSjsPXk944TlF@ravnborg.org>
2021-10-27 8:42 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211021073947.499373-14-maxime@cerno.tech \
--to=maxime@cerno.tech \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=jernej.skrabec@gmail.com \
--cc=john.stultz@linaro.org \
--cc=jonas@kwiboo.se \
--cc=jy0922.shim@samsung.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marex@denx.de \
--cc=narmstrong@baylibre.com \
--cc=puck.chen@hisilicon.com \
--cc=robdclark@gmail.com \
--cc=robert.foss@linaro.org \
--cc=sam@ravnborg.org \
--cc=sean@poorly.run \
--cc=sw0312.kim@samsung.com \
--cc=thierry.reding@gmail.com \
--cc=tiantao6@hisilicon.com \
--cc=tzimmermann@suse.de \
--cc=xinliang.liu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox