From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-arm-msm-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 5EE75C433FE
	for <linux-arm-msm@archiver.kernel.org>; Tue,  2 Nov 2021 16:37:52 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 43F5561101
	for <linux-arm-msm@archiver.kernel.org>; Tue,  2 Nov 2021 16:37:52 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S235009AbhKBQk0 (ORCPT
        <rfc822;linux-arm-msm@archiver.kernel.org>);
        Tue, 2 Nov 2021 12:40:26 -0400
Received: from mail.kernel.org ([198.145.29.99]:42220 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S234721AbhKBQji (ORCPT <rfc822;linux-arm-msm@vger.kernel.org>);
        Tue, 2 Nov 2021 12:39:38 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id 1E25B60C51;
        Tue,  2 Nov 2021 16:23:03 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1635870187;
        bh=Evlcj6vaDsDQQaLhhkwTLELLNb1RMhiSuyLp1JWidjo=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=jnAjLhrhG/T92ju0AEGRuH4Ty0kV9pfpdSIx2TsJHdTbzWTR3R2U5x9ZS+XxTlsrg
         3dFaLC4rZYa2ZLwy7hLECgtZFtzeyUc6BKzO+2PYkno0052e7xfh6prNdOc6v7PHGv
         eZgkdNUwBrCxH6X8eoBoCv1lyVwU+xA0ZuKbm5TlfSEC+ACJhSaGDvV5ARUsrsqVOY
         zDqRPIIeG/ZQZUw2kVFgCofL8Bq8yk34OLGMEeS5R63P3K+dy56LJwIgSTHANnzy0M
         pJsHAj1fRyXCeDL5S5TOxhTWHp5/ecUIDmAm6o2IohaU/NN8jlKHBpcSDyR/We00YF
         4h/rCQCi5+8pw==
Date:   Tue, 2 Nov 2021 21:52:59 +0530
From:   Manivannan Sadhasivam <mani@kernel.org>
To:     Aleksander Morgado <aleksander@aleksander.es>
Cc:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        Loic Poulain <loic.poulain@linaro.org>,
        Thomas Perrot <thomas.perrot@bootlin.com>,
        Hemant Kumar <hemantk@codeaurora.org>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        Bhaumik Bhatt <bbhatt@codeaurora.org>
Subject: Re: Sierra Wireless EM9191 integration issues in mhi+wwan
Message-ID: <20211102162259.GC5646@thinkpad>
References: <CAAP7ucLJYfftfCuKxnW8Q7-duyEuGgHA5gk+h2JyyAzNq75QSA@mail.gmail.com>
 <20211009105132.GA204538@thinkpad>
 <CAAP7uc+kPCyASq1ki_qZdft7W9rJxnx4-4TmhRJjMDQuQAHsFA@mail.gmail.com>
 <20211022044229.GD3138@workstation>
 <CAAP7ucJrj1HSvqeoXGOc3F2_z2tv5ZgTTexmX8xr57La=_H4ow@mail.gmail.com>
 <20211022144026.GA7657@thinkpad>
 <CAAP7ucJGkAKqyvUJJnCgX8AejsHSaY0AeAxKoCJahAeVLw5ThQ@mail.gmail.com>
 <20211102105035.GB5646@thinkpad>
 <CAAP7ucLVtOR7+NJiWK_is0yv+zWKB9vmxpy4PyO5FQdVUE6uzA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAAP7ucLVtOR7+NJiWK_is0yv+zWKB9vmxpy4PyO5FQdVUE6uzA@mail.gmail.com>
Precedence: bulk
List-ID: <linux-arm-msm.vger.kernel.org>
X-Mailing-List: linux-arm-msm@vger.kernel.org

On Tue, Nov 02, 2021 at 05:13:58PM +0100, Aleksander Morgado wrote:
> Hey Mani,
> 
> > > [    7.189547] mhi mhi0: Transitioning from PM state: Linkdown or
> > > Error Fatal Detect to: SYS ERROR Process
> >
> > Hmm, I think the use of sync_power_up might be causing the issue here as it
> > forces the MHI state to fatal error.
> >
> > Ignore the previous diff and try the below one:
> >
> > diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> > index 59a4896a8030..b1e8c7de4e54 100644
> > --- a/drivers/bus/mhi/pci_generic.c
> > +++ b/drivers/bus/mhi/pci_generic.c
> > @@ -637,7 +637,7 @@ static void mhi_pci_recovery_work(struct work_struct *work)
> >         if (err)
> >                 goto err_try_reset;
> >
> > -       err = mhi_sync_power_up(mhi_cntrl);
> > +       err = mhi_async_power_up(mhi_cntrl);

Doh! Sorry, I modified the wrong function. Here is the correct one:

diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
index 59a4896a8030..1e3c74bfbe34 100644
--- a/drivers/bus/mhi/pci_generic.c
+++ b/drivers/bus/mhi/pci_generic.c
@@ -743,7 +743,7 @@ static int mhi_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
                goto err_unregister;
        }
 
-       err = mhi_sync_power_up(mhi_cntrl);
+       err = mhi_async_power_up(mhi_cntrl);
        if (err) {
                dev_err(&pdev->dev, "failed to power up MHI controller\n");
                goto err_unprepare;

Let's see how it goes :)

Thanks,
Mani