From: Bjorn Helgaas <helgaas@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: lorenzo.pieralisi@arm.com, bhelgaas@google.com,
svarbanov@mm-sol.com, bjorn.andersson@linaro.org,
robh@kernel.org, linux-pci@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>, Marc Zyngier <maz@kernel.org>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Sven Peter <sven@svenpeter.dev>
Subject: Re: [PATCH] PCI: qcom: Fix warning generated due to the incorrect data type
Date: Tue, 30 Nov 2021 10:03:38 -0600 [thread overview]
Message-ID: <20211130160338.GA2739234@bhelgaas> (raw)
In-Reply-To: <20211130062137.GD205712@thinkpad>
[+cc Marc, Alyssa, Sven for RID-to-SID mapping insight. The patch at
https://lore.kernel.org/all/20211130062137.GD205712@thinkpad/ merely
fixes a warning. My meta-question is about the qcom BDF-to-SID
mapping.]
On Tue, Nov 30, 2021 at 11:51:37AM +0530, Manivannan Sadhasivam wrote:
> On Mon, Nov 29, 2021 at 09:36:14PM -0600, Bjorn Helgaas wrote:
> > ...
> > I'm also curious why pcie-qcom.c is the only driver that does this.
> > "iommu-map" is not specific to qcom, but no other drivers do similar
> > things with it.
>
> Yes, on the recent qcom platforms starting from sm8250 we need to program
> the BDF to SID mapping in the controller and that's the reason we are
> extracting the "iommu-map" property in DT.
This sounds like something that may not really be specific to sm8250.
It looks vaguely similar to apple_pcie_add_device(). Compare the qcom
code at [1] with the Apple code at [2].
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/controller/dwc/pcie-qcom.c?id=v5.16-rc1#n1308
[2] https://git.kernel.org/linus/468c8d52c332
> > > sparse warnings: (new ones prefixed by >>)
> > > >> drivers/pci/controller/dwc/pcie-qcom.c:1305:30: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned short [usertype] bdf_be @@ got restricted __be16 [usertype] @@
> > > drivers/pci/controller/dwc/pcie-qcom.c:1305:30: sparse: expected unsigned short [usertype] bdf_be
> > > drivers/pci/controller/dwc/pcie-qcom.c:1305:30: sparse: got restricted __be16 [usertype]
> > >
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > ---
> > > drivers/pci/controller/dwc/pcie-qcom.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
> > > index 8a7a300163e5..6c3b034e9946 100644
> > > --- a/drivers/pci/controller/dwc/pcie-qcom.c
> > > +++ b/drivers/pci/controller/dwc/pcie-qcom.c
> > > @@ -1312,7 +1312,7 @@ static int qcom_pcie_config_sid_sm8250(struct qcom_pcie *pcie)
> > >
> > > /* Look for an available entry to hold the mapping */
> > > for (i = 0; i < nr_map; i++) {
> > > - u16 bdf_be = cpu_to_be16(map[i].bdf);
> > > + __be16 bdf_be = cpu_to_be16(map[i].bdf);
> > > u32 val;
> > > u8 hash;
> > >
> > > --
> > > 2.25.1
> > >
next prev parent reply other threads:[~2021-11-30 16:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 14:04 [PATCH] PCI: qcom: Fix warning generated due to the incorrect data type Manivannan Sadhasivam
2021-11-30 3:36 ` Bjorn Helgaas
2021-11-30 6:21 ` Manivannan Sadhasivam
2021-11-30 16:03 ` Bjorn Helgaas [this message]
2021-11-30 16:35 ` Sven Peter
2021-11-30 18:35 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211130160338.GA2739234@bhelgaas \
--to=helgaas@kernel.org \
--cc=alyssa@rosenzweig.io \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=maz@kernel.org \
--cc=robh@kernel.org \
--cc=svarbanov@mm-sol.com \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox