From: Ameer Hamza <amhamza.mgc@gmail.com>
To: stanimir.varbanov@linaro.org, agross@kernel.org,
bjorn.andersson@linaro.org, mchehab@kernel.org
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, amhamza.mgc@gmail.com
Subject: [PATCH] media: venus: vdec: fixed possible memory leak issue
Date: Sat, 4 Dec 2021 17:11:23 +0500 [thread overview]
Message-ID: <20211204121123.22180-1-amhamza.mgc@gmail.com> (raw)
Fixed coverity warning by freeing the allocated memory before return
Addresses-Coverity: 1494120 ("Resource leak")
Signed-off-by: Ameer Hamza <amhamza.mgc@gmail.com>
---
drivers/media/platform/qcom/venus/helpers.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c
index 84c3a511ec31..344a42853898 100644
--- a/drivers/media/platform/qcom/venus/helpers.c
+++ b/drivers/media/platform/qcom/venus/helpers.c
@@ -197,6 +197,7 @@ int venus_helper_alloc_dpb_bufs(struct venus_inst *inst)
id = ida_alloc_min(&inst->dpb_ids, VB2_MAX_FRAME, GFP_KERNEL);
if (id < 0) {
+ kfree(buf);
ret = id;
goto fail;
}
--
2.25.1
next reply other threads:[~2021-12-04 12:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 12:11 Ameer Hamza [this message]
2021-12-04 20:29 ` [PATCH] media: venus: vdec: fixed possible memory leak issue Kieran Bingham
2021-12-04 20:55 ` [PATCH v2] " Ameer Hamza
2021-12-06 9:55 ` Kieran Bingham
2021-12-06 10:11 ` Kieran Bingham
2021-12-06 10:43 ` [PATCH v3] " Ameer Hamza
2021-12-06 11:32 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211204121123.22180-1-amhamza.mgc@gmail.com \
--to=amhamza.mgc@gmail.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox