From: Rob Clark <robdclark@gmail.com>
To: igt-dev@lists.freedesktop.org
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
linux-arm-msm@vger.kernel.org, Rob Clark <robdclark@chromium.org>
Subject: [PATCH igt 2/2] tools/msm_dp_compliance: Add arg to specify connector name
Date: Wed, 8 Dec 2021 11:22:16 -0800 [thread overview]
Message-ID: <20211208192216.743364-3-robdclark@gmail.com> (raw)
In-Reply-To: <20211208192216.743364-1-robdclark@gmail.com>
From: Rob Clark <robdclark@chromium.org>
To support multiple DP connectors, the debugfs files will be moving into
a per-connector subdirectory in debugfs. So add an arg to specify the
appropriate connector name.
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
tools/msm_dp_compliance.c | 19 +++++++++++++++----
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/tools/msm_dp_compliance.c b/tools/msm_dp_compliance.c
index a15a8dd9..bc79a061 100644
--- a/tools/msm_dp_compliance.c
+++ b/tools/msm_dp_compliance.c
@@ -205,10 +205,15 @@ static FILE *fopenat(int dir, const char *name, const char *mode)
return fdopen(fd, mode);
}
-static void setup_debugfs_files(void)
+static void setup_debugfs_files(const char *connector_name)
{
int dir = igt_debugfs_dir(drm_fd);
+ if (connector_name) {
+ dir = openat(dir, connector_name, O_RDONLY);
+ igt_require(dir >= 0);
+ }
+
test_type_fp = fopenat(dir, MSM_DP_TEST_TYPE_FILE, "r");
igt_require(test_type_fp);
@@ -624,11 +629,12 @@ int update_display(int mode, bool is_compliance_test)
return ret;
}
-static const char optstr[] = "hi";
+static const char optstr[] = "c:hi";
static void __attribute__((noreturn)) usage(char *name, char opt)
{
- igt_info("usage: %s [-hi]\n", name);
+ igt_info("usage: %s [-hi] [-c NAME]\n", name);
+ igt_info("\t-c, --connector=NAME - specify connector name");
igt_info("\t-h, --help - print this usage message");
igt_info("\t--help-description - print test description");
igt_info("\t-i, --info - dump info\n");
@@ -708,7 +714,9 @@ int main(int argc, char **argv)
GIOChannel *stdinchannel, *testactive_channel;
GMainLoop *mainloop;
bool opt_dump_info = false;
+ char *opt_connector_name = NULL;
struct option long_opts[] = {
+ {"connector", 1, 0, 'c'},
{"help-description", 0, 0, HELP_DESCRIPTION},
{"help", 0, 0, 'h'},
{"info", 0, 0, 'i'},
@@ -718,6 +726,9 @@ int main(int argc, char **argv)
while ((c = getopt_long(argc, argv, optstr, long_opts, NULL)) != -1) {
switch (c) {
+ case 'c':
+ opt_connector_name = optarg;
+ break;
case 'i':
opt_dump_info = true;
break;
@@ -739,7 +750,7 @@ int main(int argc, char **argv)
drm_fd = drm_open_driver(DRIVER_ANY);
kmstest_set_vt_graphics_mode();
- setup_debugfs_files();
+ setup_debugfs_files(opt_connector_name);
cleanup_test();
if (opt_dump_info) {
dump_info();
--
2.33.1
next prev parent reply other threads:[~2021-12-08 19:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 19:22 [PATCH igt 0/2] tools/msm_dp_compliance: Multi-connector support Rob Clark
2021-12-08 19:22 ` [PATCH igt 1/2] tools/msm_dp_compliance: Small arg parsing cleanup Rob Clark
2023-10-19 10:40 ` Abhinav Kumar
2023-10-24 8:17 ` [igt-dev] " Kamil Konieczny
2021-12-08 19:22 ` Rob Clark [this message]
2023-10-19 10:43 ` [PATCH igt 2/2] tools/msm_dp_compliance: Add arg to specify connector name Abhinav Kumar
2021-12-08 19:50 ` [PATCH igt 0/2] tools/msm_dp_compliance: Multi-connector support Abhinav Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211208192216.743364-3-robdclark@gmail.com \
--to=robdclark@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox