Re: [PATCH 03/11] clk: qcom: camcc-sc7180: get rid of the test clock

Marijn Suijten
2021-12-08T22:48:23Z

On 2021-12-08 20:54:22, Dmitry Baryshkov wrote:
> The test clock isn't in the bindings and apparently it's not used by
> anyone upstream. Remove it.
>
> Suggested-by: Stephen Boyd <swboyd@chromium.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/clk/qcom/camcc-sc7180.c | 65 +++++++++++++--------------------
> 1 file changed, 25 insertions(+), 40 deletions(-)
>
> diff --git a/drivers/clk/qcom/camcc-sc7180.c b/drivers/clk/qcom/camcc-sc7180.c
> index ce73ee9037cb..3c15e551419f 100644
> --- a/drivers/clk/qcom/camcc-sc7180.c
> +++ b/drivers/clk/qcom/camcc-sc7180.c
> [..]
> @@ -303,7 +288,7 @@ static struct clk_rcg2 cam_cc_bps_clk_src = {
> .clkr.hw.init = &(struct clk_init_data){
> .name = "cam_cc_bps_clk_src",
> .parent_data = cam_cc_parent_data_2,
> - .num_parents = 5,
> + .num_parents = ARRAY_SIZE(cam_cc_parent_data_2),

Perhaps it is more clear to perform this conversion in a separate patch,
before this patch that removes the test clock? Otherwise this
transition to ARRAY_SIZE should probably at least be mentioned in the
title and commit body.

- Marijn

> .ops = &clk_rcg2_shared_ops,
> },
> };
> [..]