From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 033C8C433F5 for ; Fri, 18 Feb 2022 00:14:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229948AbiBRAO5 (ORCPT ); Thu, 17 Feb 2022 19:14:57 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:38330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229579AbiBRAO5 (ORCPT ); Thu, 17 Feb 2022 19:14:57 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DC6338BC; Thu, 17 Feb 2022 16:14:42 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AA5B2B82437; Fri, 18 Feb 2022 00:14:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57B6FC340E8; Fri, 18 Feb 2022 00:14:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645143279; bh=TFTlQQPzGmti7KVApu8+s08urpdqXAPiRc7Dxb9Wqsg=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=tl6VFUE99l05i2vQmdbhEq7Fn1VSl12cry4ydmqQDHqatI3GduWyojNGOkzdWJZa9 YYfuL4JiWDRrZSsomv/+7cedOxoG5lcoeTdDfCzL0Q7onjUP6L2NG0f+xJxxLYQyMF K1+TR6EaGgydXDWTF91Koty5Qfop+2R9H/mdRR4AbAHsqp4c6xvCAfgFi4+bhjDJNn vvXJ9oibZ3ZvXoQYLWS1rJAwR9QX8+lrfVPElt1/NzbAvJeEHdHhwoL/VO5cpyj5m0 ESrXeq7Hislp0cT+PEa1Dn/JmstiD3Y/7TpPtTRk/+lF4v4RnoIt+4rLEqk4v//+Sv Ww7/JyyPFlvpQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220210173100.505128-1-robimarko@gmail.com> References: <20220210173100.505128-1-robimarko@gmail.com> Subject: Re: [PATCH] clk: qcom: ipq8074: Use floor ops for SDCC1 clock From: Stephen Boyd Cc: Dirk Buchwalder , Robert Marko To: Robert Marko , absahu@codeaurora.org, agross@kernel.org, bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, mturquette@baylibre.com Date: Thu, 17 Feb 2022 16:14:36 -0800 User-Agent: alot/0.10 Message-Id: <20220218001439.57B6FC340E8@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Robert Marko (2022-02-10 09:31:00) > From: Dirk Buchwalder >=20 > Use floor ops on SDCC1 APPS clock in order to round down selected clock > frequency and avoid overclocking SD/eMMC cards. >=20 > For example, currently HS200 cards were failling tuning as they were > actually being clocked at 384MHz instead of 192MHz. > This caused some boards to disable 1.8V I/O and force the eMMC into the > standard HS mode (50MHz) and that appeared to work despite the eMMC being > overclocked to 96Mhz in that case. >=20 > There was a previous commit to use floor ops on SDCC clocks, but it looks > to have only covered SDCC2 clock. >=20 > Fixes: 9607f6224b39 ("clk: qcom: ipq8074: add PCIE, USB and SDCC clocks") >=20 > Signed-off-by: Dirk Buchwalder > Signed-off-by: Robert Marko > --- Reviewed-by: Stephen Boyd