Re: [PATCH v2 16/18] ARM: dts: qcom: remove redundant binding from ipq8064 rb3011 dts

Ansuel Smith
2022-02-20T14:45:13Z

On Fri, Feb 18, 2022 at 02:11:59PM +0000, Jonathan McDowell wrote:
> On Fri, Feb 18, 2022 at 01:29:54AM +0100, Ansuel Smith wrote:
> > Mdio0_pins are now declared in ipq8064 dtsi. Usb phy are enabled by
> > default.
> >
> > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> > ---
> > arch/arm/boot/dts/qcom-ipq8064-rb3011.dts | 17 -----------------
> > 1 file changed, 17 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts b/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> > index 0982b6214fb7..ddc9cc49ab60 100644
> > --- a/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> > +++ b/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> > @@ -259,10 +259,6 @@ &gsbi7_serial {
> > status = "okay";
> > };
> >
> > -&hs_phy_1 {
> > - status = "okay";
> > -};
> > -
> > &nand {
> > status = "okay";
> >
> > @@ -309,15 +305,6 @@ mux {
> > };
> > };
> >
> > - mdio0_pins: mdio0_pins {
> > - mux {
> > - pins = "gpio0", "gpio1";
> > - function = "gpio";
> > - drive-strength = <8>;
> > - bias-disable;
> > - };
> > - };
> > -
>
> This sets the pins to "gpio". Your earlier patch sets them to "mdio", so
> removing this will break MDIO0 on the RB3011. It's likely that your
> fixes for MDIO/QCA8K mean that the RB3011 can be switch to use the MDIO
> driver rather than mdio-gpio, but that will need tested and this change
> alone will definitely break things.
>

I could be wrong but I remember that before the mdio driver we used the
mdio-gpio driver with the pins set to mdio function without problems.

> > mdio1_pins: mdio1_pins {
> > mux {
> > pins = "gpio10", "gpio11";
> > @@ -358,10 +345,6 @@ mux {
> > };
> > };
> >
> > -&ss_phy_1 {
> > - status = "okay";
> > -};
> > -
> > &usb3_1 {
> > pinctrl-0 = <&usb1_pwr_en_pins>;
> > pinctrl-names = "default";
> > --
> > 2.34.1
> >
>
> J.
>
> --
> /-\ | Even the Evening Herald slags me
> |@/ Debian GNU/Linux Developer | off.
> \- |

--
Ansuel