Re: [PATCH v2 16/18] ARM: dts: qcom: remove redundant binding from ipq8064 rb3011 dts

Jonathan McDowell
2022-02-22T18:29:47Z

On Sun, Feb 20, 2022 at 03:44:54PM +0100, Ansuel Smith wrote:
> On Fri, Feb 18, 2022 at 02:11:59PM +0000, Jonathan McDowell wrote:
> > On Fri, Feb 18, 2022 at 01:29:54AM +0100, Ansuel Smith wrote:
> > > Mdio0_pins are now declared in ipq8064 dtsi. Usb phy are enabled by
> > > default.
> > >
> > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> > > ---
> > > arch/arm/boot/dts/qcom-ipq8064-rb3011.dts | 17 -----------------
> > > 1 file changed, 17 deletions(-)
...
> > > - mdio0_pins: mdio0_pins {
> > > - mux {
> > > - pins = "gpio0", "gpio1";
> > > - function = "gpio";
> > > - drive-strength = <8>;
> > > - bias-disable;
> > > - };
> > > - };
> > > -
> >
> > This sets the pins to "gpio". Your earlier patch sets them to "mdio", so
> > removing this will break MDIO0 on the RB3011. It's likely that your
> > fixes for MDIO/QCA8K mean that the RB3011 can be switch to use the MDIO
> > driver rather than mdio-gpio, but that will need tested and this change
> > alone will definitely break things.
> >
> I could be wrong but I remember that before the mdio driver we used the
> mdio-gpio driver with the pins set to mdio function without problems.

It seems like that's the case; I've just tried it out and switch0 seems
to be working fine.

J.

--
Revd Jonathan McDowell, ULC | Purrrrrrr.