From: kernel test robot <lkp@intel.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
Thara Gopinath <thara.gopinath@gmail.com>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Subject: Re: [PATCH v3 3/4] cpufreq: qcom-hw: fix the opp entries refcounting
Date: Sat, 26 Mar 2022 18:43:35 +0800 [thread overview]
Message-ID: <202203261801.7gUYlIj3-lkp@intel.com> (raw)
In-Reply-To: <20220325194721.2263571-4-dmitry.baryshkov@linaro.org>
Hi Dmitry,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on rafael-pm/linux-next]
[also build test WARNING on v5.17 next-20220325]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Dmitry-Baryshkov/cpufreq-qcom-hw-Fixes-for-cpu-hotplug-support/20220326-040226
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20220326/202203261801.7gUYlIj3-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 0f6d9501cf49ce02937099350d08f20c4af86f3d)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/0c1c62881dde7d4b3e6f74d8ab44f038f82f2f60
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Dmitry-Baryshkov/cpufreq-qcom-hw-Fixes-for-cpu-hotplug-support/20220326-040226
git checkout 0c1c62881dde7d4b3e6f74d8ab44f038f82f2f60
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/cpufreq/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/cpufreq/qcom-cpufreq-hw.c:314:54: warning: variable 'throttled_freq' is uninitialized when used here [-Wuninitialized]
arch_update_thermal_pressure(policy->related_cpus, throttled_freq);
^~~~~~~~~~~~~~
drivers/cpufreq/qcom-cpufreq-hw.c:295:39: note: initialize the variable 'throttled_freq' to silence this warning
unsigned long freq_hz, throttled_freq;
^
= 0
1 warning generated.
vim +/throttled_freq +314 drivers/cpufreq/qcom-cpufreq-hw.c
275157b367f479 Thara Gopinath 2021-08-09 289
275157b367f479 Thara Gopinath 2021-08-09 290 static void qcom_lmh_dcvs_notify(struct qcom_cpufreq_data *data)
275157b367f479 Thara Gopinath 2021-08-09 291 {
275157b367f479 Thara Gopinath 2021-08-09 292 struct cpufreq_policy *policy = data->policy;
054b9f6e7282ce Dmitry Baryshkov 2022-03-25 293 int cpu = cpumask_first(policy->related_cpus);
275157b367f479 Thara Gopinath 2021-08-09 294 struct device *dev = get_cpu_device(cpu);
0258cb19c77deb Lukasz Luba 2021-11-09 295 unsigned long freq_hz, throttled_freq;
275157b367f479 Thara Gopinath 2021-08-09 296 struct dev_pm_opp *opp;
275157b367f479 Thara Gopinath 2021-08-09 297 unsigned int freq;
275157b367f479 Thara Gopinath 2021-08-09 298
275157b367f479 Thara Gopinath 2021-08-09 299 /*
275157b367f479 Thara Gopinath 2021-08-09 300 * Get the h/w throttled frequency, normalize it using the
275157b367f479 Thara Gopinath 2021-08-09 301 * registered opp table and use it to calculate thermal pressure.
275157b367f479 Thara Gopinath 2021-08-09 302 */
275157b367f479 Thara Gopinath 2021-08-09 303 freq = qcom_lmh_get_throttle_freq(data);
275157b367f479 Thara Gopinath 2021-08-09 304 freq_hz = freq * HZ_PER_KHZ;
275157b367f479 Thara Gopinath 2021-08-09 305
275157b367f479 Thara Gopinath 2021-08-09 306 opp = dev_pm_opp_find_freq_floor(dev, &freq_hz);
275157b367f479 Thara Gopinath 2021-08-09 307 if (IS_ERR(opp) && PTR_ERR(opp) == -ERANGE)
0c1c62881dde7d Dmitry Baryshkov 2022-03-25 308 opp = dev_pm_opp_find_freq_ceil(dev, &freq_hz);
275157b367f479 Thara Gopinath 2021-08-09 309
0c1c62881dde7d Dmitry Baryshkov 2022-03-25 310 if (IS_ERR(opp)) {
0c1c62881dde7d Dmitry Baryshkov 2022-03-25 311 dev_warn(dev, "Can't find the OPP for throttling: %pe!\n", opp);
0c1c62881dde7d Dmitry Baryshkov 2022-03-25 312 } else {
0258cb19c77deb Lukasz Luba 2021-11-09 313 /* Update thermal pressure (the boost frequencies are accepted) */
0258cb19c77deb Lukasz Luba 2021-11-09 @314 arch_update_thermal_pressure(policy->related_cpus, throttled_freq);
275157b367f479 Thara Gopinath 2021-08-09 315
0c1c62881dde7d Dmitry Baryshkov 2022-03-25 316 dev_pm_opp_put(opp);
0c1c62881dde7d Dmitry Baryshkov 2022-03-25 317 }
0c1c62881dde7d Dmitry Baryshkov 2022-03-25 318
275157b367f479 Thara Gopinath 2021-08-09 319 /*
275157b367f479 Thara Gopinath 2021-08-09 320 * In the unlikely case policy is unregistered do not enable
275157b367f479 Thara Gopinath 2021-08-09 321 * polling or h/w interrupt
275157b367f479 Thara Gopinath 2021-08-09 322 */
275157b367f479 Thara Gopinath 2021-08-09 323 mutex_lock(&data->throttle_lock);
275157b367f479 Thara Gopinath 2021-08-09 324 if (data->cancel_throttle)
275157b367f479 Thara Gopinath 2021-08-09 325 goto out;
275157b367f479 Thara Gopinath 2021-08-09 326
275157b367f479 Thara Gopinath 2021-08-09 327 /*
275157b367f479 Thara Gopinath 2021-08-09 328 * If h/w throttled frequency is higher than what cpufreq has requested
275157b367f479 Thara Gopinath 2021-08-09 329 * for, then stop polling and switch back to interrupt mechanism.
275157b367f479 Thara Gopinath 2021-08-09 330 */
275157b367f479 Thara Gopinath 2021-08-09 331 if (throttled_freq >= qcom_cpufreq_hw_get(cpu))
275157b367f479 Thara Gopinath 2021-08-09 332 enable_irq(data->throttle_irq);
275157b367f479 Thara Gopinath 2021-08-09 333 else
275157b367f479 Thara Gopinath 2021-08-09 334 mod_delayed_work(system_highpri_wq, &data->throttle_work,
275157b367f479 Thara Gopinath 2021-08-09 335 msecs_to_jiffies(10));
275157b367f479 Thara Gopinath 2021-08-09 336
275157b367f479 Thara Gopinath 2021-08-09 337 out:
275157b367f479 Thara Gopinath 2021-08-09 338 mutex_unlock(&data->throttle_lock);
275157b367f479 Thara Gopinath 2021-08-09 339 }
275157b367f479 Thara Gopinath 2021-08-09 340
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-03-26 10:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 19:47 [PATCH v3 0/4] cpufreq: qcom-hw: Fixes for cpu hotplug support Dmitry Baryshkov
2022-03-25 19:47 ` [PATCH v3 1/4] cpufreq: qcom-hw: drop affinity hint before freeing the IRQ Dmitry Baryshkov
2022-03-25 19:47 ` [PATCH v3 2/4] cpufreq: qcom-hw: fix the race between LMH worker and cpuhp Dmitry Baryshkov
2022-03-25 19:47 ` [PATCH v3 3/4] cpufreq: qcom-hw: fix the opp entries refcounting Dmitry Baryshkov
2022-03-26 10:43 ` kernel test robot [this message]
2022-03-25 19:47 ` [PATCH v3 4/4] cpufreq: qcom-hw: provide online/offline operations Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202203261801.7gUYlIj3-lkp@intel.com \
--to=lkp@intel.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=rafael@kernel.org \
--cc=thara.gopinath@gmail.com \
--cc=viresh.kumar@linaro.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox