From: Marijn Suijten <marijn.suijten@somainline.org>
To: Abhinav Kumar <quic_abhinavk@quicinc.com>
Cc: Martin Botka <martin.botka@somainline.org>,
linux-arm-msm@vger.kernel.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
dri-devel@lists.freedesktop.org, swboyd@chromium.org,
robdclark@gmail.com, nganji@codeaurora.org,
seanpaul@chromium.org, daniel@ffwll.ch, markyacoub@chromium.org,
dmitry.baryshkov@linaro.org, quic_jesszhan@quicinc.com,
aravindh@codeaurora.org, freedreno@lists.freedesktop.org
Subject: Re: [Freedreno] [PATCH 06/12] drm/msm/dpu: make changes to dpu_encoder to support virtual encoder
Date: Sat, 16 Apr 2022 01:14:41 +0200 [thread overview]
Message-ID: <20220415231441.dd2cyrl7sfz5fvy3@SoMainline.org> (raw)
In-Reply-To: <227cb6b8-c4c5-aa24-a91e-ccbd29260b29@quicinc.com>
Hi Abhinav,
On 2022-04-15 12:25:55, Abhinav Kumar wrote:
> Hi Marijn
>
> Looking at msm-next tip, this code has already been refactored in
>
> https://gitlab.freedesktop.org/drm/msm/-/commit/ef58e0ad34365e2c8274b74e6e745b8c180ff0d3
>
> So, I will just rebase my changes on msm-next tip and it should address
> below comments as well.
That's actually great, I love patches that remove a whole lot of
(especially bug-containing) lines, awesome Dmitry!
Looking forward to the next revision, spotted some minor nits in this
revision but it probably makes little sense to point them out here
presuming they might have already been addressed on your end or removed
altogether.
- Marijn
next prev parent reply other threads:[~2022-04-15 23:14 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 21:17 [PATCH 00/12] Add writeback block support for DPU Abhinav Kumar
2022-02-04 21:17 ` [PATCH 01/12] drm/msm/dpu: add writeback blocks to the sm8250 DPU catalog Abhinav Kumar
2022-02-04 22:48 ` Dmitry Baryshkov
2022-02-04 21:17 ` [PATCH 02/12] drm/msm/dpu: add dpu_hw_wb abstraction for writeback blocks Abhinav Kumar
2022-02-04 22:56 ` Dmitry Baryshkov
2022-04-14 21:28 ` Abhinav Kumar
2022-04-14 21:41 ` Dmitry Baryshkov
2022-02-04 21:17 ` [PATCH 03/12] drm/msm/dpu: add writeback blocks to DPU RM Abhinav Kumar
2022-02-04 23:43 ` Dmitry Baryshkov
2022-04-14 21:30 ` Abhinav Kumar
2022-02-04 21:17 ` [PATCH 04/12] drm/msm/dpu: add changes to support writeback in hw_ctl Abhinav Kumar
2022-02-04 22:19 ` Dmitry Baryshkov
2022-04-14 21:50 ` Abhinav Kumar
2022-04-14 23:25 ` Dmitry Baryshkov
2022-04-15 0:01 ` Abhinav Kumar
2022-04-15 0:19 ` Dmitry Baryshkov
2022-04-15 0:27 ` [Freedreno] " Abhinav Kumar
2022-04-15 0:30 ` Abhinav Kumar
2022-02-04 21:17 ` [PATCH 05/12] drm/msm/dpu: add an API to reset the encoder related hw blocks Abhinav Kumar
2022-02-04 23:46 ` Dmitry Baryshkov
2022-04-14 21:53 ` Abhinav Kumar
2022-02-04 21:17 ` [PATCH 06/12] drm/msm/dpu: make changes to dpu_encoder to support virtual encoder Abhinav Kumar
2022-02-04 23:36 ` Dmitry Baryshkov
2022-04-14 21:54 ` Abhinav Kumar
2022-04-14 22:26 ` Marijn Suijten
2022-04-14 22:30 ` [Freedreno] " Abhinav Kumar
2022-04-15 19:25 ` Abhinav Kumar
2022-04-15 23:14 ` Marijn Suijten [this message]
2022-02-04 21:17 ` [PATCH 07/12] drm/msm/dpu: add encoder operations to prepare/cleanup wb job Abhinav Kumar
2022-02-04 23:42 ` Dmitry Baryshkov
2022-02-04 21:17 ` [PATCH 08/12] drm/msm/dpu: introduce the dpu_encoder_phys_* for writeback Abhinav Kumar
2022-02-04 23:19 ` Dmitry Baryshkov
2022-04-14 22:16 ` [Freedreno] " Abhinav Kumar
2022-04-15 0:24 ` Dmitry Baryshkov
2022-04-19 20:19 ` Abhinav Kumar
2022-02-04 21:17 ` [PATCH 09/12] drm/msm/dpu: add the writeback connector layer Abhinav Kumar
2022-02-04 23:24 ` Dmitry Baryshkov
2022-02-04 21:17 ` [PATCH 10/12] drm/msm/dpu: initialize dpu encoder and connector for writeback Abhinav Kumar
2022-02-04 22:34 ` Dmitry Baryshkov
2022-04-14 22:21 ` [Freedreno] " Abhinav Kumar
2022-02-04 21:17 ` [PATCH 11/12] drm/msm/dpu: gracefully handle null fb commits " Abhinav Kumar
2022-02-04 22:43 ` Dmitry Baryshkov
2022-04-14 23:17 ` Abhinav Kumar
2022-04-15 0:36 ` Dmitry Baryshkov
2022-04-15 1:50 ` Abhinav Kumar
2022-02-04 21:17 ` [PATCH 12/12] drm/msm/dpu: add writeback blocks to the display snapshot Abhinav Kumar
2022-02-04 22:36 ` Dmitry Baryshkov
2022-03-03 22:46 ` [PATCH 00/12] Add writeback block support for DPU Stephen Boyd
2022-03-03 23:40 ` Abhinav Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220415231441.dd2cyrl7sfz5fvy3@SoMainline.org \
--to=marijn.suijten@somainline.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=aravindh@codeaurora.org \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=markyacoub@chromium.org \
--cc=martin.botka@somainline.org \
--cc=nganji@codeaurora.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_jesszhan@quicinc.com \
--cc=robdclark@gmail.com \
--cc=seanpaul@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox