From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CED5EC433F5 for ; Wed, 27 Apr 2022 08:01:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234307AbiD0IEX (ORCPT ); Wed, 27 Apr 2022 04:04:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359253AbiD0IEX (ORCPT ); Wed, 27 Apr 2022 04:04:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B516155732 for ; Wed, 27 Apr 2022 01:01:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9AE2461B86 for ; Wed, 27 Apr 2022 08:01:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82B12C385A9; Wed, 27 Apr 2022 08:01:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651046471; bh=e1OamTbNjENnPRg8VTXFAk4Ge8BWuKjIPV8oBNXlP4c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H/4acNyCt5CX3OC9RUXX5fBau7Bn2erNd5o5OCVIhZKFLqxRYfBv1CVNyxDnrhCUT Hufw1lHLkQtGNU9vwc/F6RaZ6jNNFd82WHEe9wa/kyiZ0+wHqXPDa/lZuUjMjfrTgr HXSLoT0Jv4VTTFd7flxfWv/WAwmTyd7gv0Aadh2JrWlzJHlB7nH73nKxKVaw7ESutx xN0QE0AkG9nAL5JVkVQJXpl3pGOs8qEWfuhHkd1pvPvJdlqSaYhrpZN/s3ktrcyQad Tc1Eayzb/cdnHKewKZZ5Hnp1YMlpfqS1aHyaAmmbCR3q57t5U0QttmWAfgkaXem9cD oL310sWL6wFfQ== Date: Wed, 27 Apr 2022 13:31:04 +0530 From: Manivannan Sadhasivam To: Daniele Palmas Cc: mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 1/1] bus: mhi: pci_generic: add Telit FN980 v1 hardware revision Message-ID: <20220427080104.GA2536@thinkpad> References: <20220427072648.17635-1-dnlplm@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220427072648.17635-1-dnlplm@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Apr 27, 2022 at 09:26:48AM +0200, Daniele Palmas wrote: > Add Telit FN980 v1 hardware revision: > > 01:00.0 Unassigned class [ff00]: Qualcomm Device [17cb:0306] > Subsystem: Device [1c5d:2000] > > Signed-off-by: Daniele Palmas Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > V2: rebased after mhi_pci_id_table reordering > --- > drivers/bus/mhi/host/pci_generic.c | 38 ++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > > diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c > index 8858f3bf4f04..8e453b74e6cd 100644 > --- a/drivers/bus/mhi/host/pci_generic.c > +++ b/drivers/bus/mhi/host/pci_generic.c > @@ -446,6 +446,41 @@ static const struct mhi_pci_dev_info mhi_sierra_em919x_info = { > .sideband_wake = false, > }; > > +static const struct mhi_channel_config mhi_telit_fn980_hw_v1_channels[] = { > + MHI_CHANNEL_CONFIG_UL(14, "QMI", 32, 0), > + MHI_CHANNEL_CONFIG_DL(15, "QMI", 32, 0), > + MHI_CHANNEL_CONFIG_UL(20, "IPCR", 16, 0), > + MHI_CHANNEL_CONFIG_DL_AUTOQUEUE(21, "IPCR", 16, 0), > + MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0", 128, 1), > + MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0", 128, 2), > +}; > + > +static struct mhi_event_config mhi_telit_fn980_hw_v1_events[] = { > + MHI_EVENT_CONFIG_CTRL(0, 128), > + MHI_EVENT_CONFIG_HW_DATA(1, 1024, 100), > + MHI_EVENT_CONFIG_HW_DATA(2, 2048, 101) > +}; > + > +static struct mhi_controller_config modem_telit_fn980_hw_v1_config = { > + .max_channels = 128, > + .timeout_ms = 20000, > + .num_channels = ARRAY_SIZE(mhi_telit_fn980_hw_v1_channels), > + .ch_cfg = mhi_telit_fn980_hw_v1_channels, > + .num_events = ARRAY_SIZE(mhi_telit_fn980_hw_v1_events), > + .event_cfg = mhi_telit_fn980_hw_v1_events, > +}; > + > +static const struct mhi_pci_dev_info mhi_telit_fn980_hw_v1_info = { > + .name = "telit-fn980-hwv1", > + .fw = "qcom/sdx55m/sbl1.mbn", > + .edl = "qcom/sdx55m/edl.mbn", > + .config = &modem_telit_fn980_hw_v1_config, > + .bar_num = MHI_PCI_DEFAULT_BAR_NUM, > + .dma_data_width = 32, > + .mru_default = 32768, > + .sideband_wake = false, > +}; > + > /* Keep the list sorted based on the PID. New VID should be added as the last entry */ > static const struct pci_device_id mhi_pci_id_table[] = { > { PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0304), > @@ -453,6 +488,9 @@ static const struct pci_device_id mhi_pci_id_table[] = { > /* EM919x (sdx55), use the same vid:pid as qcom-sdx55m */ > { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, 0x18d7, 0x0200), > .driver_data = (kernel_ulong_t) &mhi_sierra_em919x_info }, > + /* Telit FN980 hardware revision v1 */ > + { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, 0x1C5D, 0x2000), > + .driver_data = (kernel_ulong_t) &mhi_telit_fn980_hw_v1_info }, > { PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0306), > .driver_data = (kernel_ulong_t) &mhi_qcom_sdx55_info }, > { PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0308), > -- > 2.32.0 >