From: Caleb Connolly <caleb.connolly@linaro.org>
To: caleb.connolly@linaro.org, Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Lee Jones <lee.jones@linaro.org>, Stephen Boyd <sboyd@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Cc: Jami Kettunen <jami.kettunen@somainline.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: [PATCH v14 03/10] mfd: qcom-spmi-pmic: read fab id on supported PMICs
Date: Fri, 29 Apr 2022 23:08:58 +0100 [thread overview]
Message-ID: <20220429220904.137297-4-caleb.connolly@linaro.org> (raw)
In-Reply-To: <20220429220904.137297-1-caleb.connolly@linaro.org>
The PMI8998 and PM660 expose the fab_id, this is needed by drivers like
the RRADC to calibrate ADC values.
Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Tested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
drivers/mfd/qcom-spmi-pmic.c | 7 +++++++
include/soc/qcom/qcom-spmi-pmic.h | 1 +
2 files changed, 8 insertions(+)
diff --git a/drivers/mfd/qcom-spmi-pmic.c b/drivers/mfd/qcom-spmi-pmic.c
index 5403306b1863..4e8b34554814 100644
--- a/drivers/mfd/qcom-spmi-pmic.c
+++ b/drivers/mfd/qcom-spmi-pmic.c
@@ -19,6 +19,7 @@
#define PMIC_REV4 0x103
#define PMIC_TYPE 0x104
#define PMIC_SUBTYPE 0x105
+#define PMIC_FAB_ID 0x1f2
#define PMIC_TYPE_VALUE 0x51
@@ -157,6 +158,12 @@ static int pmic_spmi_load_revid(struct regmap *map, struct device *dev,
if (ret < 0)
return ret;
+ if (pmic->subtype == PMI8998_SUBTYPE || pmic->subtype == PM660_SUBTYPE) {
+ ret = regmap_read(map, PMIC_FAB_ID, &pmic->fab_id);
+ if (ret < 0)
+ return ret;
+ }
+
/*
* In early versions of PM8941 and PM8226, the major revision number
* started incrementing from 0 (eg 0 = v1.0, 1 = v2.0).
diff --git a/include/soc/qcom/qcom-spmi-pmic.h b/include/soc/qcom/qcom-spmi-pmic.h
index 440e94235bfc..a2c9ac22c230 100644
--- a/include/soc/qcom/qcom-spmi-pmic.h
+++ b/include/soc/qcom/qcom-spmi-pmic.h
@@ -52,6 +52,7 @@ struct qcom_spmi_pmic {
unsigned int major;
unsigned int minor;
unsigned int rev2;
+ unsigned int fab_id;
const char *name;
};
--
2.36.0
next prev parent reply other threads:[~2022-04-29 22:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 22:08 [PATCH v14 00/10] iio: adc: introduce Qualcomm SPMI Round Robin ADC Caleb Connolly
2022-04-29 22:08 ` [PATCH v14 01/10] spmi: add a helper to look up an SPMI device from a device node Caleb Connolly
2022-05-01 17:23 ` Jonathan Cameron
2022-06-04 16:29 ` Jonathan Cameron
2022-06-14 8:40 ` Stephen Boyd
2022-04-29 22:08 ` [PATCH v14 02/10] mfd: qcom-spmi-pmic: expose the PMIC revid information to clients Caleb Connolly
2022-05-01 17:28 ` Jonathan Cameron
2022-06-14 10:42 ` Jonathan Cameron
2022-06-15 21:41 ` Lee Jones
2022-06-18 12:58 ` Jonathan Cameron
2022-04-29 22:08 ` Caleb Connolly [this message]
2022-06-15 21:40 ` [PATCH v14 03/10] mfd: qcom-spmi-pmic: read fab id on supported PMICs Lee Jones
2022-04-29 22:08 ` [PATCH v14 04/10] dt-bindings: iio: adc: document qcom-spmi-rradc Caleb Connolly
2022-04-30 14:44 ` Krzysztof Kozlowski
2022-04-30 15:00 ` Caleb Connolly
2022-05-01 8:28 ` Krzysztof Kozlowski
2022-06-14 10:45 ` Jonathan Cameron
2022-04-29 22:09 ` [PATCH v14 05/10] iio: adc: qcom-spmi-rradc: introduce round robin adc Caleb Connolly
2022-05-01 17:38 ` Jonathan Cameron
2022-05-09 11:53 ` Caleb Connolly
2022-06-14 10:44 ` Jonathan Cameron
2022-04-29 22:09 ` [PATCH v14 06/10] arm64: dts: qcom: pmi8998: add rradc node Caleb Connolly
2022-04-29 22:09 ` [PATCH v14 07/10] arm64: dts: qcom: sdm845-oneplus: enable rradc Caleb Connolly
2022-04-29 22:09 ` [PATCH v14 08/10] arm64: dts: qcom: sdm845-db845c: " Caleb Connolly
2022-04-29 22:09 ` [PATCH v14 09/10] arm64: dts: qcom: sdm845-xiaomi-beryllium: " Caleb Connolly
2022-04-29 22:09 ` [PATCH v14 10/10] arm64: dts: qcom: msm8998-oneplus-common: enable RRADC Caleb Connolly
2022-06-18 13:09 ` [PATCH v14 00/10] iio: adc: introduce Qualcomm SPMI Round Robin ADC Jonathan Cameron
2022-06-18 13:17 ` Jonathan Cameron
2022-06-18 16:13 ` Caleb Connolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220429220904.137297-4-caleb.connolly@linaro.org \
--to=caleb.connolly@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jami.kettunen@somainline.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).