Re: [PATCH 3/3] drm/msm: stop storing the array of CRTCs in struct msm_drm_private

[kernel test robot <lkp@intel.com>]

Hi Dmitry,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on next-20220506]
[also build test WARNING on v5.18-rc5]
[cannot apply to drm/drm-next v5.18-rc5 v5.18-rc4 v5.18-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Dmitry-Baryshkov/drm-msm-mdp4-convert-to-drm_crtc_handle_vblank/20220507-090522
base:    38a288f5941ef03752887ad86f2d85442358c99a
config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20220507/202205072052.67OjKtjD-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project af4cf1c6b8ed0d8102fc5e69acdc2fcbbcdaa9a7)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/08ab9442139f4b4c9e33ce35986014219fd1d5d0
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Dmitry-Baryshkov/drm-msm-mdp4-convert-to-drm_crtc_handle_vblank/20220507-090522
        git checkout 08ab9442139f4b4c9e33ce35986014219fd1d5d0
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/gpu/drm/msm/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/msm/msm_drv.c:428:22: warning: variable 'i' is uninitialized when used here [-Wuninitialized]
                   priv->event_thread[i].crtc = crtc;
                                      ^
   drivers/gpu/drm/msm/msm_drv.c:353:12: note: initialize the variable 'i' to silence this warning
           int ret, i;
                     ^
                      = 0
   1 warning generated.


vim +/i +428 drivers/gpu/drm/msm/msm_drv.c

   346	
   347	static int msm_drm_init(struct device *dev, const struct drm_driver *drv)
   348	{
   349		struct msm_drm_private *priv = dev_get_drvdata(dev);
   350		struct drm_device *ddev;
   351		struct msm_kms *kms;
   352		struct drm_crtc *crtc;
   353		int ret, i;
   354	
   355		if (drm_firmware_drivers_only())
   356			return -ENODEV;
   357	
   358		ddev = drm_dev_alloc(drv, dev);
   359		if (IS_ERR(ddev)) {
   360			DRM_DEV_ERROR(dev, "failed to allocate drm_device\n");
   361			return PTR_ERR(ddev);
   362		}
   363		ddev->dev_private = priv;
   364		priv->dev = ddev;
   365	
   366		priv->wq = alloc_ordered_workqueue("msm", 0);
   367		priv->hangcheck_period = DRM_MSM_HANGCHECK_DEFAULT_PERIOD;
   368	
   369		INIT_LIST_HEAD(&priv->objects);
   370		mutex_init(&priv->obj_lock);
   371	
   372		INIT_LIST_HEAD(&priv->inactive_willneed);
   373		INIT_LIST_HEAD(&priv->inactive_dontneed);
   374		INIT_LIST_HEAD(&priv->inactive_unpinned);
   375		mutex_init(&priv->mm_lock);
   376	
   377		/* Teach lockdep about lock ordering wrt. shrinker: */
   378		fs_reclaim_acquire(GFP_KERNEL);
   379		might_lock(&priv->mm_lock);
   380		fs_reclaim_release(GFP_KERNEL);
   381	
   382		drm_mode_config_init(ddev);
   383	
   384		ret = msm_init_vram(ddev);
   385		if (ret)
   386			return ret;
   387	
   388		/* Bind all our sub-components: */
   389		ret = component_bind_all(dev, ddev);
   390		if (ret)
   391			return ret;
   392	
   393		dma_set_max_seg_size(dev, UINT_MAX);
   394	
   395		msm_gem_shrinker_init(ddev);
   396	
   397		if (priv->kms_init) {
   398			ret = priv->kms_init(ddev);
   399			if (ret) {
   400				DRM_DEV_ERROR(dev, "failed to load kms\n");
   401				priv->kms = NULL;
   402				goto err_msm_uninit;
   403			}
   404			kms = priv->kms;
   405		} else {
   406			/* valid only for the dummy headless case, where of_node=NULL */
   407			WARN_ON(dev->of_node);
   408			kms = NULL;
   409		}
   410	
   411		/* Enable normalization of plane zpos */
   412		ddev->mode_config.normalize_zpos = true;
   413	
   414		if (kms) {
   415			kms->dev = ddev;
   416			ret = kms->funcs->hw_init(kms);
   417			if (ret) {
   418				DRM_DEV_ERROR(dev, "kms hw init failed: %d\n", ret);
   419				goto err_msm_uninit;
   420			}
   421		}
   422	
   423		ddev->mode_config.funcs = &mode_config_funcs;
   424		ddev->mode_config.helper_private = &mode_config_helper_funcs;
   425	
   426		drm_for_each_crtc(crtc, ddev) {
   427			/* initialize event thread */
 > 428			priv->event_thread[i].crtc = crtc;
   429			priv->event_thread[i].dev = ddev;
   430			priv->event_thread[i].worker = kthread_create_worker(0,
   431				"crtc_event:%d", priv->event_thread[i].crtc->base.id);
   432			if (IS_ERR(priv->event_thread[i].worker)) {
   433				ret = PTR_ERR(priv->event_thread[i].worker);
   434				DRM_DEV_ERROR(dev, "failed to create crtc_event kthread\n");
   435				ret = PTR_ERR(priv->event_thread[i].worker);
   436				goto err_msm_uninit;
   437			}
   438	
   439			sched_set_fifo(priv->event_thread[i].worker->task);
   440		}
   441	
   442		ret = drm_vblank_init(ddev, priv->num_crtcs);
   443		if (ret < 0) {
   444			DRM_DEV_ERROR(dev, "failed to initialize vblank\n");
   445			goto err_msm_uninit;
   446		}
   447	
   448		if (kms) {
   449			pm_runtime_get_sync(dev);
   450			ret = msm_irq_install(ddev, kms->irq);
   451			pm_runtime_put_sync(dev);
   452			if (ret < 0) {
   453				DRM_DEV_ERROR(dev, "failed to install IRQ handler\n");
   454				goto err_msm_uninit;
   455			}
   456		}
   457	
   458		ret = drm_dev_register(ddev, 0);
   459		if (ret)
   460			goto err_msm_uninit;
   461	
   462		if (kms) {
   463			ret = msm_disp_snapshot_init(ddev);
   464			if (ret)
   465				DRM_DEV_ERROR(dev, "msm_disp_snapshot_init failed ret = %d\n", ret);
   466		}
   467		drm_mode_config_reset(ddev);
   468	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp