From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Kuogee Hsieh <quic_khsieh@quicinc.com>,
Douglas Anderson <dianders@chromium.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH 2/2] phy: qcom-edp: drop regulator loads
Date: Wed, 3 Aug 2022 14:33:32 +0200 [thread overview]
Message-ID: <20220803123332.8138-3-johan+linaro@kernel.org> (raw)
In-Reply-To: <20220803123332.8138-1-johan+linaro@kernel.org>
Drivers should not be specifying active-mode regulator loads unless
supporting an idle mode where the load is reduced during runtime.
This effectively reverts commit a4888b2005d1 ("phy: qcom-edp: add
regulator_set_load to edp phy")
Link: https://lore.kernel.org/r/YuPps+cvVAMugWmy@sirena.org.uk
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/phy/qualcomm/phy-qcom-edp.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c
index 7e3570789845..cacd32f6e0cc 100644
--- a/drivers/phy/qualcomm/phy-qcom-edp.c
+++ b/drivers/phy/qualcomm/phy-qcom-edp.c
@@ -639,18 +639,6 @@ static int qcom_edp_phy_probe(struct platform_device *pdev)
if (ret)
return ret;
- ret = regulator_set_load(edp->supplies[0].consumer, 21800); /* 1.2 V vdda-phy */
- if (ret) {
- dev_err(dev, "failed to set load at %s\n", edp->supplies[0].supply);
- return ret;
- }
-
- ret = regulator_set_load(edp->supplies[1].consumer, 36000); /* 0.9 V vdda-pll */
- if (ret) {
- dev_err(dev, "failed to set load at %s\n", edp->supplies[1].supply);
- return ret;
- }
-
ret = qcom_edp_clks_register(edp, pdev->dev.of_node);
if (ret)
return ret;
--
2.35.1
next prev parent reply other threads:[~2022-08-03 12:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 12:33 [PATCH 0/2] phy: qcom: drop regulator loads Johan Hovold
2022-08-03 12:33 ` [PATCH 1/2] phy: qcom-qmp-combo: " Johan Hovold
2022-08-03 12:33 ` Johan Hovold [this message]
2022-08-03 15:30 ` [PATCH 0/2] phy: qcom: " Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220803123332.8138-3-johan+linaro@kernel.org \
--to=johan+linaro@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=kishon@ti.com \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_khsieh@quicinc.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).