Re: [PATCH 2/8] dt-bindings: remoteproc: qcom: adsp: Add compatible name for SC7280

[Rob Herring <robh@kernel.org>]

On Wed, Aug 03, 2022 at 07:51:14PM +0530, Srinivasa Rao Mandadapu wrote:
> Add compatible name and update max reg items for SC7280 base platforms.
> 
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> ---
>  .../devicetree/bindings/remoteproc/qcom,lpass-adsp-pil.yaml          | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,lpass-adsp-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,lpass-adsp-pil.yaml
> index 9f11332..147996f 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,lpass-adsp-pil.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,lpass-adsp-pil.yaml
> @@ -17,11 +17,12 @@ properties:
>    compatible:
>      enum:
>        - qcom,sdm845-adsp-pil
> +      - qcom,sc7280-adsp-pil
>  
>    reg:
> -    maxItems: 1
> +    maxItems: 2

sdm845 has 2 entries too?

>      description:
> -      The base address and size of the qdsp6ss register
> +      The base address and size of the qdsp6ss register and mcc register

Better expressed as:

minItems: 1
items:
  - description: qdsp6ss register
  - description: mcc register

Though the descriptions could expand on what those registers are.

Rob