linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jim Cromie <jim.cromie@gmail.com>
To: linux-kernel@vger.kernel.org, jbaron@akamai.com,
	gregkh@linuxfoundation.org, dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	intel-gvt-dev@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org
Cc: daniel.vetter@ffwll.ch, seanpaul@chromium.org,
	robdclark@gmail.com, Jim Cromie <jim.cromie@gmail.com>
Subject: [PATCH v5 15/33] kernel/module: add __dyndbg_classes section
Date: Fri,  5 Aug 2022 15:53:37 -0600	[thread overview]
Message-ID: <20220805215355.3509287-16-jim.cromie@gmail.com> (raw)
In-Reply-To: <20220805215355.3509287-1-jim.cromie@gmail.com>

Add __dyndbg_classes section, using __dyndbg as a model. Use it:

vmlinux.lds.h:

KEEP the new section, which also silences orphan section warning on
loadable modules.  Add (__start_/__stop_)__dyndbg_classes linker
symbols for the c externs (below).

kernel/module/main.c:
- fill new fields in find_module_sections(), using section_objs()
- extend callchain prototypes
  to pass classes, length
  load_module(): pass new info to dynamic_debug_setup()
  dynamic_debug_setup(): new params, pass through to ddebug_add_module()

dynamic_debug.c:
- add externs to the linker symbols.

ddebug_add_module():
- It currently builds a debug_table, and *will* find and attach classes.

dynamic_debug_init():
- add class fields to the _ddebug_info cursor var: di.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
 include/asm-generic/vmlinux.lds.h | 3 +++
 include/linux/dynamic_debug.h     | 2 ++
 kernel/module/main.c              | 2 ++
 lib/dynamic_debug.c               | 7 +++++++
 4 files changed, 14 insertions(+)

diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
index 7515a465ec03..9b8bd5504ad9 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@ -345,6 +345,9 @@
 	*(__tracepoints)						\
 	/* implement dynamic printk debug */				\
 	. = ALIGN(8);							\
+	__start___dyndbg_classes = .;					\
+	KEEP(*(__dyndbg_classes))					\
+	__stop___dyndbg_classes = .;					\
 	__start___dyndbg = .;						\
 	KEEP(*(__dyndbg))						\
 	__stop___dyndbg = .;						\
diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
index 71cdc8612257..46ed10682e87 100644
--- a/include/linux/dynamic_debug.h
+++ b/include/linux/dynamic_debug.h
@@ -115,7 +115,9 @@ struct ddebug_class_map {
 /* encapsulate linker provided built-in (or module) dyndbg data */
 struct _ddebug_info {
 	struct _ddebug *descs;
+	struct ddebug_class_map *classes;
 	unsigned int num_descs;
+	unsigned int num_classes;
 };
 
 #if defined(CONFIG_DYNAMIC_DEBUG_CORE)
diff --git a/kernel/module/main.c b/kernel/module/main.c
index cfe10356793d..f68f331c867d 100644
--- a/kernel/module/main.c
+++ b/kernel/module/main.c
@@ -2095,6 +2095,8 @@ static int find_module_sections(struct module *mod, struct load_info *info)
 
 	info->dyndbg.descs = section_objs(info, "__dyndbg",
 					sizeof(*info->dyndbg.descs), &info->dyndbg.num_descs);
+	info->dyndbg.classes = section_objs(info, "__dyndbg_classes",
+					sizeof(*info->dyndbg.classes), &info->dyndbg.num_classes);
 
 	return 0;
 }
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 457ce936191a..0d6cb6b258bd 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -41,6 +41,8 @@
 
 extern struct _ddebug __start___dyndbg[];
 extern struct _ddebug __stop___dyndbg[];
+extern struct ddebug_class_map __start___dyndbg_classes[];
+extern struct ddebug_class_map __stop___dyndbg_classes[];
 
 struct ddebug_table {
 	struct list_head link;
@@ -1079,7 +1081,9 @@ static int __init dynamic_debug_init(void)
 
 	struct _ddebug_info di = {
 		.descs = __start___dyndbg,
+		.classes = __start___dyndbg_classes,
 		.num_descs = __stop___dyndbg - __start___dyndbg,
+		.num_classes = __stop___dyndbg_classes - __start___dyndbg_classes,
 	};
 
 	if (&__start___dyndbg == &__stop___dyndbg) {
@@ -1122,6 +1126,9 @@ static int __init dynamic_debug_init(void)
 		 i, mod_ct, (int)((mod_ct * sizeof(struct ddebug_table)) >> 10),
 		 (int)((i * sizeof(struct _ddebug)) >> 10));
 
+	if (di.num_classes)
+		v2pr_info("  %d builtin ddebug class-maps\n", di.num_classes);
+
 	/* now that ddebug tables are loaded, process all boot args
 	 * again to find and activate queries given in dyndbg params.
 	 * While this has already been done for known boot params, it
-- 
2.37.1


  parent reply	other threads:[~2022-08-05 21:55 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-05 21:53 [PATCH v5 00/33] DYNDBG: opt-in class'd debug for modules, use in drm Jim Cromie
2022-08-05 21:53 ` [PATCH v5 01/33] dyndbg: fix static_branch manipulation Jim Cromie
2022-08-05 21:53 ` [PATCH v5 02/33] dyndbg: fix module.dyndbg handling Jim Cromie
2022-08-05 21:53 ` [PATCH v5 03/33] dyndbg: show both old and new in change-info Jim Cromie
2022-08-05 21:53 ` [PATCH v5 04/33] dyndbg: reverse module walk in cat control Jim Cromie
2022-08-05 21:53 ` [PATCH v5 05/33] dyndbg: reverse module.callsite " Jim Cromie
2022-08-05 21:53 ` [PATCH v5 06/33] dyndbg: use ESCAPE_SPACE for " Jim Cromie
2022-08-05 21:53 ` [PATCH v5 07/33] dyndbg: let query-modname override actual module name Jim Cromie
2022-08-05 21:53 ` [PATCH v5 08/33] dyndbg: add test_dynamic_debug module Jim Cromie
2022-08-05 21:53 ` [PATCH v5 09/33] dyndbg: drop EXPORTed dynamic_debug_exec_queries Jim Cromie
2022-08-05 21:53 ` [PATCH v5 10/33] dyndbg: cleanup local vars in ddebug_init Jim Cromie
2022-08-05 21:53 ` [PATCH v5 11/33] dyndbg: create and use struct _ddebug_info Jim Cromie
2022-08-05 21:53 ` [PATCH v5 12/33] dyndbg: add class_id to pr_debug callsites Jim Cromie
2022-08-05 21:53 ` [PATCH v5 13/33] dyndbg: add __pr_debug_cls for testing Jim Cromie
2022-08-05 21:53 ` [PATCH v5 14/33] dyndbg: add DECLARE_DYNDBG_CLASSMAP macro Jim Cromie
2022-08-05 21:53 ` Jim Cromie [this message]
2022-08-05 21:53 ` [PATCH v5 16/33] dyndbg: add ddebug_attach_module_classes Jim Cromie
2022-08-05 21:53 ` [PATCH v5 17/33] dyndbg: validate class FOO by checking with module Jim Cromie
2022-08-05 21:53 ` [PATCH v5 18/33] doc-dyndbg: describe "class CLASS_NAME" query support Jim Cromie
2022-08-05 21:53 ` [PATCH v5 19/33] doc-dyndbg: edit dynamic-debug-howto for brevity, audience Jim Cromie
2022-08-06 12:40   ` Bagas Sanjaya
2022-08-05 21:53 ` [PATCH v5 20/33] dyndbg: add drm.debug style (drm/parameters/debug) bitmap support Jim Cromie
2022-08-05 21:53 ` [PATCH v5 21/33] dyndbg: test DECLARE_DYNDBG_CLASSMAP, sysfs nodes Jim Cromie
2022-08-05 21:53 ` [PATCH v5 22/33] drm_print: condense enum drm_debug_category Jim Cromie
2022-08-05 21:53 ` [PATCH v5 23/33] drm: POC drm on dyndbg - use in core, 2 helpers, 3 drivers Jim Cromie
2022-08-05 21:53 ` [PATCH v5 24/33] drm_print: interpose drm_*dbg with forwarding macros Jim Cromie
2022-08-05 21:53 ` [PATCH v5 25/33] drm_print: wrap drm_*_dbg in dyndbg descriptor factory macro Jim Cromie
2022-08-05 21:53 ` [PATCH v5 26/33] drm-print.h: include dyndbg header Jim Cromie
2022-08-05 21:53 ` [PATCH v5 27/33] drm-print: add drm_dbg_driver to improve namespace symmetry Jim Cromie
2022-08-05 21:53 ` [PATCH v5 28/33] drm_print: refine drm_debug_enabled for jump-label Jim Cromie
2022-08-05 21:53 ` [PATCH v5 29/33] drm_print: prefer bare printk KERN_DEBUG on generic fn Jim Cromie
2022-08-05 21:53 ` [PATCH v5 30/33] drm_print: add _ddebug descriptor to drm_*dbg prototypes Jim Cromie
2022-08-05 21:53 ` [PATCH v5 31/33] nouveau: change nvkm_debug/trace to use dev_dbg POC Jim Cromie
2022-08-05 21:53 ` [PATCH v5 32/33] nouveau: adapt NV_DEBUG, NV_ATOMIC to use DRM.debug Jim Cromie
2022-08-05 21:53 ` [PATCH v5 33/33] nouveau: WIP add 2 LEVEL_NUM classmaps for CLI, SUBDEV Jim Cromie
2022-08-09 16:04 ` [PATCH v5 00/33] DYNDBG: opt-in class'd debug for modules, use in drm Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220805215355.3509287-16-jim.cromie@gmail.com \
    --to=jim.cromie@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-gvt-dev@lists.freedesktop.org \
    --cc=jbaron@akamai.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robdclark@gmail.com \
    --cc=seanpaul@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).