From: Jim Cromie <jim.cromie@gmail.com>
To: linux-kernel@vger.kernel.org, jbaron@akamai.com,
gregkh@linuxfoundation.org, dri-devel@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org
Cc: daniel.vetter@ffwll.ch, seanpaul@chromium.org,
robdclark@gmail.com, Jim Cromie <jim.cromie@gmail.com>
Subject: [PATCH v5 24/33] drm_print: interpose drm_*dbg with forwarding macros
Date: Fri, 5 Aug 2022 15:53:46 -0600 [thread overview]
Message-ID: <20220805215355.3509287-25-jim.cromie@gmail.com> (raw)
In-Reply-To: <20220805215355.3509287-1-jim.cromie@gmail.com>
change drm_dev_dbg & drm_dbg to macros, which forward to the renamed
functions (with __ prefix added).
Those functions sit below the categorized layer of macros implementing
the DRM debug.category API, and implement most of it. These are good
places to insert dynamic-debug jump-label mechanics, which will allow
DRM to avoid the runtime cost of drm_debug_enabled().
no functional changes.
memory cost baseline: (unchanged)
bash-5.1# drms_load
[ 9.220389] dyndbg: 1 debug prints in module drm
[ 9.224426] ACPI: bus type drm_connector registered
[ 9.302192] dyndbg: 2 debug prints in module ttm
[ 9.305033] dyndbg: 8 debug prints in module video
[ 9.627563] dyndbg: 127 debug prints in module i915
[ 9.721505] AMD-Vi: AMD IOMMUv2 functionality not available on this system - This is not a bug.
[ 10.091345] dyndbg: 2196 debug prints in module amdgpu
[ 10.106589] [drm] amdgpu kernel modesetting enabled.
[ 10.107270] amdgpu: CRAT table not found
[ 10.107926] amdgpu: Virtual CRAT table created for CPU
[ 10.108398] amdgpu: Topology: Add CPU node
[ 10.168507] dyndbg: 3 debug prints in module wmi
[ 10.329587] dyndbg: 3 debug prints in module nouveau
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
drivers/gpu/drm/drm_print.c | 10 +++++-----
include/drm/drm_print.h | 9 +++++++--
2 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/drm_print.c b/drivers/gpu/drm/drm_print.c
index ec32df35a3e3..29a29949ad0b 100644
--- a/drivers/gpu/drm/drm_print.c
+++ b/drivers/gpu/drm/drm_print.c
@@ -279,8 +279,8 @@ void drm_dev_printk(const struct device *dev, const char *level,
}
EXPORT_SYMBOL(drm_dev_printk);
-void drm_dev_dbg(const struct device *dev, enum drm_debug_category category,
- const char *format, ...)
+void __drm_dev_dbg(const struct device *dev, enum drm_debug_category category,
+ const char *format, ...)
{
struct va_format vaf;
va_list args;
@@ -301,9 +301,9 @@ void drm_dev_dbg(const struct device *dev, enum drm_debug_category category,
va_end(args);
}
-EXPORT_SYMBOL(drm_dev_dbg);
+EXPORT_SYMBOL(__drm_dev_dbg);
-void __drm_dbg(enum drm_debug_category category, const char *format, ...)
+void ___drm_dbg(enum drm_debug_category category, const char *format, ...)
{
struct va_format vaf;
va_list args;
@@ -320,7 +320,7 @@ void __drm_dbg(enum drm_debug_category category, const char *format, ...)
va_end(args);
}
-EXPORT_SYMBOL(__drm_dbg);
+EXPORT_SYMBOL(___drm_dbg);
void __drm_err(const char *format, ...)
{
diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
index 668273e36c2c..c429c258c957 100644
--- a/include/drm/drm_print.h
+++ b/include/drm/drm_print.h
@@ -335,7 +335,7 @@ __printf(3, 4)
void drm_dev_printk(const struct device *dev, const char *level,
const char *format, ...);
__printf(3, 4)
-void drm_dev_dbg(const struct device *dev, enum drm_debug_category category,
+void __drm_dev_dbg(const struct device *dev, enum drm_debug_category category,
const char *format, ...);
/**
@@ -384,6 +384,9 @@ void drm_dev_dbg(const struct device *dev, enum drm_debug_category category,
} \
})
+#define drm_dev_dbg(dev, cat, fmt, ...) \
+ __drm_dev_dbg(dev, cat, fmt, ##__VA_ARGS__)
+
/**
* DRM_DEV_DEBUG() - Debug output for generic drm code
*
@@ -485,10 +488,12 @@ void drm_dev_dbg(const struct device *dev, enum drm_debug_category category,
*/
__printf(2, 3)
-void __drm_dbg(enum drm_debug_category category, const char *format, ...);
+void ___drm_dbg(enum drm_debug_category category, const char *format, ...);
__printf(1, 2)
void __drm_err(const char *format, ...);
+#define __drm_dbg(fmt, ...) ___drm_dbg(fmt, ##__VA_ARGS__)
+
/* Macros to make printk easier */
#define _DRM_PRINTK(once, level, fmt, ...) \
--
2.37.1
next prev parent reply other threads:[~2022-08-05 21:56 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 21:53 [PATCH v5 00/33] DYNDBG: opt-in class'd debug for modules, use in drm Jim Cromie
2022-08-05 21:53 ` [PATCH v5 01/33] dyndbg: fix static_branch manipulation Jim Cromie
2022-08-05 21:53 ` [PATCH v5 02/33] dyndbg: fix module.dyndbg handling Jim Cromie
2022-08-05 21:53 ` [PATCH v5 03/33] dyndbg: show both old and new in change-info Jim Cromie
2022-08-05 21:53 ` [PATCH v5 04/33] dyndbg: reverse module walk in cat control Jim Cromie
2022-08-05 21:53 ` [PATCH v5 05/33] dyndbg: reverse module.callsite " Jim Cromie
2022-08-05 21:53 ` [PATCH v5 06/33] dyndbg: use ESCAPE_SPACE for " Jim Cromie
2022-08-05 21:53 ` [PATCH v5 07/33] dyndbg: let query-modname override actual module name Jim Cromie
2022-08-05 21:53 ` [PATCH v5 08/33] dyndbg: add test_dynamic_debug module Jim Cromie
2022-08-05 21:53 ` [PATCH v5 09/33] dyndbg: drop EXPORTed dynamic_debug_exec_queries Jim Cromie
2022-08-05 21:53 ` [PATCH v5 10/33] dyndbg: cleanup local vars in ddebug_init Jim Cromie
2022-08-05 21:53 ` [PATCH v5 11/33] dyndbg: create and use struct _ddebug_info Jim Cromie
2022-08-05 21:53 ` [PATCH v5 12/33] dyndbg: add class_id to pr_debug callsites Jim Cromie
2022-08-05 21:53 ` [PATCH v5 13/33] dyndbg: add __pr_debug_cls for testing Jim Cromie
2022-08-05 21:53 ` [PATCH v5 14/33] dyndbg: add DECLARE_DYNDBG_CLASSMAP macro Jim Cromie
2022-08-05 21:53 ` [PATCH v5 15/33] kernel/module: add __dyndbg_classes section Jim Cromie
2022-08-05 21:53 ` [PATCH v5 16/33] dyndbg: add ddebug_attach_module_classes Jim Cromie
2022-08-05 21:53 ` [PATCH v5 17/33] dyndbg: validate class FOO by checking with module Jim Cromie
2022-08-05 21:53 ` [PATCH v5 18/33] doc-dyndbg: describe "class CLASS_NAME" query support Jim Cromie
2022-08-05 21:53 ` [PATCH v5 19/33] doc-dyndbg: edit dynamic-debug-howto for brevity, audience Jim Cromie
2022-08-06 12:40 ` Bagas Sanjaya
2022-08-05 21:53 ` [PATCH v5 20/33] dyndbg: add drm.debug style (drm/parameters/debug) bitmap support Jim Cromie
2022-08-05 21:53 ` [PATCH v5 21/33] dyndbg: test DECLARE_DYNDBG_CLASSMAP, sysfs nodes Jim Cromie
2022-08-05 21:53 ` [PATCH v5 22/33] drm_print: condense enum drm_debug_category Jim Cromie
2022-08-05 21:53 ` [PATCH v5 23/33] drm: POC drm on dyndbg - use in core, 2 helpers, 3 drivers Jim Cromie
2022-08-05 21:53 ` Jim Cromie [this message]
2022-08-05 21:53 ` [PATCH v5 25/33] drm_print: wrap drm_*_dbg in dyndbg descriptor factory macro Jim Cromie
2022-08-05 21:53 ` [PATCH v5 26/33] drm-print.h: include dyndbg header Jim Cromie
2022-08-05 21:53 ` [PATCH v5 27/33] drm-print: add drm_dbg_driver to improve namespace symmetry Jim Cromie
2022-08-05 21:53 ` [PATCH v5 28/33] drm_print: refine drm_debug_enabled for jump-label Jim Cromie
2022-08-05 21:53 ` [PATCH v5 29/33] drm_print: prefer bare printk KERN_DEBUG on generic fn Jim Cromie
2022-08-05 21:53 ` [PATCH v5 30/33] drm_print: add _ddebug descriptor to drm_*dbg prototypes Jim Cromie
2022-08-05 21:53 ` [PATCH v5 31/33] nouveau: change nvkm_debug/trace to use dev_dbg POC Jim Cromie
2022-08-05 21:53 ` [PATCH v5 32/33] nouveau: adapt NV_DEBUG, NV_ATOMIC to use DRM.debug Jim Cromie
2022-08-05 21:53 ` [PATCH v5 33/33] nouveau: WIP add 2 LEVEL_NUM classmaps for CLI, SUBDEV Jim Cromie
2022-08-09 16:04 ` [PATCH v5 00/33] DYNDBG: opt-in class'd debug for modules, use in drm Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220805215355.3509287-25-jim.cromie@gmail.com \
--to=jim.cromie@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jbaron@akamai.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).