* [PATCH] dmaengine: qcom: gpi: move read_lock_bh to read_lock in tasklet
@ 2022-08-14 13:13 Tuo Cao
2022-09-29 6:51 ` Vinod Koul
0 siblings, 1 reply; 3+ messages in thread
From: Tuo Cao @ 2022-08-14 13:13 UTC (permalink / raw)
To: agross, bjorn.andersson, vkoul
Cc: konrad.dybcio, linux-arm-msm, dmaengine, linux-kernel, 91tuocao
it is unnecessary to call read_lock_bh in a tasklet.
Signed-off-by: Tuo Cao <91tuocao@gmail.com>
---
drivers/dma/qcom/gpi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
index 8f0c9c4e2efd..236005f7dd30 100644
--- a/drivers/dma/qcom/gpi.c
+++ b/drivers/dma/qcom/gpi.c
@@ -1150,9 +1150,9 @@ static void gpi_ev_tasklet(unsigned long data)
{
struct gpii *gpii = (struct gpii *)data;
- read_lock_bh(&gpii->pm_lock);
+ read_lock(&gpii->pm_lock);
if (!REG_ACCESS_VALID(gpii->pm_state)) {
- read_unlock_bh(&gpii->pm_lock);
+ read_unlock(&gpii->pm_lock);
dev_err(gpii->gpi_dev->dev, "not processing any events, pm_state:%s\n",
TO_GPI_PM_STR(gpii->pm_state));
return;
@@ -1163,7 +1163,7 @@ static void gpi_ev_tasklet(unsigned long data)
/* enable IEOB, switching back to interrupts */
gpi_config_interrupts(gpii, MASK_IEOB_SETTINGS, 1);
- read_unlock_bh(&gpii->pm_lock);
+ read_unlock(&gpii->pm_lock);
}
/* marks all pending events for the channel as stale */
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] dmaengine: qcom: gpi: move read_lock_bh to read_lock in tasklet
@ 2022-08-22 13:46 Tuo Cao
0 siblings, 0 replies; 3+ messages in thread
From: Tuo Cao @ 2022-08-22 13:46 UTC (permalink / raw)
To: agross, bjorn.andersson, konrad.dybcio, vkoul
Cc: linux-arm-msm, dmaengine, linux-kernel, 91tuocao
it is unnecessary to call read_lock_bh in a tasklet.
Signed-off-by: Tuo Cao <91tuocao@gmail.com>
---
drivers/dma/qcom/gpi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
index 8f0c9c4e2efd..236005f7dd30 100644
--- a/drivers/dma/qcom/gpi.c
+++ b/drivers/dma/qcom/gpi.c
@@ -1150,9 +1150,9 @@ static void gpi_ev_tasklet(unsigned long data)
{
struct gpii *gpii = (struct gpii *)data;
- read_lock_bh(&gpii->pm_lock);
+ read_lock(&gpii->pm_lock);
if (!REG_ACCESS_VALID(gpii->pm_state)) {
- read_unlock_bh(&gpii->pm_lock);
+ read_unlock(&gpii->pm_lock);
dev_err(gpii->gpi_dev->dev, "not processing any events, pm_state:%s\n",
TO_GPI_PM_STR(gpii->pm_state));
return;
@@ -1163,7 +1163,7 @@ static void gpi_ev_tasklet(unsigned long data)
/* enable IEOB, switching back to interrupts */
gpi_config_interrupts(gpii, MASK_IEOB_SETTINGS, 1);
- read_unlock_bh(&gpii->pm_lock);
+ read_unlock(&gpii->pm_lock);
}
/* marks all pending events for the channel as stale */
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: qcom: gpi: move read_lock_bh to read_lock in tasklet
2022-08-14 13:13 [PATCH] dmaengine: qcom: gpi: move read_lock_bh to read_lock in tasklet Tuo Cao
@ 2022-09-29 6:51 ` Vinod Koul
0 siblings, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2022-09-29 6:51 UTC (permalink / raw)
To: Tuo Cao
Cc: agross, bjorn.andersson, konrad.dybcio, linux-arm-msm, dmaengine,
linux-kernel
On 14-08-22, 21:13, Tuo Cao wrote:
> it is unnecessary to call read_lock_bh in a tasklet.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-29 6:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-14 13:13 [PATCH] dmaengine: qcom: gpi: move read_lock_bh to read_lock in tasklet Tuo Cao
2022-09-29 6:51 ` Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2022-08-22 13:46 Tuo Cao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).