From: Stephen Boyd <sboyd@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Johan Hovold <johan+linaro@kernel.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>
Subject: Re: [PATCH 0/2] clk: gcc-sc8280xp: fix broken suspend
Date: Mon, 22 Aug 2022 19:15:25 -0700 [thread overview]
Message-ID: <20220823021528.7291FC433D6@smtp.kernel.org> (raw)
In-Reply-To: <20220805121250.10347-1-johan+linaro@kernel.org>
Quoting Johan Hovold (2022-08-05 05:12:48)
> The Qualcomm PCIe driver currently does not implement suspend at all so
> we need to mark the GDSCs as always-on to prevent genpd from disabling
> them.
>
> Similarly, the Qualcomm dwc3 USB suspend implementation is also
> incomplete and the controller doesn't currently survive a suspend cycle
> unless the GDSC is kept on. Note that this has nothing to with whether
> wakeup is enabled or not (cf. [1]).
>
> With these two workarounds, we have somewhat functional suspend on the
> SC8280XP reference design and Lenovo Thinkpad X13s until the missing
> driver support is in place (even USB remote wakeup works with [2]
> applied).
Are these urgently needed for this release or does suspend not really
work yet on sc8280xp? I'm trying to understand if we need to apply
these to the fixes tree (in which case why isn't there a Fixes tag
targetting whatever commit broke suspend) or if they can wait for the
next release and come through clk-next.
next prev parent reply other threads:[~2022-08-23 2:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 12:12 [PATCH 0/2] clk: gcc-sc8280xp: fix broken suspend Johan Hovold
2022-08-05 12:12 ` [PATCH 1/2] clk: gcc-sc8280xp: keep PCIe power-domains always-on Johan Hovold
2022-08-06 15:10 ` Manivannan Sadhasivam
2022-08-05 12:12 ` [PATCH 2/2] clk: gcc-sc8280xp: keep USB " Johan Hovold
2022-08-06 15:11 ` Manivannan Sadhasivam
2022-08-23 2:15 ` Stephen Boyd [this message]
2022-08-23 11:09 ` [PATCH 0/2] clk: gcc-sc8280xp: fix broken suspend Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220823021528.7291FC433D6@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).