From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04912C32796 for ; Wed, 24 Aug 2022 14:58:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238847AbiHXO6N (ORCPT ); Wed, 24 Aug 2022 10:58:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239356AbiHXO6H (ORCPT ); Wed, 24 Aug 2022 10:58:07 -0400 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AABA48E99D for ; Wed, 24 Aug 2022 07:57:58 -0700 (PDT) Received: by mail-pl1-x631.google.com with SMTP id v23so10609239plo.9 for ; Wed, 24 Aug 2022 07:57:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc; bh=41sAcz9c3vs/nXk4pYq7pvmGQL8rf/lJNZMSCRKunZY=; b=BplH8rV9dJab5d0+huQtWC9Ga3VR4bg3HipSXAjQvMaPC6oYxdJTJiXgqlWuH1DceA uOZSt/F5WeWN5n+FyPXGEyDsyw/W/ZAA0Wgd+ntyacyrJKzcCOi+niQEJRx2Mh4/CAQM +ED8IqxRJHLZEIL6WZ/NHxeOBtogGNnCzyJ463hxwPDI2lFaEkyiZYbdXm/oFarHxA4o vzlHoWqqPtXcKldCP1U6FEOaDrqbDNgahQyWW0c3wHYzub3jLQ706KKpG3G71SOVat4V aI1KDvuSAwE+TcQaCZrWgTrNBsvR/gezSSHBieWOeAqaJgAD3Lt0egbewPt0HKhG6mlN knBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc; bh=41sAcz9c3vs/nXk4pYq7pvmGQL8rf/lJNZMSCRKunZY=; b=lXDBEYkFgqZhIpkwwxVUzhjBjeEk57Otmpr9bNLof8N7pUZo64hYHlCj0R0LDtTWla 6GqS4eqtvTSHykNdaBf2SfeOA/zfgEXpmEvjsu/WmQ0n0u7no4tCvP3naCZY6k0UKZl+ q8QzLP342sTyflqOuoKsrc6qqSbDNs0aY7xdNG+SfXmG6KIHRMBkJT7u+1KMUcMK/ePU UbbXMaW5FxmLHYi/dPinXXHkcumzK2dnIdoy8HhHsrNmh+jgKjYA+rcyy8tU9g5c96jn bOteUPYdu2fHMGwlJPeNyJZM5SH8xSVXRzH1Yr5bAh2xtyu5VKRFCEVzoIB+sZpa4YM4 bI/A== X-Gm-Message-State: ACgBeo3lLb0K4nG/vWWaM0wwz0dCJVw/a9zUeDUN3y44yE6WTLQOoR47 hOQtYOVu/ULJgtojRv2jPClx X-Google-Smtp-Source: AA6agR77UPEmdtKtAgeec0tOsknV1XD+1Mb+D7hmZ1LJDqjwAh3z8uumtlhAObxtWctNxqbgo6L6sw== X-Received: by 2002:a17:90a:cb13:b0:1fb:1aab:4f72 with SMTP id z19-20020a17090acb1300b001fb1aab4f72mr8526798pjt.58.1661353078135; Wed, 24 Aug 2022 07:57:58 -0700 (PDT) Received: from thinkpad ([117.207.24.28]) by smtp.gmail.com with ESMTPSA id u9-20020a170902e5c900b00172fad607b3sm4842211plf.207.2022.08.24.07.57.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Aug 2022 07:57:57 -0700 (PDT) Date: Wed, 24 Aug 2022 20:27:48 +0530 From: Manivannan Sadhasivam To: Dmitry Baryshkov Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Vinod Koul , Kishon Vijay Abraham I , Philipp Zabel , Johan Hovold , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, linux-phy@lists.infradead.org Subject: Re: [PATCH v1 3/4] PCI: qcom: Setup PHY to work in RC mode Message-ID: <20220824145748.GF4767@thinkpad> References: <20220726203401.595934-1-dmitry.baryshkov@linaro.org> <20220726203401.595934-4-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220726203401.595934-4-dmitry.baryshkov@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Jul 26, 2022 at 11:34:00PM +0300, Dmitry Baryshkov wrote: > Call phy_set_mode_ext() to notify the PHY driver that the PHY is being > used in the RC mode. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > drivers/pci/controller/dwc/pcie-qcom.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > index 93d75cda4b04..f85f2579c087 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom.c > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > @@ -1485,6 +1485,10 @@ static int qcom_pcie_host_init(struct dw_pcie_rp *pp) > if (ret) > return ret; > > + ret = phy_set_mode_ext(pcie->phy, PHY_MODE_PCIE, 0); > + if (ret) > + return err_deinit; > + > ret = phy_power_on(pcie->phy); > if (ret) > goto err_deinit; > -- > 2.35.1 > -- மணிவண்ணன் சதாசிவம்