Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Bjorn Andersson <andersson@kernel.org>
To: Rudraksha Gupta <guptarud@gmail.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
	agross@kernel.org, david@ixit.cz, devicetree@vger.kernel.org,
	krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org
Subject: Re: [PATCH v2 1/2] ARM: msm8960: Rename cxo_board to cxo-board and add alias
Date: Mon, 29 Aug 2022 16:54:43 -0500	[thread overview]
Message-ID: <20220829215443.dvc5xnmeqnhmxb2d@builder.lan> (raw)
In-Reply-To: <499c8b49-a09e-e775-3242-13d37a13877e@gmail.com>

On Wed, Aug 10, 2022 at 10:51:51PM -0400, Rudraksha Gupta wrote:
> > Clock and dts patches goes through two different paths towards mainline,
> 
> > so they should be separated.
> 
> Gotcha, thanks. I will do that.
> 
> 
> > This breaks compatibility with existing DTB files.
> 
> > What you probably want is to make sure that any clocks with parent name
> 
> > of "cxo", should have a .fw_name = "cxo", then you can make a
> 
> > phandle-based reference in DT and these global names doesn't matter (and
> 
> > in the end we can remove this board_clk from the driver).
> 
> Ah, I see. If I understand correctly, it should be something like this,
> right?
> https://github.com/torvalds/linux/blob/master/drivers/clk/qcom/gcc-msm8996.c#L169-L172

Correct, this will try to find the clock by clock-names of "cxo" and if
not found fall back to do a lookup globally just on the name "xo_board".

So it seems making .name "cxo_board" should handle both cases nicely.

Regards,
Bjorn

  reply	other threads:[~2022-08-29 21:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-08 23:47 [PATCH 1/2] ARM: msm8960: Rename cxo_board to cxo-board and add alias Rudraksha Gupta
2022-08-08 23:47 ` [PATCH 2/2] ARM: msm8960: Add Samsung Galaxy Express support Rudraksha Gupta
2022-08-09  0:02   ` [PATCH v2 1/2] ARM: msm8960: Rename cxo_board to cxo-board and add alias Rudraksha Gupta
2022-08-09  0:03     ` [PATCH v2 2/2] ARM: msm8960: Add Samsung Galaxy Express support Rudraksha Gupta
2022-08-09  5:35       ` Krzysztof Kozlowski
2022-08-09 23:57         ` Rudraksha Gupta
2022-08-10  7:47           ` Krzysztof Kozlowski
2022-08-09  5:32     ` [PATCH v2 1/2] ARM: msm8960: Rename cxo_board to cxo-board and add alias Krzysztof Kozlowski
2022-08-10 19:53     ` Bjorn Andersson
2022-08-11  2:51       ` Rudraksha Gupta
2022-08-29 21:54         ` Bjorn Andersson [this message]
2023-02-21  6:40           ` Rudraksha Gupta
2022-08-09  5:30 ` [PATCH " Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220829215443.dvc5xnmeqnhmxb2d@builder.lan \
    --to=andersson@kernel.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=david@ixit.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=guptarud@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox